Uh oh!
There was an error while loading. Please reload this page.
ref(opentelemetry): Replace @opentelemetry/resources with inline getSentryResource() - #20327
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6c9d83d. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
…etSentryResource()`
Add a minimal `SentryResource` class in `@sentry/opentelemetry` that satisfies the OTel `Resource` interface, and a `getSentryResource(serviceName)` helper that produces the exact same merged resource we previously built via `defaultResource().merge(resourceFromAttributes({...}))`.
This removes direct imports of `@opentelemetry/resources` from `@sentry/node`, `@sentry/vercel-edge`, and test helpers, and drops the package from `node`'s dependencies and `node-core`'s peer/dev dependencies.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>mydeaforce-pushed
the
fn/vendor-otel-resource
branch
from
April 15, 2026 12:14
6c9d83d to
ba69f1cCompareJPeer264
approved these changes
Apr 15, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Also nice as this removes some repetition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentryResourceclass in@sentry/opentelemetrythat structurally satisfies the OTelResourceinterface (attributes,merge(),getRawAttributes())getSentryResource(serviceName)which produces the same 6-attribute resource previously built viadefaultResource().merge(resourceFromAttributes({...}))@opentelemetry/resourcesimports from@sentry/node,@sentry/vercel-edge, and test helpers@opentelemetry/resourcesfrom@sentry/nodedependencies and@sentry/node-corepeer/dev dependenciesTest plan
yarn testpasses for@sentry/opentelemetry,@sentry/node,@sentry/vercel-edge,@sentry/node-coreyarn build:devsucceeds for all affected packages🤖 Generated with Claude Code