Skip to content

feat: Tracing + Reduced Bundle Size + build updates - #2038

Merged
HazAT merged 29 commits into
masterfrom
feat/tracing
May 8, 2019
Merged

feat: Tracing + Reduced Bundle Size + build updates#2038
HazAT merged 29 commits into
masterfrom
feat/tracing

Conversation

@HazAT

@HazATHazAT commented Apr 25, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This PR adds Tracing integration that patches XHR and fetch to add sentry-trace header for whitelisted urls in traceOrigins. It's still considered internal but we will ship a beta version running on sentry.io to see how it goes.

@HazAT
HazAT requested a review from kamilogorek as a code ownerApril 25, 2019 12:49
@HazATHazAT self-assigned this Apr 25, 2019
@getsentry-bot

getsentry-bot commented Apr 25, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖✅ TSLint passed
📖

@sentry/browser bundle gzip'ed minified size: ($ cat build/bundle.es6.min.js | gzip -9 | wc -c | awk '{$1=$1/1024; print "ES6: ",$1,"kB";}') (ES6: 14.5703 kB)

Generated by 🚫 dangerJS against 3c775eb

@HazATHazAT mentioned this pull request Apr 26, 2019
Merged
@HazATHazAT mentioned this pull request May 6, 2019
Closed
8 tasks
@HazATHazAT changed the title [WIP] Feat/tracingfeat: Tracing + Reduced Bundle Size + build updatesMay 8, 2019
kamilogorek
kamilogorek suggested changes May 8, 2019
View reviewed changes
Comment thread.travis.yml
Comment threadpackages/browser/rollup.config.js
Comment threadpackages/browser/src/transports/base.ts
Comment threadpackages/hub/src/hub.ts
Comment threadpackages/hub/src/index.ts Outdated
Comment threadpackages/integrations/src/tracing.ts
Comment threadpackages/integrations/src/tracing.ts
Comment threadpackages/node/src/handlers.ts Outdated
Comment threadpackages/typescript/tslint.json
Comment threadpackages/utils/src/syncpromise.ts
kamilogorek
kamilogorek reviewed May 8, 2019
View reviewed changes
Comment threadpackages/integrations/src/tracing.ts
public constructor(private readonly _options: TracingOptions) {
if (!Array.isArray(_options.tracingOrigins) || _options.tracingOrigins.length === 0) {
consoleSandbox(() => {
const defaultTracingOrigins = ['localhost', /^\//];

@kamilogorekkamilogorekMay 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never use it. I'd also allow for 0 length arrays, so just !Array.isArray will be now enough.

@HazATHazATMay 8, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups 🙈

@HazAT
HazAT merged commit af092e3 into masterMay 8, 2019
@HazAT
HazAT deleted the feat/tracing branch May 8, 2019 13:06
@BessonovBessonov mentioned this pull request Sep 26, 2019
Closed
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kamilogorekkamilogorekkamilogorek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HazATHazAT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HazAT@getsentry-bot@kamilogorek