Uh oh!
There was an error while loading. Please reload this page.
test(node): Use docker-compose healthchecks for service readiness - #20429
Merged
Conversation
Replace the stdout-scraping readyMatches approach in the node-integration-tests runner with Docker's native healthchecks + `docker compose up -d --wait`. The old approach matched log substrings like `'port 5432'` or `'port: 3306'`, which fire when the socket is bound but not when the server is actually accepting queries — producing intermittent CI flakes (e.g. #20418, #20335) under load. Each docker-compose.yml now defines a proper healthcheck (pg_isready, mysqladmin ping, redis-cli ping, rabbitmq-diagnostics, etc.), and the runner blocks on `--wait` until every service reports healthy. On failure, the runner surfaces `docker compose logs` for easier debugging. Also renames the redis-cache container to avoid collision with redis. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
nicohrubec
marked this pull request as ready for review
April 22, 2026 08:03
mydea
approved these changes
Apr 22, 2026
mydea
left a comment
Member
There was a problem hiding this comment.
nice! can we document this somewhere what to do if another docker compose is added somewhere (e.g. that healthcheck is required for this)?
nicohrubec
commented
Apr 22, 2026
MemberAuthor
@mydea Yes good call. I added a bugbot rule that should flag if the health check is missing somewhere! |
Uh oh!
There was an error while loading. Please reload this page.
46 tasks
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the stdout
readyMatchesapproach in the node-integration-tests runner with Docker native healthchecks +docker compose up -d --wait. The old approach matched log substrings like'port 5432', which can fire too early when the server is not actually yet accepting connections resulting in flakes. Eachdocker-compose.ymlnow defines a proper healthcheck (e.g. pg_isready) and the runner blocks on--waituntil every service reports healthy.Also renames the redis-cache container to avoid collision with redis.
Closes#20418
Closes#20335