fix(node): Guard against null `httpVersion` in outgoing request span attributes by logaretm · Pull Request #20430 · getsentry/sentry-javascript

logaretm · 2026-04-21T19:45:19Z

It appears that httpVersion can be undefined in some cases, and even tho the node types don't suggest that we do seem to treat it as such in other parts of the code so I assume we have run into this before.

This PR guards against this specific usage here as this is the only place where it wasn't guarded.

Fixes#20415

…attributes On Node 22+ with Next.js 15, the bundled `@mswjs/interceptors` emits a synthetic `response` event on request timeout/abort whose `IncomingMessage` has `httpVersion === null`. `_getOutgoingRequestEndedSpanData` called `httpVersion.toUpperCase()` unguarded, which crashed the process with an unhandled rejection. The sibling server-side code in `httpServerSpansIntegration` already optional-chains this attribute; this brings the client path in line. Fixes#20415 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

linear-code · 2026-04-21T19:45:23Z

JS-2236 TypeError: Cannot read properties of null (reading 'toUpperCase') in server HTTP instrumentation when outgoing request times out (Next.js 15, Node 22)

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4d64142. Configure here.}

Copilot

Pull request overview

Guards Node outgoing HTTP span attribute generation against httpVersion === null to prevent crashes on synthetic response events (e.g., Node 22 + Next.js 15 + bundled @mswjs/interceptors), aligning behavior with the existing server-side HTTP spans integration.

Changes:

Update outgoing response span attribute construction to optional-chain httpVersion?.toUpperCase() when computing net.transport.
Add inline comment referencing prior similar handling and the reported issue.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…tion.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-04-21T19:59:49Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	25.88 kB	-	-
@sentry/browser - with treeshaking flags	24.35 kB	-	-
@sentry/browser (incl. Tracing)	43.81 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	45.5 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	48.73 kB	-	-
@sentry/browser (incl. Tracing, Replay)	82.98 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	72.5 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	87.67 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	99.93 kB	-	-
@sentry/browser (incl. Feedback)	42.7 kB	-	-
@sentry/browser (incl. sendFeedback)	30.55 kB	-	-
@sentry/browser (incl. FeedbackAsync)	35.55 kB	-	-
@sentry/browser (incl. Metrics)	27.16 kB	-	-
@sentry/browser (incl. Logs)	27.29 kB	-	-
@sentry/browser (incl. Metrics & Logs)	27.98 kB	-	-
@sentry/react	27.62 kB	-	-
@sentry/react (incl. Tracing)	46.05 kB	-	-
@sentry/vue	30.71 kB	-	-
@sentry/vue (incl. Tracing)	45.62 kB	-	-
@sentry/svelte	25.89 kB	-	-
CDN Bundle	28.57 kB	-	-
CDN Bundle (incl. Tracing)	46.08 kB	-	-
CDN Bundle (incl. Logs, Metrics)	29.95 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	47.12 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	68.92 kB	-	-
CDN Bundle (incl. Tracing, Replay)	83.14 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	84.17 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	88.61 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	89.69 kB	-	-
CDN Bundle - uncompressed	83.59 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	137.62 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	87.73 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	141.03 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	211.31 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	255.06 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	258.46 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	267.97 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	271.36 kB	-	-
@sentry/nextjs (client)	48.58 kB	-	-
@sentry/sveltekit (client)	44.22 kB	-	-
@sentry/node-core	58.35 kB	+0.02%	+8 B 🔺
@sentry/node	175.66 kB	+0.01%	+12 B 🔺
@sentry/node - without tracing	98.3 kB	+0.02%	+11 B 🔺
@sentry/aws-serverless	115.33 kB	+0.01%	+11 B 🔺

View base workflow run

nicohrubec

Maybe we should cover this with a small unit test? Other than that lgtm :)

…` null httpVersion guard Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

logaretm · 2026-04-22T12:50:53Z

@nicohrubec I forgot to push them, thanks! I added a few more tests now.

RipperZA · 2026-04-23T09:03:36Z

It appears that httpVersion can be undefined in some cases, and even tho the node types don't suggest that we do seem to treat it as such in other parts of the code so I assume we have run into this before.
This PR guards against this specific usage here as this is the only place where it wasn't guarded.
Fixes #20415

Amazing, thanks for this quick and speedy fix! I tested this commit and it fixed the issue! Much appreciated 🚀

CopilotAI review requested due to automatic review settings April 21, 2026 19:45

Copilotstarted reviewing on behalf of logaretm April 21, 2026 19:45 View session

cursorBot reviewed Apr 21, 2026
View reviewed changes

Comment threadpackages/node-core/src/integrations/http/SentryHttpInstrumentation.ts

CopilotAI reviewed Apr 21, 2026
View reviewed changes

Comment threadpackages/node-core/src/integrations/http/SentryHttpInstrumentation.ts Outdated
Comment threadpackages/node-core/src/integrations/http/SentryHttpInstrumentation.ts Outdated

Update packages/node-core/src/integrations/http/SentryHttpInstrumenta…
1dc6e72
…tion.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

logaretm requested review from andreiborza and nicohrubec April 21, 2026 20:25

nicohrubec approved these changes Apr 22, 2026
View reviewed changes

test(node-core): Add unit tests for `_getOutgoingRequestEndedSpanData…
bf64097
…` null httpVersion guard Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

logaretm merged commit 4b4ac76 into developApr 22, 2026
712 of 723 checks passed

logaretm deleted the awad/js-2236-typeerror-cannot-read-properties-of-null-reading-touppercase branch April 22, 2026 20:02

sentry-release-botBot mentioned this pull request Apr 23, 2026
publish: getsentry/sentry-javascript@10.50.0 getsentry/publish#7921
Closed
46 tasks

github-actionsBot mentioned this pull request Apr 23, 2026
TypeError: Cannot read properties of null (reading 'toUpperCase') in server HTTP instrumentation when outgoing request times out (Next.js 15, Node 22) #20415
Closed

Navigation Menu

Uh oh!

Uh oh!

fix(node): Guard against null `httpVersion` in outgoing request span attributes - #20430

fix(node): Guard against null `httpVersion` in outgoing request span attributes#20430
logaretm merged 3 commits into
developfrom
awad/js-2236-typeerror-cannot-read-properties-of-null-reading-touppercase

logaretm commented Apr 21, 2026•
edited
Loading

Uh oh!

linear-codeBot commented Apr 21, 2026

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Apr 21, 2026•
edited
Loading

Uh oh!

nicohrubec left a comment

Uh oh!

logaretm commented Apr 22, 2026

Uh oh!

Uh oh!

RipperZA commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

logaretm commented Apr 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-codeBot commented Apr 21, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Apr 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

nicohrubec left a comment

Choose a reason for hiding this comment

Uh oh!

logaretm commented Apr 22, 2026

Uh oh!

Uh oh!

RipperZA commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

logaretm commented Apr 21, 2026•
edited
Loading

github-actionsBot commented Apr 21, 2026•
edited
Loading