Uh oh!
There was an error while loading. Please reload this page.
test(aws-serverless): Split npm & layer tests - #20442
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
mydeaforce-pushed
the
fn/split-aws-serverless-test
branch
from
April 22, 2026 10:09
6779954 to
039637fComparemydea
marked this pull request as ready for review
April 22, 2026 10:10
Uh oh!
There was an error while loading. Please reload this page.
nicohrubec
approved these changes
Apr 23, 2026
| } | ||
| function resolvePackagesDir(): string { | ||
| // When running via the e2e test runner, tests are copied to a temp directory |
Member
There was a problem hiding this comment.
l: are these comments no longer relevant?
MemberAuthor
There was a problem hiding this comment.
hmm probably still fine, you're right!
mydeaforce-pushed
the
fn/split-aws-serverless-test
branch
from
April 23, 2026 07:35
039637f to
e7ad362Comparemydea
enabled auto-merge (squash)
April 23, 2026 07:35
Uh oh!
There was an error while loading. Please reload this page.
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #20441
This PR splits the aws-serverless test app into two, aws-serverless, which tests the npm package directly, and aws-serverless-layer, which tests using the layer.
This allowed to make the test app easier to understand and follow and make the dependency graph clearer as well.
I choose to run the layer in different node versions and the npm stuff only in node 20, IMHO that should be good enough, I don't think we need to also run the npm stuff in all the node versions, so we can reduce the number of test apps a bit.