Skip to content

test(hono): Add E2E tests for middleware spans - #20451

Merged
s1gr1d merged 4 commits into
developfrom
sig/hono-middleware-e2e
Apr 22, 2026
Merged

test(hono): Add E2E tests for middleware spans#20451
s1gr1d merged 4 commits into
developfrom
sig/hono-middleware-e2e

Conversation

@s1gr1d

Copy link
Copy Markdown
Member

Adds tests for middleware spans. However, sub-app middlwares are not yet supported. Created an issue for that: #20449

Reference: #15260

@s1gr1d
s1gr1d requested review from JPeer264 and chargomeApril 22, 2026 12:58
@github-actions

github-actionsBot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser25.88 kB--
@sentry/browser - with treeshaking flags24.35 kB--
@sentry/browser (incl. Tracing)43.81 kB--
@sentry/browser (incl. Tracing + Span Streaming)45.5 kB--
@sentry/browser (incl. Tracing, Profiling)48.73 kB--
@sentry/browser (incl. Tracing, Replay)82.98 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags72.5 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)87.67 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)99.93 kB--
@sentry/browser (incl. Feedback)42.7 kB--
@sentry/browser (incl. sendFeedback)30.55 kB--
@sentry/browser (incl. FeedbackAsync)35.55 kB--
@sentry/browser (incl. Metrics)27.16 kB--
@sentry/browser (incl. Logs)27.29 kB--
@sentry/browser (incl. Metrics & Logs)27.98 kB--
@sentry/react27.62 kB--
@sentry/react (incl. Tracing)46.05 kB--
@sentry/vue30.71 kB--
@sentry/vue (incl. Tracing)45.62 kB--
@sentry/svelte25.89 kB--
CDN Bundle28.57 kB--
CDN Bundle (incl. Tracing)46.08 kB--
CDN Bundle (incl. Logs, Metrics)29.95 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)47.12 kB--
CDN Bundle (incl. Replay, Logs, Metrics)68.92 kB--
CDN Bundle (incl. Tracing, Replay)83.14 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)84.17 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)88.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)89.69 kB--
CDN Bundle - uncompressed83.59 kB--
CDN Bundle (incl. Tracing) - uncompressed137.62 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed87.73 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed141.03 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed211.31 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed255.06 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed258.46 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed267.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed271.36 kB--
@sentry/nextjs (client)48.58 kB--
@sentry/sveltekit (client)44.22 kB--
@sentry/node-core58.35 kB+0.02%+8 B 🔺
@sentry/node175.66 kB+0.01%+14 B 🔺
@sentry/node - without tracing98.3 kB+0.02%+10 B 🔺
@sentry/aws-serverless115.33 kB+0.01%+10 B 🔺

View base workflow run

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d6cc81b. Configure here.

Comment threaddev-packages/e2e-tests/test-applications/hono-4/tests/middleware.test.ts Outdated
@s1gr1d

Copy link
Copy Markdown
MemberAuthor

Converting to draft to still fix some issues before reviewing

@s1gr1d
s1gr1d marked this pull request as draft April 22, 2026 13:23

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@s1gr1d
s1gr1d marked this pull request as ready for review April 22, 2026 13:49
@s1gr1d
s1gr1d enabled auto-merge (squash) April 22, 2026 13:49
@s1gr1d
s1gr1d merged commit a4c9686 into developApr 22, 2026
43 checks passed
@s1gr1d
s1gr1d deleted the sig/hono-middleware-e2e branch April 22, 2026 15:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@s1gr1d@chargome