Uh oh!
There was an error while loading. Please reload this page.
fix(browser): Add ingest_settings to v2 log envelope payload - #20453
Merged
Conversation
ingest_settings to log envelope payloadingest_settings to v2 log envelope payloadContributor
size-limit report 📦
|
chargome
approved these changes
Apr 29, 2026
nicohrubec
marked this pull request as ready for review
April 30, 2026 12:40
logaretm
approved these changes
Apr 30, 2026
| * | ||
| * @param items - The logs to include in the envelope. | ||
| * @param inferUserData - If true, tells Relay to infer the end-user IP and User-Agent from the incoming request. | ||
| * Only emitted as `ingest_settings` in browser environments. |
Member
There was a problem hiding this comment.
nit: extra leading spaces, intended?
ingest_settings to v2 log envelope payloadingest_settings to v2 log envelope payloadCo-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
olveryu added a commit
to olveryu/WerewolfGameJudge
that referenced
this pull request
May 6, 2026
Replace hand-rolled UA regex with ua-parser-js (v2), which correctly identifies all browsers including WKWebView, MicroMessenger, Android WebView, etc. Temporary workaround for getsentry/sentry-javascript#20453.
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
version: 2andingest_settingsto the log envelope payload so Relay can infer the end-user IP address and User-Agent from the incoming request (link to spec). This is only emitted by the browser SDK.Both settings are currently gated behind
sendDefaultPii(modeled after howevent.sdk.settings.infer_ip).This slightly changes behavior in this case because we were always inferring some user data on logs before (e.g.
browser.name/version). This data will not be there anymore after this change, unlesssendDefaultPiiis enabled.Closes#20277