Uh oh!
There was an error while loading. Please reload this page.
ref(browser): Use safeSetSpanJSONAttributes in cultureContext integration - #20481
Merged
Merged
Conversation
safeSetSpanJSONAttributes in cultureContext integrationnicohrubecforce-pushed
the
nh/span-streaming-culturecontextintegration
branch
from
April 24, 2026 07:16
c3e0e66 to
ea0b3faCompareContributor
size-limit report 📦
|
nicohrubec
marked this pull request as ready for review
April 24, 2026 07:55
nicohrubecforce-pushed
the
nh/span-streaming-culturecontextintegration
branch
from
April 24, 2026 08:01
ea0b3fa to
fd66a7dComparenicohrubec
changed the base branch from
nh/span-streaming-httpcontextintegration
to
developApril 24, 2026 08:25
…tion Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nicohrubecforce-pushed
the
nh/span-streaming-culturecontextintegration
branch
from
April 24, 2026 08:31
fd66a7d to
3f9c2eeComparemydea
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the same
safeSetSpanJSONAttributesrefactor from #20464 to thecultureContextintegration'sprocessSegmentSpanhook. This gives us in-place mutation instead of spread-and-reassign and nullish values are skipped (these get dropped during serialization anyways but doesn't hurt to just not assign them in the first place).