Uh oh!
There was an error while loading. Please reload this page.
fix(opentelemetry): Respect OTEL_SERVICE_NAME, OTEL_RESOURCE_ATTRIBUTES - #20509
Merged
isaacs merged 1 commit intoMay 4, 2026
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
isaacsforce-pushed
the
isaacschlueter/js-2280-respect-otel_service_name-and-otel_resource_attributes
branch
from
April 26, 2026 23:02
65f6897 to
d056014Comparemydea
approved these changes
Apr 27, 2026
isaacsforce-pushed
the
isaacschlueter/js-2280-respect-otel_service_name-and-otel_resource_attributes
branch
from
April 30, 2026 00:06
d056014 to
bdf3bbaCompareisaacs added a commit
that referenced
this pull request
Apr 30, 2026
…ES (#20509) This uses the string passed into `getSentryResource` as a fallback, preferring instead to use the value in `env.OTEL_SERVICE_NAME` if set, or the `service.name` field in the comma-delimited key=value pairs in `env.OTEL_RESOURCE_ATTRIBUTES` pairs. Additional `env.OTEL_RESOURCE_ATTRIBUTES` are also attached to the resource attributes. fix: js-2280 fix: #20502
isaacsforce-pushed
the
isaacschlueter/js-2280-respect-otel_service_name-and-otel_resource_attributes
branch
from
April 30, 2026 00:46
bdf3bba to
f572279Compareisaacs
enabled auto-merge (rebase)
April 30, 2026 00:47
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f572279. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
isaacs added a commit
that referenced
this pull request
Apr 30, 2026
…ES (#20509) This uses the string passed into `getSentryResource` as a fallback, preferring instead to use the value in `env.OTEL_SERVICE_NAME` if set, or the `service.name` field in the comma-delimited key=value pairs in `env.OTEL_RESOURCE_ATTRIBUTES` pairs. Additional `env.OTEL_RESOURCE_ATTRIBUTES` are also attached to the resource attributes. fix: js-2280 fix: #20502
isaacsforce-pushed
the
isaacschlueter/js-2280-respect-otel_service_name-and-otel_resource_attributes
branch
from
April 30, 2026 18:57
f572279 to
ff8d125Compareisaacs added a commit
that referenced
this pull request
Apr 30, 2026
…ES (#20509) This uses the string passed into `getSentryResource` as a fallback, preferring instead to use the value in `env.OTEL_SERVICE_NAME` if set, or the `service.name` field in the comma-delimited key=value pairs in `env.OTEL_RESOURCE_ATTRIBUTES` pairs. Additional `env.OTEL_RESOURCE_ATTRIBUTES` are also attached to the resource attributes. fix: js-2280 fix: #20502
isaacsforce-pushed
the
isaacschlueter/js-2280-respect-otel_service_name-and-otel_resource_attributes
branch
from
April 30, 2026 19:13
ff8d125 to
f1dac69Compare…ES (#20509) This uses the string passed into `getSentryResource` as a fallback, preferring instead to use the value in `env.OTEL_SERVICE_NAME` if set, or the `service.name` field in the comma-delimited key=value pairs in `env.OTEL_RESOURCE_ATTRIBUTES` pairs. Additional `env.OTEL_RESOURCE_ATTRIBUTES` are also attached to the resource attributes. fix: js-2280 fix: #20502
JPeer264force-pushed
the
isaacschlueter/js-2280-respect-otel_service_name-and-otel_resource_attributes
branch
from
May 4, 2026 12:06
f1dac69 to
783bc85CompareJPeer264
approved these changes
May 4, 2026
| beforeEach(() => { | ||
| // Clone env so mutations are isolated | ||
| process.env = { ...originalEnv }; |
Member
There was a problem hiding this comment.
FWIW vi.stubEnv works pretty nicely as well and with that we wouldn't need to store the original env
Uh oh!
There was an error while loading. Please reload this page.
isaacs
deleted the
isaacschlueter/js-2280-respect-otel_service_name-and-otel_resource_attributes
branch
May 4, 2026 12:23
47 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the string passed into
getSentryResourceas a fallback, preferring instead to use the value inenv.OTEL_SERVICE_NAMEif set, or theservice.namefield in the comma-delimited key=value pairs inenv.OTEL_RESOURCE_ATTRIBUTESpairs.Additional
env.OTEL_RESOURCE_ATTRIBUTESare also attached to the resource attributes.fix: js-2280
fix: #20502
yarn lint) & (yarn test).Closes#20502