feat(node): vendor ioredis, redis instrumentations by isaacs · Pull Request #20510 · getsentry/sentry-javascript

isaacs · 2026-04-25T01:18:33Z

Vendor in the Redis and IORedis instrumentation code and unit tests, and update everything in Sentry to use our vendored code instead of the external dependency.

A subsequent commit will update the node-redis instrumentation to use its recently-added Diagnostics Channel support.

See: https://github.com/redis/node-redis/blob/master/docs/diagnostics-channel.md

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #issue_link_here

github-actions · 2026-04-25T01:32:24Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	26.31 kB	-	-
@sentry/browser - with treeshaking flags	24.8 kB	-	-
@sentry/browser (incl. Tracing)	44.2 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	46.42 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	49.16 kB	-	-
@sentry/browser (incl. Tracing, Replay)	83.58 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	73.04 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	88.26 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	100.87 kB	-	-
@sentry/browser (incl. Feedback)	43.47 kB	-	-
@sentry/browser (incl. sendFeedback)	31.12 kB	-	-
@sentry/browser (incl. FeedbackAsync)	36.21 kB	-	-
@sentry/browser (incl. Metrics)	27.62 kB	-	-
@sentry/browser (incl. Logs)	27.75 kB	-	-
@sentry/browser (incl. Metrics & Logs)	28.45 kB	-	-
@sentry/react	28.05 kB	-	-
@sentry/react (incl. Tracing)	46.42 kB	-	-
@sentry/vue	31.18 kB	-	-
@sentry/vue (incl. Tracing)	46.04 kB	-	-
@sentry/svelte	26.34 kB	-	-
CDN Bundle	28.91 kB	-	-
CDN Bundle (incl. Tracing)	46.95 kB	-	-
CDN Bundle (incl. Logs, Metrics)	30.34 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	48.06 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	69.41 kB	-	-
CDN Bundle (incl. Tracing, Replay)	84.11 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	85.16 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	89.91 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	91.01 kB	-	-
CDN Bundle - uncompressed	84.72 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	140.31 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	88.92 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	143.77 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	212.86 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	258.11 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	261.56 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	271.81 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	275.25 kB	-	-
@sentry/nextjs (client)	48.92 kB	-	-
@sentry/sveltekit (client)	44.67 kB	-	-
@sentry/node-core	59.13 kB	+0.02%	+10 B 🔺
@sentry/node	170.63 kB	+0.05%	+74 B 🔺
@sentry/node - without tracing	97.17 kB	+0.01%	+7 B 🔺
@sentry/aws-serverless	113.99 kB	+0.03%	+31 B 🔺
@sentry/cloudflare (withSentry) - minified	165.2 kB	-	-
@sentry/cloudflare (withSentry)	417.71 kB	-	-

View base workflow run

Vendor in the Redis and IORedis instrumentation code and unit tests, and update everything in Sentry to use our vendored code instead of the external dependency. A subsequent commit will update the node-redis instrumentation to use its recently-added Diagnostics Channel support. See: https://github.com/redis/node-redis/blob/master/docs/diagnostics-channel.md

logaretm · 2026-04-28T19:18:35Z

@isaacs I can follow up on this PR once it gets merged to see if we can use the tracing channels shipped in 5.12.0

Vendor in the Redis and IORedis instrumentation code and unit tests, and update everything in Sentry to use our vendored code instead of the external dependency. A subsequent commit will update the node-redis instrumentation to use its recently-added Diagnostics Channel support. See: https://github.com/redis/node-redis/blob/master/docs/diagnostics-channel.md

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d150996. Configure here.}

Vendor in the Redis and IORedis instrumentation code and unit tests, and update everything in Sentry to use our vendored code instead of the external dependency. A subsequent commit will update the node-redis instrumentation to use its recently-added Diagnostics Channel support. See: https://github.com/redis/node-redis/blob/master/docs/diagnostics-channel.md

Builds on #20510 and adds tracing channels subscribers via `node:diagnostics_channel`. The module patchers are narrowed to `>=5.0.0 <5.12.0` while the subscriber path runs unconditionally. it will be inert in older releases anyways and will activate when version 5.12 publishes the events. Verified that it works on Node and Bun equally as well, while IITM fails on Bun. --------- Co-authored-by: isaacs <i@izs.me>

isaacs force-pushed the isaacs/vendor-redis branch from 345c2eb to 2cc6c16Compare April 26, 2026 23:10

isaacs marked this pull request as ready for review April 26, 2026 23:11

isaacs force-pushed the isaacs/vendor-redis branch from 2cc6c16 to f7f5d5eCompare April 26, 2026 23:12

isaacs changed the title ~~feat(node): vendor ioredis, redis instrumentaitons~~feat(node): vendor ioredis, redis instrumentationsApr 26, 2026

sentryBot reviewed Apr 26, 2026
View reviewed changes

Comment threadpackages/node/src/integrations/tracing/redis/index.ts

mydea approved these changes Apr 27, 2026
View reviewed changes

logaretm mentioned this pull request Apr 28, 2026
feat(node): use diagnostics_channel for redis >= 5.12.0 #20573
Merged

isaacs force-pushed the isaacs/vendor-redis branch from f7f5d5e to 9384287Compare May 4, 2026 18:37

isaacs requested a review from a team as a code owner May 4, 2026 18:37

sentryBot reviewed May 4, 2026
View reviewed changes

Comment threadpackages/node/src/integrations/tracing/redis/vendored/redis-instrumentation.ts

sentryBot reviewed May 4, 2026
View reviewed changes

Comment threadpackages/node/src/integrations/tracing/redis/vendored/redis-instrumentation.ts

cursorBot reviewed May 4, 2026
View reviewed changes

Comment threadpackages/node/src/integrations/tracing/redis/index.ts Outdated

isaacs force-pushed the isaacs/vendor-redis branch from 461184f to d150996Compare May 4, 2026 18:53

isaacs enabled auto-merge (rebase) May 4, 2026 18:54

sentryBot reviewed May 4, 2026
View reviewed changes

Comment threadpackages/node/src/integrations/tracing/redis/vendored/ioredis-instrumentation.ts
Comment threadpackages/node/src/integrations/tracing/redis/vendored/ioredis-instrumentation.ts

isaacs disabled auto-merge May 4, 2026 19:01

cursorBot reviewed May 4, 2026
View reviewed changes

Comment threadpackages/node/test/integrations/tracing/redis/redis-common.test.ts Outdated

isaacs added 2 commits May 4, 2026 12:17

fix(redis): handle case when socket data is not available
de731ed

isaacs force-pushed the isaacs/vendor-redis branch from d150996 to de731edCompare May 4, 2026 19:17

isaacs merged commit 7adeb9d into developMay 4, 2026
501 of 503 checks passed

isaacs deleted the isaacs/vendor-redis branch May 4, 2026 19:58

sentry-release-botBot mentioned this pull request May 7, 2026
publish: getsentry/sentry-javascript@10.52.0 getsentry/publish#8115
Closed
47 tasks

This was referenced May 15, 2026
Vendor @opentelemetry/instrumentation-ioredis#20152
Closed
Vendor @opentelemetry/instrumentation-redis#20161
Closed

Navigation Menu

Uh oh!

Uh oh!

feat(node): vendor ioredis, redis instrumentations - #20510

feat(node): vendor ioredis, redis instrumentations#20510
isaacs merged 2 commits into
developfrom
isaacs/vendor-redis

isaacs commented Apr 25, 2026

Uh oh!

github-actionsBot commented Apr 25, 2026•
edited
Loading

Uh oh!

Uh oh!

logaretm commented Apr 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

isaacs commented Apr 25, 2026

Uh oh!

github-actionsBot commented Apr 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

logaretm commented Apr 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actionsBot commented Apr 25, 2026•
edited
Loading