Skip to content

feat(aws-serverless): Validate extension tunnel DSN against SENTRY_DSN - #20528

Merged
mydea merged 4 commits into
developfrom
fn/lambda-extension-validate-dsn
Apr 29, 2026
Merged

feat(aws-serverless): Validate extension tunnel DSN against SENTRY_DSN#20528
mydea merged 4 commits into
developfrom
fn/lambda-extension-validate-dsn

Conversation

@mydea

Copy link
Copy Markdown
Member

If this is set (which should generally be the case when using the layer), we want to only allow this DSN to be forwarded.

If not set, it does not validate but warn that this is not validated.

@mydea
mydea requested a review from andreiborzaApril 27, 2026 13:56
@mydeamydea self-assigned this Apr 27, 2026

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f3885dd. Configure here.

Comment threadpackages/aws-serverless/test/aws-lambda-extension.test.ts
Comment threadpackages/aws-serverless/test/aws-lambda-extension.test.ts
mydea added 3 commits April 28, 2026 13:27
If this is set (which should generally be the case when using the layer), we want to only allow this DSN to be forwarded.
@mydea
mydeaforce-pushed the fn/lambda-extension-validate-dsn branch from b0b0022 to 33bba82CompareApril 28, 2026 11:27
Comment threadpackages/aws-serverless/src/lambda-extension/aws-lambda-extension.ts Outdated
Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com>
@mydea
mydea enabled auto-merge (squash) April 29, 2026 08:27
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser26.16 kB--
@sentry/browser - with treeshaking flags24.63 kB--
@sentry/browser (incl. Tracing)44.11 kB--
@sentry/browser (incl. Tracing + Span Streaming)46.16 kB--
@sentry/browser (incl. Tracing, Profiling)49.06 kB--
@sentry/browser (incl. Tracing, Replay)83.46 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags72.94 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)88.14 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)100.79 kB--
@sentry/browser (incl. Feedback)43.4 kB--
@sentry/browser (incl. sendFeedback)30.96 kB--
@sentry/browser (incl. FeedbackAsync)36.14 kB--
@sentry/browser (incl. Metrics)27.44 kB--
@sentry/browser (incl. Logs)27.59 kB--
@sentry/browser (incl. Metrics & Logs)28.28 kB--
@sentry/react27.9 kB--
@sentry/react (incl. Tracing)46.35 kB--
@sentry/vue31.03 kB--
@sentry/vue (incl. Tracing)45.95 kB--
@sentry/svelte26.18 kB--
CDN Bundle28.84 kB--
CDN Bundle (incl. Tracing)46.71 kB--
CDN Bundle (incl. Logs, Metrics)30.25 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)47.8 kB--
CDN Bundle (incl. Replay, Logs, Metrics)69.34 kB--
CDN Bundle (incl. Tracing, Replay)83.88 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)84.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)89.69 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)90.78 kB--
CDN Bundle - uncompressed84.55 kB--
CDN Bundle (incl. Tracing) - uncompressed139.68 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed88.75 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed143.14 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed212.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed257.49 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed260.93 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed271.18 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed274.62 kB--
@sentry/nextjs (client)48.84 kB--
@sentry/sveltekit (client)44.56 kB--
@sentry/node-core58.96 kB+0.02%+8 B 🔺
@sentry/node169.27 kB+0.01%+7 B 🔺
@sentry/node - without tracing96.82 kB+0.01%+8 B 🔺
@sentry/aws-serverless113.69 kB+0.03%+33 B 🔺
@sentry/cloudflare (withSentry) - minified164.13 kB--
@sentry/cloudflare (withSentry)415.2 kB--

View base workflow run

@mydea
mydea merged commit 971aade into developApr 29, 2026
255 of 256 checks passed
@mydea
mydea deleted the fn/lambda-extension-validate-dsn branch April 29, 2026 08:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@andreiborza