Uh oh!
There was an error while loading. Please reload this page.
fix(opentelemetry): Add conditional browser export to avoid node deps - #20556
Merged
Conversation
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Apr 28, 2026
mydea
marked this pull request as ready for review
April 28, 2026 12:01
isaacs
self-requested a review
April 28, 2026 15:01
isaacs
reviewed
Apr 28, 2026
isaacs
left a comment
Member
There was a problem hiding this comment.
LGTM! Minor possible safety improvement suggestion, but mostly theoretical.
| "types": "./build/types/index.d.ts", | ||
| "default": "./build/esm/index.js" | ||
| }, | ||
| "browser": { |
Member
There was a problem hiding this comment.
Since we're specifying browser here, it might be safer to put it above node, just to ensure that anything that claims to support this (even if it does so with weird shims etc) can pick up the browser one first.
MemberAuthor
There was a problem hiding this comment.
I wasn't 100% sure about this (and still am not 🤔 ) my thinking for this was that node is def. the main target here, and I want to avoid somebody who has a node target not getting this. IMHO that's more important than somebody who has node & browser targets not getting the node stuff - I'd say it's reasonable that if your targets include node, you get the variant with the node import 😅 but we can always revisit the order if this turns out to be problematic!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We accidentally added a
nodedependency to an export fromopentelemetrypackage, leading to problems for users using this in a browser environment.This PR adds conditional exports to the opentelemetry package, where for
browsertargets we have stubs for the node-only thing. This should generally work the same as before, but stop failing builds in browser envs.I had to adjust browser integration tests for this a bit, as they did some unnecessary aliasing which prevented webpack from using normal conditional exports. We are simply doing less now and doing regular dependency resolution which should work as expected (hopefully).