Uh oh!
There was an error while loading. Please reload this page.
test(node): Fix flaky worker thread integration test - #20588
Merged
Conversation
JPeer264
approved these changes
Apr 29, 2026
| const threadValues = event.threads?.values ?? []; | ||
| expect(threadValues).toHaveLength(2); | ||
| // Any order is fine, we just check that both are present | ||
| expect(threadValues).toContainEqual( |
Member
There was a problem hiding this comment.
q: Is there a specific reason why this one got outsourced into its own expect? expect.objectContaining would have worked above as well if I'm not mistaken
MemberAuthor
There was a problem hiding this comment.
I personally don't like how these nested contains things are visualized when they fail - I always have a hard time finding out what is actually not matching. I find this easier to parse when it fails, but this is more a personal preference :D functionally that also worked fine, yes!
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#20571