Uh oh!
There was an error while loading. Please reload this page.
test(node): Unflake postgres tests - #20593
Merged
Merged
Conversation
Closes#20553 The clanker identified this as possible problem here: > docker compose up --wait waits on the container healthcheck (pg_isready inside the DB). On busy CI, localhost:5444 can still refuse connections briefly afterward, so the scenario could hit Postgres before it was reachable from the host and fail or behave inconsistently → flaky CJS (and the same class of failure for the other scenarios).
nicohrubec
approved these changes
Apr 29, 2026
Contributor
size-limit report 📦
|
JPeer264
approved these changes
Apr 29, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Should we then remove the health check again?
mydea
commented
Apr 29, 2026
MemberAuthor
I think it is generally fine, we can have both of these? not even 100% sure if this here will fix this, but worth a try I suppose... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#20553
The clanker identified this as possible problem here: