Uh oh!
There was an error while loading. Please reload this page.
feat(browser): Migrate spotlight event processor to ignoreSpans - #20595
Merged
Conversation
Contributor
size-limit report 📦
|
ignoreSpansignoreSpanschargome
marked this pull request as ready for review
April 29, 2026 13:20
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8015ae2. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
| export const INTEGRATION_NAME = 'SpotlightBrowser'; | ||
| export const SPOTLIGHT_IGNORE_SPANS = [{ op: 'ui.interaction.click', name: '#sentry-spotlight' }]; |
Member
There was a problem hiding this comment.
h: Before we dropped the whole transaction if any of these spans were detected, this behaves differently now since this will only match non-segment spans as far as I understand. Should we try to detect the segment span instead (so that then the whole segment gets dropped if it matches)?
MemberAuthor
There was a problem hiding this comment.
A tradeoff yes, there's no ignoreSpans pattern that can match the segment span to drop the whole thing
Filtering entire segments based on data that is unknown prior to segment start.
nicohrubec
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some integration tests too, might be an overkill but they are quite simple.
closes#20363