Skip to content

chore(browser): Remove debug config from tests - #20600

Merged
mydea merged 1 commit into
developfrom
fn/avoid-browser-debug-tests
Apr 29, 2026
Merged

chore(browser): Remove debug config from tests#20600
mydea merged 1 commit into
developfrom
fn/avoid-browser-debug-tests

Conversation

@mydea

Copy link
Copy Markdown
Member

This lead to hard to read logs, as this enables the debugger which leaks into other tests as well etc.

This lead to hard to read logs, as this enables the debugger which leaks into other tests as well etc.
@mydeamydea self-assigned this Apr 29, 2026
@mydea
mydea requested a review from a team as a code ownerApril 29, 2026 12:23

Sentry.init({
...getBaseOptionsForTraceLifecycle(send),
debug: true,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best would be that debug would be enabled when we rerun the CI with the debug options enabled. But there is no documentation anywhere if a env variable is set when this is activated.

Image

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

PathSize% ChangeChange
@sentry/browser26.16 kB--
@sentry/browser - with treeshaking flags24.63 kB--
@sentry/browser (incl. Tracing)44.11 kB--
@sentry/browser (incl. Tracing + Span Streaming)46.16 kB--
@sentry/browser (incl. Tracing, Profiling)49.06 kB--
@sentry/browser (incl. Tracing, Replay)83.46 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags72.94 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)88.14 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)100.79 kB--
@sentry/browser (incl. Feedback)43.4 kB--
@sentry/browser (incl. sendFeedback)30.96 kB--
@sentry/browser (incl. FeedbackAsync)36.14 kB--
@sentry/browser (incl. Metrics)27.44 kB--
@sentry/browser (incl. Logs)27.59 kB--
@sentry/browser (incl. Metrics & Logs)28.28 kB--
@sentry/react27.9 kB--
@sentry/react (incl. Tracing)46.35 kB--
@sentry/vue31.03 kB--
@sentry/vue (incl. Tracing)45.95 kB--
@sentry/svelte26.18 kB--
CDN Bundle28.84 kB--
CDN Bundle (incl. Tracing)46.71 kB--
CDN Bundle (incl. Logs, Metrics)30.25 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)47.8 kB--
CDN Bundle (incl. Replay, Logs, Metrics)69.34 kB--
CDN Bundle (incl. Tracing, Replay)83.88 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)84.94 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)89.69 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)90.78 kB--
CDN Bundle - uncompressed84.55 kB--
CDN Bundle (incl. Tracing) - uncompressed139.68 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed88.75 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed143.14 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed212.71 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed257.49 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed260.93 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed271.18 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed274.62 kB--
@sentry/nextjs (client)48.84 kB--
@sentry/sveltekit (client)44.56 kB--
@sentry/node-core58.96 kB+0.02%+7 B 🔺
@sentry/node170.25 kB+0.01%+11 B 🔺
@sentry/node - without tracing96.82 kB+0.01%+8 B 🔺
@sentry/aws-serverless113.69 kB+0.03%+33 B 🔺
@sentry/cloudflare (withSentry) - minified164.13 kB--
@sentry/cloudflare (withSentry)415.2 kB--

View base workflow run

@logaretm

Copy link
Copy Markdown
Member

Don't think we need debug on the CI anyways, if a test fails we try to run it locally and from there we can debug.

@mydea
mydea merged commit 1bc267d into developApr 29, 2026
363 of 365 checks passed
@mydea
mydea deleted the fn/avoid-browser-debug-tests branch April 29, 2026 13:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@logaretm@JPeer264