Uh oh!
There was an error while loading. Please reload this page.
ref(tests): Rename streamed http.client span test folders - #20602
Merged
Conversation
nicohrubec
approved these changes
Apr 29, 2026
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
April 29, 2026 13:58
Uh oh!
There was an error while loading. Please reload this page.
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20420 — the
no-parent-span-client-report-streamedtest folders were originally testing client report outcomes, but that PR changed them to verify that http.client spans are emitted when streaming is enabled.Renames the folders to
http-client-span-streamedto reflect what the tests actually assert, removes unused imports left over from the old test, and updates the node test's describe block name.