Uh oh!
There was an error while loading. Please reload this page.
test(nextjs): Fix flaky node runtime metrics E2E tests - #20624
Merged
Conversation
Replace Playwright's `request.get()` with `fetch()` for the server warmup calls in the nextjs-16 runtime metrics tests. The equivalent tests in node-express-v5 use `fetch()` and don't flake, so we suspect the difference in request mechanism explains the socket hangups. Closes#20590Closes#20414Closes#20565Closes#20560 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
isaacs
self-requested a review
May 3, 2026 16:55
isaacs
approved these changes
May 3, 2026
isaacs
left a comment
Member
There was a problem hiding this comment.
At least in this run, it seems to have run without issue, so maybe it works? Ought to be equivalent anyway, so LGTM, if it's more reliable.
nicohrubec
marked this pull request as ready for review
May 4, 2026 06:53
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
Yeah just a hypothesis. I'll give it a try, if it happens again we can have another look. |
47 tasks
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
request.get()withfetch()for the server warmup calls in the nextjs-16 runtime metrics tests. All these flakes fail this initial request. The same runtime metrics tests also exists fornode-express-v5, which hasn't flaked so far. That one usesfetch()for this request so I suspect that this might explain the flakiness.Closes#20590
Closes#20414
Closes#20565
Closes#20560