Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Add span streaming test app for React Router 7 SPA - #20677
Merged
Conversation
Closes#20671 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Without it no pageload span is created, so spanStreamingIntegration has nothing to stream. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicohrubec
marked this pull request as ready for review
May 5, 2026 13:26
chargome
approved these changes
May 5, 2026
chargome
left a comment
Member
There was a problem hiding this comment.
LGTM but I think one of the react router (library) test apps would have more tests in here. At least a navigation test would be great IMO.
Switch to react-router-7-spa as the base app for React span streaming tests. This gives us pageload, navigation, and INP span tests instead of just error handling. Closes#20671 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicohrubec
commented
May 5, 2026
MemberAuthor
@chargome updated to use the |
…ames Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 201a7e0. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
…nvelopeItem The old filter item[0].type === 'span' would match streamed pageload spans first, causing the test to resolve with the wrong data. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
react-router-7-spa-streamingE2E test app that mirrorsreact-router-7-spawithspanStreamingIntegration()enabled. Converts thewaitForTransactiontests (pageload, navigation, transactionName) to usewaitForStreamedSpanand carries over the INP span and error tests.Closes#20671