feat(core): HTTP server diagnostics channel utility by isaacs · Pull Request #20779 · getsentry/sentry-javascript

isaacs · 2026-05-09T18:23:20Z

Portable connect integration logic de-OTel-ified and moved into core, for use in bun/deno. (Similar to previous Express integration migration.)
Add HTTP server-spans subscription utility to core.
Use this utility in node-core and node-core/light.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #issue_link_here

github-actions · 2026-05-09T18:34:14Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	26.89 kB	-	-
@sentry/browser - with treeshaking flags	25.33 kB	-	-
@sentry/browser (incl. Tracing)	44.79 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	46.8 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	49.78 kB	-	-
@sentry/browser (incl. Tracing, Replay)	84.43 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	73.86 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	89.13 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	101.77 kB	-	-
@sentry/browser (incl. Feedback)	44.08 kB	-	-
@sentry/browser (incl. sendFeedback)	31.7 kB	-	-
@sentry/browser (incl. FeedbackAsync)	36.81 kB	-	-
@sentry/browser (incl. Metrics)	27.98 kB	-	-
@sentry/browser (incl. Logs)	28.13 kB	-	-
@sentry/browser (incl. Metrics & Logs)	28.8 kB	-	-
@sentry/react	28.64 kB	-	-
@sentry/react (incl. Tracing)	47.06 kB	-	-
@sentry/vue	31.82 kB	-	-
@sentry/vue (incl. Tracing)	46.67 kB	-	-
@sentry/svelte	26.91 kB	-	-
CDN Bundle	29.28 kB	-	-
CDN Bundle (incl. Tracing)	47.2 kB	-	-
CDN Bundle (incl. Logs, Metrics)	30.65 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	48.34 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	69.98 kB	-	-
CDN Bundle (incl. Tracing, Replay)	84.6 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	85.66 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	90.41 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	91.5 kB	-	-
CDN Bundle - uncompressed	86.14 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	141.7 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	90.33 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	145.16 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	215.16 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	260.41 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	263.85 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	274.11 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	277.54 kB	-	-
@sentry/nextjs (client)	49.57 kB	-	-
@sentry/sveltekit (client)	45.28 kB	-	-
@sentry/node-core	61.97 kB	+1.8%	+1.09 kB 🔺
@sentry/node	166.93 kB	+0.55%	+906 B 🔺
@sentry/node - without tracing	74.38 kB	+0.5%	+364 B 🔺
@sentry/aws-serverless	109.18 kB	+1%	+1.07 kB 🔺
@sentry/cloudflare (withSentry) - minified	170.88 kB	-	-
@sentry/cloudflare (withSentry)	431.1 kB	-	-

View base workflow run

JPeer264

Got couple of comments. Nice splitting.

JPeer264

LGTM. The PR got way smaller now as well 🥳

Add platform-portable building blocks that server SDKs use to instrument incoming HTTP requests without depending on OTel HTTP instrumentation: - `getHttpServerSubscriptions`: diagnostics_channel listener for `http.server.request.start`, set up isolation scope, request data, trace continuation, optional body capture and request-session tracking - if `spans: true` option set, then also creates the root server span around the request lifecycle, applying static-asset/status-code filtering, `ignoreIncomingRequests` and `onSpanCreated` hooks - `recordRequestSession`: release-health session aggregation per request - `patchRequestToCaptureBody`: opt-in incoming request body capture Add `kind` field on `StartSpanOptions` so OTel-based SDKs can set SpanKind on the underlying span, and update `headersToDict` to allow `number`-valued headers to support Node.js types.

Replace inline `instrumentServer` Proxy/emit-wrapping implementation in node-light's HTTP integration with core's `getHttpServerSubscriptions`, which does the same work (isolation scope, request data, body capture, trace continuation, best-effort transaction name).

Replace inline `instrumentServer` Proxy/emit-wrapping in `httpServerIntegration.ts` with core's `getHttpServerSubscriptions`. OTel-specific concerns (header propagation, double-wrap context guard, `_startSpanCallback` dispatch) move into a `wrapServerEmitRequest` callback that `instrumentServer` invokes inside the per-request lifecycle. Re-export `recordRequestSession` from core so existing test continues to pass. Duplicate request-isolation/session/body-capture plumbing removed, logic now lives in `@sentry/core`'s subscription factory.

`patchRequestToCaptureBody` lives in `@sentry/core` now and both the light SDK and the OTel-based `httpServerIntegration` consume it from there.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b92be48. Configure here.}

isaacs requested a review from a team as a code owner May 9, 2026 18:23

sentryBot reviewed May 9, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/http/server-subscription.ts Outdated

cursorBot reviewed May 9, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/http/server-subscription.ts Outdated
Comment threadpackages/core/src/integrations/http/server-span-subscription.ts Outdated

isaacs marked this pull request as draft May 9, 2026 18:56

isaacs force-pushed the isaacschlueter/portable-http-integration-server branch from f1ac205 to 2954cdcCompare May 9, 2026 20:39

isaacs marked this pull request as ready for review May 9, 2026 21:06

JPeer264 reviewed May 11, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/http/patch-request-to-capture-body.ts

JPeer264 reviewed May 11, 2026
View reviewed changes

mydea reviewed May 12, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/connect/index.ts Outdated

mydea reviewed May 12, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/http/server-subscription.ts Outdated

isaacs force-pushed the isaacschlueter/portable-http-integration-server branch from 2954cdc to ccd0275Compare May 12, 2026 19:43

cursorBot reviewed May 12, 2026
View reviewed changes

Comment threadpackages/node-core/src/light/integrations/httpIntegration.ts
Comment threadpackages/core/src/integrations/http/server-subscription.ts Outdated

isaacs force-pushed the isaacschlueter/portable-http-integration-server branch from ccd0275 to c74cb0aCompare May 12, 2026 23:24

isaacs changed the title ~~Portable http.Server integration~~feat(core): HTTP server-spans subscription utilityMay 12, 2026

sentryBot reviewed May 12, 2026
View reviewed changes

Comment threadpackages/node-core/src/integrations/http/httpServerIntegration.ts

cursorBot reviewed May 12, 2026
View reviewed changes

Comment threadpackages/node-core/src/light/integrations/httpIntegration.ts
Comment threadpackages/core/src/integrations/http/server-subscription.ts Outdated

JPeer264 approved these changes May 13, 2026
View reviewed changes

isaacs changed the title ~~feat(core): HTTP server-spans subscription utility~~feat(core): HTTP server diagnostics channel utilityMay 13, 2026

isaacs force-pushed the isaacschlueter/portable-http-integration-server branch from c74cb0a to 1c4fb59Compare May 13, 2026 15:34

cursorBot reviewed May 13, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/http/server-subscription.ts Outdated
Comment threadpackages/core/src/integrations/http/server-subscription.ts

isaacs force-pushed the isaacschlueter/portable-http-integration-server branch from 1c4fb59 to 7ef4b27Compare May 13, 2026 15:56

cursorBot reviewed May 13, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/http/server-subscription.ts
Comment threadpackages/core/src/integrations/http/server-subscription.ts Outdated

isaacs added 4 commits May 13, 2026 09:37

chore(node-core): drop unused captureRequestBody
b92be48
`patchRequestToCaptureBody` lives in `@sentry/core` now and both the light SDK and the OTel-based `httpServerIntegration` consume it from there.

isaacs force-pushed the isaacschlueter/portable-http-integration-server branch from 7ef4b27 to b92be48Compare May 13, 2026 16:37

cursorBot reviewed May 13, 2026
View reviewed changes

Comment threadpackages/core/src/utils/request.ts

fix(core): preserve numeric header values in headersToDict
880a505

isaacs enabled auto-merge (squash) May 13, 2026 17:00

isaacs merged commit 7f2aa3d into developMay 13, 2026
522 of 525 checks passed

isaacs deleted the isaacschlueter/portable-http-integration-server branch May 13, 2026 18:04

sentry-release-botBot mentioned this pull request May 26, 2026
publish: getsentry/sentry-javascript@10.54.0 getsentry/publish#8271
Closed
47 tasks

Uh oh!

Uh oh!

Conversation

isaacs commented May 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

JPeer264 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JPeer264 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

isaacs commented May 9, 2026•
edited
Loading

github-actionsBot commented May 9, 2026•
edited
Loading