Skip to content

feat(browser): Migrate browser profiling thread data to span attributes - #20800

Merged
chargome merged 6 commits into
developfrom
cg-event-proc-profiling
May 12, 2026
Merged

feat(browser): Migrate browser profiling thread data to span attributes#20800
chargome merged 6 commits into
developfrom
cg-event-proc-profiling

Conversation

@chargome

Copy link
Copy Markdown
Member

Migrate thread.id/thread.name assignment from processEvent hook to span.setAttribute() at span start, covering legacy, trace, and manual profiling modes.

closes#20379

@chargomechargome self-assigned this May 11, 2026
@github-actions

github-actionsBot commented May 11, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser26.84 kB--
@sentry/browser - with treeshaking flags25.28 kB--
@sentry/browser (incl. Tracing)44.73 kB--
@sentry/browser (incl. Tracing + Span Streaming)46.73 kB--
@sentry/browser (incl. Tracing, Profiling)49.73 kB-0.05%-20 B 🔽
@sentry/browser (incl. Tracing, Replay)84.38 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags73.81 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)89.08 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)101.71 kB--
@sentry/browser (incl. Feedback)44.03 kB--
@sentry/browser (incl. sendFeedback)31.66 kB--
@sentry/browser (incl. FeedbackAsync)36.77 kB--
@sentry/browser (incl. Metrics)27.93 kB--
@sentry/browser (incl. Logs)28.08 kB--
@sentry/browser (incl. Metrics & Logs)28.75 kB--
@sentry/react28.59 kB--
@sentry/react (incl. Tracing)47.01 kB--
@sentry/vue31.75 kB--
@sentry/vue (incl. Tracing)46.59 kB--
@sentry/svelte26.86 kB--
CDN Bundle29.24 kB--
CDN Bundle (incl. Tracing)47.16 kB--
CDN Bundle (incl. Logs, Metrics)30.61 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)48.28 kB--
CDN Bundle (incl. Replay, Logs, Metrics)69.94 kB--
CDN Bundle (incl. Tracing, Replay)84.55 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)85.62 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)90.36 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)91.46 kB--
CDN Bundle - uncompressed85.99 kB--
CDN Bundle (incl. Tracing) - uncompressed141.47 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed90.18 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed144.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed215.01 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed260.18 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed263.62 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed273.87 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed277.31 kB--
@sentry/nextjs (client)49.52 kB--
@sentry/sveltekit (client)45.23 kB--
@sentry/node-core60.84 kB+0.02%+11 B 🔺
@sentry/node165.98 kB+0.01%+9 B 🔺
@sentry/node - without tracing73.96 kB+0.01%+5 B 🔺
@sentry/aws-serverless108.07 kB+0.01%+5 B 🔺
@sentry/cloudflare (withSentry) - minified170.66 kB--
@sentry/cloudflare (withSentry)430.47 kB--

View base workflow run

@chargome
chargome marked this pull request as ready for review May 11, 2026 12:17
@chargome
chargome requested a review from a team as a code ownerMay 11, 2026 12:17

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5b98ef3. Configure here.

Comment threadpackages/browser/test/profiling/UIProfiler.test.ts Outdated
@chargome
chargome requested review from nicohrubec and s1gr1dMay 11, 2026 13:43
Comment threadpackages/browser/src/profiling/utils.ts Outdated
Comment threadpackages/browser/src/profiling/utils.ts Outdated
Comment threadpackages/browser/test/profiling/UIProfiler.test.ts
Comment threadpackages/browser/test/profiling/UIProfiler.test.ts Outdated
@chargome
chargome merged commit 9f99463 into developMay 12, 2026
522 of 524 checks passed
@chargome
chargome deleted the cg-event-proc-profiling branch May 12, 2026 09:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event processor migration: Browser profiling thread attributes assignment

4 participants

@chargome@logaretm@nicohrubec@s1gr1d