Skip to content

ci(remix): Do not run playwright install again for remix - #20824

Merged
mydea merged 2 commits into
developfrom
fn/remix-integration
May 13, 2026
Merged

ci(remix): Do not run playwright install again for remix#20824
mydea merged 2 commits into
developfrom
fn/remix-integration

Conversation

@mydea

Copy link
Copy Markdown
Member

We already install playwright in remix integration tests on CI beforehand, so no need to run this again in the test command.

@mydeamydea self-assigned this May 12, 2026
@mydea
mydea requested a review from a team as a code ownerMay 12, 2026 11:25

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 74bbb09. Configure here.

Comment threadpackages/remix/package.json Outdated
"test": "yarn test:unit",
"test:integration": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server",
"test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client:ci test:integration:server",
"test:integration:ci": "run-s test:integration:clean test:integration:prepare test:integration:client test:integration:server",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local integration tests break: playwright install step orphaned

Medium Severity

The test:integration:prepare:playwright script is defined but never called from any pipeline. The test:integration script (used for local runs) no longer installs Playwright deps since that step was removed from test:integration:client. It likely needs to include test:integration:prepare:playwright in its run-s chain so local yarn test:integration still works.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 74bbb09. Configure here.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, we can run this manually if we need to run this locally

Comment threadpackages/remix/package.json Outdated
@github-actions

github-actionsBot commented May 12, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser26.84 kB--
@sentry/browser - with treeshaking flags25.28 kB--
@sentry/browser (incl. Tracing)44.73 kB--
@sentry/browser (incl. Tracing + Span Streaming)46.73 kB--
@sentry/browser (incl. Tracing, Profiling)49.73 kB--
@sentry/browser (incl. Tracing, Replay)84.38 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags73.81 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)89.08 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)101.71 kB--
@sentry/browser (incl. Feedback)44.03 kB--
@sentry/browser (incl. sendFeedback)31.66 kB--
@sentry/browser (incl. FeedbackAsync)36.77 kB--
@sentry/browser (incl. Metrics)27.93 kB--
@sentry/browser (incl. Logs)28.08 kB--
@sentry/browser (incl. Metrics & Logs)28.75 kB--
@sentry/react28.59 kB--
@sentry/react (incl. Tracing)47.01 kB--
@sentry/vue31.75 kB--
@sentry/vue (incl. Tracing)46.59 kB--
@sentry/svelte26.86 kB--
CDN Bundle29.24 kB--
CDN Bundle (incl. Tracing)47.16 kB--
CDN Bundle (incl. Logs, Metrics)30.61 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)48.28 kB--
CDN Bundle (incl. Replay, Logs, Metrics)69.94 kB--
CDN Bundle (incl. Tracing, Replay)84.55 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)85.62 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)90.36 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)91.46 kB--
CDN Bundle - uncompressed85.99 kB--
CDN Bundle (incl. Tracing) - uncompressed141.47 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed90.18 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed144.93 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed215.01 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed260.18 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed263.62 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed273.87 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed277.31 kB--
@sentry/nextjs (client)49.52 kB--
@sentry/sveltekit (client)45.23 kB--
@sentry/node-core60.84 kB+0.02%+12 B 🔺
@sentry/node165.98 kB+0.01%+9 B 🔺
@sentry/node - without tracing73.96 kB+0.01%+6 B 🔺
@sentry/aws-serverless108.07 kB+0.01%+4 B 🔺
@sentry/cloudflare (withSentry) - minified170.66 kB--
@sentry/cloudflare (withSentry)430.47 kB--

View base workflow run

@mydea
mydea merged commit 53c98be into developMay 13, 2026
85 checks passed
@mydea
mydea deleted the fn/remix-integration branch May 13, 2026 07:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@nicohrubec@s1gr1d