Uh oh!
There was an error while loading. Please reload this page.
fix(core): Include subpath type shims in published package - #20835
Merged
Conversation
The `browser.d.ts` and `server.d.ts` root-level shims were missing from the `files` list, so TypeScript compilers using `moduleResolution: "node"` (which don't support the `exports` field) couldn't resolve `@sentry/core/browser` or `@sentry/core/server` types. This broke downstream consumers like `@sentry/react-native`. Also adds `typesVersions` entries for the browser/server subpaths to support TypeScript < 5.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser.d.tsandserver.d.tsto thefileslist in@sentry/corepackage.jsonso they are included in the published npm tarballtypesVersionsentries forbrowserandserversubpaths to support TypeScript < 5.0Context
PR #20435 introduced
@sentry/core/browserand@sentry/core/serversubpath exports and added root-level.d.tsshim files for compatibility with TypeScript compilers that don't support theexportsfield (e.g.moduleResolution: "node"). However, the.d.tsshims were not added to thefileslist, so they were excluded from the published10.53.0tarball.This breaks downstream consumers like
@sentry/react-native(getsentry/sentry-react-native#6139) — their TS compiler can't resolve@sentry/core/browser, causingBaseTransportOptionsto become unresolvable andReactNativeTransportOptionsto fail the type constraint check:Test plan
npm pack --dry-runincludesbrowser.d.tsandserver.d.tsat the package root@sentry/react-nativebuilds successfully against a patched@sentry/core🤖 Generated with Claude Code