Uh oh!
There was an error while loading. Please reload this page.
fix(tests): pin wrangler to 4.86.0 in E2E test apps - #20891
Closed
logaretm wants to merge 4 commits into
Closed
Conversation
Wrangler versions before 4.86.0 have a bug that corrupts package.json files in node_modules by overwriting them with ESM bundle output. Ref: cloudflare/workers-sdk#13762 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
The node variant runs a plain Node.js server and doesn't need wrangler. Running wrangler deploy --dry-run corrupts @fastify/otel's package.json due to a wrangler bug (cloudflare/workers-sdk#13762), breaking the subsequent node test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
logaretm
marked this pull request as draft
May 14, 2026 20:32
This reverts commit 7f31523.
tsx 4.21.1/4.22.0 (published 2026-05-14) introduced a regression where its ESM loader transforms package.json files to ESM, breaking CJS require() calls for @fastify/otel's package.json. Also bumps astro-6-cf-workers wrangler to 4.91.0 to satisfy @cloudflare/vite-plugin's peer dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
logaretm
commented
May 14, 2026
MemberAuthor
Closing — wrangler was a red herring. The real issue is a tsx 4.21.1 regression. Clean PR at the new branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins wrangler to
4.86.0across all 13 E2E test apps that use it, looks like versions before 4.86.0 have a bug that corruptspackage.jsonfiles innode_modulesby overwriting them with ESM bundle output during builds.This was causing the
hono-4E2E test (and potentially others) to fail withSyntaxError: Unexpected token 'v', "var name=""... is not valid JSONon@fastify/otel'spackage.jsonRef: cloudflare/workers-sdk#13762