Uh oh!
There was an error while loading. Please reload this page.
fix(tests): pin tsx to 4.21.0 in hono-4 E2E test - #20892
Merged
Merged
Conversation
tsx 4.21.1 (published 2026-05-14) introduced a regression where its ESM
loader transforms .json files to ESM output. This breaks CJS require()
calls — specifically @fastify/otel's `require('./package.json')` gets
the ESM-transformed content instead of valid JSON, crashing the Node
test variant.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>Contributor
size-limit report 📦
|
nicohrubec
approved these changes
May 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsx 4.21.1, published today, introduced a regression where its ESM loader transforms
.jsonfiles into ESM output. This breaks@fastify/otel, which does a CJSrequire('./package.json')and getsvar name="@fastify/otel"...instead of valid JSON, crashing the hono-4 (node) E2E test.Pinning tsx to 4.21.0 avoids the regression.