Uh oh!
There was an error while loading. Please reload this page.
feat(core): Migrate request data to dataCollection - #21071
Merged
Conversation
chargome
commented
May 20, 2026
MemberAuthor
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
chargome
commented
May 21, 2026
MemberAuthor
bugbot run |
Uh oh!
There was an error while loading. Please reload this page.
chargome
marked this pull request as ready for review
May 21, 2026 09:51
chargome
requested review from
andreiborza, mydea and s1gr1d
and removed request for
a teamMay 21, 2026 09:51
chargomeforce-pushed
the
chargome/datacollection-ref-core
branch
2 times, most recently
from
May 21, 2026 13:42
dd64c4b to
8249dd4Compares1gr1d
approved these changes
May 26, 2026
| Object.entries(headers).forEach(([key, value]) => { | ||
| const regularHeaders: Record<string, string> = {}; | ||
| for (const [key, value] of Object.entries(headers)) { |
Member
There was a problem hiding this comment.
Q: Just wondering why forEach was changed to for .. of
MemberAuthor
There was a problem hiding this comment.
just for consistency within the file
chargome
commented
May 28, 2026
MemberAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2eab6f7. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
47 tasks
This was referenced May 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpHeadersToSpanAttributes()now acceptsResolvedDataCollectionand delegates filteringto
filterKeyValueData()from the data-collection utils instead of reimplementing deny/allow logic.Boolean (
sendDefaultPii) is still accepted for backward compat with external callers (TODO for v11 removal).requestDataIntegrationreadsclient.getDataCollectionOptions()instead ofclient.getOptions().sendDefaultPii.DEFAULT_INCLUDEis now derived fromdataCollectionat call time, with integration-levelincludeoptionsoverriding per spec.
server-subscription.tspassesclient.getDataCollectionOptions()to header attribute creationclosesMigrate request data to
dataCollection#21048