Uh oh!
There was an error while loading. Please reload this page.
feat(node-core): Migrate sendDefaultPii to dataCollection - #21100
Merged
Conversation
Migrate all three `sendDefaultPii` callsites in node-core to the new `dataCollection` client option: - `systemError.ts`: Use `getDataCollectionOptions().userInfo` to gate file paths in system error context - `context.ts`: Remove stale TODO — context data is technical context that should always be collected per spec - `httpServerSpansIntegration.ts`: Pass `getDataCollectionOptions()` directly to `httpHeadersToSpanAttributes` Refs GH-20931 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
commented
May 21, 2026
| async function addContext(event: Event): Promise<Event> { | ||
| const updatedContext = _updateContext(await contextsPromise); | ||
| // TODO(v11): conditional with `sendDefaultPii` here? |
MemberAuthor
There was a problem hiding this comment.
Contributor
size-limit report 📦
|
chargome
commented
May 21, 2026
MemberAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit edcdf45. Configure here.
chargome
marked this pull request as ready for review
May 22, 2026 08:28
chargome
requested review from
andreiborza, mydea and s1gr1d
and removed request for
a teamMay 22, 2026 08:28
JPeer264
approved these changes
May 22, 2026
s1gr1d
approved these changes
May 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate all three
sendDefaultPiicallsites in node-core to the newdataCollectionclient option:systemError.ts: UsegetDataCollectionOptions().userInfoto gate file paths in system error contextcontext.ts: Remove stale TODO — context data is technical context that should always be collected per spechttpServerSpansIntegration.ts: PassgetDataCollectionOptions()directly tohttpHeadersToSpanAttributescloses#20931