Uh oh!
There was an error while loading. Please reload this page.
feat(nextjs): Migrate sendDefaultPii to dataCollection - #21137
Conversation
size-limit report 📦
|
chargome
commented
May 29, 2026
bugbot run |
Uh oh!
There was an error while loading. Please reload this page.
| const result = addHeadersAsAttributes({ 'content-type': 'application/json' }); | ||
| expect(result).toEqual({}); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Feat PR lacks integration or E2E test coverage
Low Severity
This is a feat PR that migrates multiple code paths from sendDefaultPii to the dataCollection API, but the diff only includes unit tests (with heavy mocking). No integration or E2E test is present to validate the end-to-end behavior of these data-collection changes within an actual Next.js application. Per the review rules, feat PRs need at least one integration or E2E test. Flagging this because it was mentioned in the rules file.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 1ea8c62. Configure here.
There was a problem hiding this comment.
we got existing tests that cover this
1ea8c62 to
0d290e1Comparechargome
commented
May 29, 2026
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0d290e1. Configure here.
Uh oh!
There was an error while loading. Please reload this page.


Migrate
sendDefaultPiiusage in the Next.js package to thedataCollectionAPI:withServerActionInstrumentation: UsegetDataCollectionOptions().httpBodies.includes('outgoingResponse')to gate server action response recordingaddHeadersAsAttributes: UsehttpHeaders.requestfromgetDataCollectionOptions()to control header span attributes and filtering levelsetUrlProcessingMetadata: Remove thesendDefaultPiigate — URLs are fundamental request metadata, not PII-gated data (see spec update)pagesRouterRoutingInstrumentation: Remove thesendDefaultPiigate for route params — same reasoning as URLsref getsentry/sentry-docs#17911
closes#20932