Skip to content

feat(tanstackstart-react): Filter noisy dev transactions - #21145

Merged
nicohrubec merged 5 commits into
developfrom
feat/tanstack-start-ignore-noisy-spans
May 26, 2026
Merged

feat(tanstackstart-react): Filter noisy dev transactions#21145
nicohrubec merged 5 commits into
developfrom
feat/tanstack-start-ignore-noisy-spans

Conversation

@nicohrubec

@nicohrubecnicohrubec commented May 23, 2026

Copy link
Copy Markdown
Member

Vite dev server requests (/node_modules/, /@id/, /@react-refresh, /@tanstack-start/) and /favicon.ico generate noise. Filters them via ignoreSpans in init() so this works for both transactions and streamed spans.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubecnicohrubec changed the title feat(tanstackstart-react): Filter noisy dev transactions via ignoreSpansfeat(tanstackstart-react): Filter noisy dev transactionsMay 23, 2026
Comment threadpackages/tanstackstart-react/test/server/sdk.test.ts
Patterns without the method prefix match both server transaction names
(GET /node_modules/...) and browser resource span descriptions
(/node_modules/...).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Comment threadpackages/tanstackstart-react/src/client/sdk.ts
Comment threadpackages/tanstackstart-react/src/server/sdk.ts
These Vite dev paths account for the bulk of the noise (296+ resource.script
spans per pageload from unbundled module serving).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Comment threadpackages/tanstackstart-react/src/client/sdk.ts
Only /node_modules/, /@id/, /@react-refresh/, and /@vite/ actually
generate server-side http.server transactions in a real browser session.
The rest (favicon.ico, /@tanstack-start/, /@fs/) are handled by Vite
before reaching Node.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d5c230b. Configure here.

Comment threadpackages/tanstackstart-react/test/server/sdk.test.ts
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec
nicohrubec marked this pull request as ready for review May 26, 2026 07:18
@nicohrubec
nicohrubec requested a review from a team as a code ownerMay 26, 2026 07:18
@nicohrubec
nicohrubec requested review from chargome, mydea and s1gr1d and removed request for a team and mydeaMay 26, 2026 07:18
@nicohrubec
nicohrubec merged commit fb83c9b into developMay 26, 2026
46 checks passed
@nicohrubec
nicohrubec deleted the feat/tanstack-start-ignore-noisy-spans branch May 26, 2026 11:45
s1gr1d added a commit that referenced this pull request Jun 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nicohrubec@s1gr1d