WIP feat(opentelemetry): Add SentryTraceProvider - #21181

Closed
andreiborza wants to merge 9 commits into
developfrom
ab/sentry-tracer-provider
Closed

WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom
ab/sentry-tracer-provider

Conversation

@andreiborza

@andreiborzaandreiborza commented May 27, 2026

Copy link
Copy Markdown
Member

WIP

cursor[bot]
cursorBot reviewed May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions

github-actionsBot commented May 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺

View base workflow run

@andreiborza
andreiborzaforce-pushed the ab/sentry-tracer-provider branch from 0f2020a to 71e7c69CompareMay 27, 2026 05:27
mydea
mydea reviewed May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts Outdated
*/
public recordException(_exception: unknown, _time?: number | undefined): void {
// noop
public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {

@mydeamydeaMay 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.

@andreiborza
andreiborzaforce-pushed the ab/sentry-tracer-provider branch from 71e7c69 to a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot reviewed May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot reviewed Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot reviewed Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed the ab/sentry-tracer-provider branch from cf369b6 to 749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot reviewed Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot reviewed Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts Outdated
@andreiborza
andreiborzaforce-pushed the ab/sentry-tracer-provider branch 6 times, most recently from 8ebaf6b to 2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot reviewed Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot reviewed Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts Outdated
@andreiborza
andreiborzaforce-pushed the ab/sentry-tracer-provider branch from 959483b to 87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot reviewed Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot reviewed Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts Outdated
cursor[bot]
cursorBot reviewed Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts Outdated
cursor[bot]
cursorBot reviewed Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts Outdated
cursor[bot]
cursorBot reviewed Jun 9, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5917bab. Configure here.

Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed the ab/sentry-tracer-provider branch 3 times, most recently from d265e00 to 34725dfCompareJune 17, 2026 19:06
andreiborzaand others added 2 commits June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others added 2 commits June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed the ab/sentry-tracer-provider branch from 916e70a to a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs reviewed Jun 29, 2026
View reviewed changes

@isaacsisaacs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.

Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([

@isaacsisaacsJun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)

Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
* A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
*/
export class SentryTraceProvider implements TracerProvider {

@isaacsisaacsJun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.

Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)

Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
'http.status_text': statusMessage?.toUpperCase(),
};

const rpcMetadata = getRPCMetadata(context.active());

@isaacsisaacsJun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.

Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {

@isaacsisaacsJun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.

Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?

Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/** @inheritdoc */
public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
const key = JSON.stringify([name, version, options]);
const cachedTracer = this._tracers.get(key);

@isaacsisaacsJun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?

Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.

Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */

@isaacsisaacsJun 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)

@andreiborza

andreiborza commented Jun 30, 2026

Copy link
Copy Markdown
MemberAuthor

This PR is superseded by #21666.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
WIP feat(opentelemetry): Add SentryTraceProvider - #21181
Closed
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Closed
WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Conversation
@andreiborza
@andreiborzaandreiborza
commented
May 27, 2026

Copy link


Copy Markdown

Member
WIP
cursor[bot]
cursorBot
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions
github-actionsBot
commented
May 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺
View base workflow run
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69CompareMay 27, 2026 05:27
mydea
mydea
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts
Outdated

 */
 public recordException(_exception: unknown, _time?: number | undefined): void {
 // noop
 public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {
@mydeamydeaMay 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot
reviewed
May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725dfCompareJune 17, 2026 19:06
andreiborzaand others
added 2 commits
June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others
added 2 commits
June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs
reviewed
Jun 29, 2026
View reviewed changes
@isaacsisaacs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
 * A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
 */
export class SentryTraceProvider implements TracerProvider {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.
Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)
Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
 'http.status_text': statusMessage?.toUpperCase(),
 };

 const rpcMetadata = getRPCMetadata(context.active());
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.
Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
 /** @inheritdoc */
 public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
 const key = JSON.stringify([name, version, options]);
 const cachedTracer = this._tracers.get(key);
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?
Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)
@andreiborza
andreiborza
commented
Jun 30, 2026

Copy link


Copy Markdown

MemberAuthor
This PR is superseded by #21666.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
WIP feat(opentelemetry): Add SentryTraceProvider - #21181
Closed
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Closed
WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Conversation
@andreiborza
@andreiborzaandreiborza
commented
May 27, 2026

Copy link


Copy Markdown

Member
WIP
cursor[bot]
cursorBot
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions
github-actionsBot
commented
May 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺
View base workflow run
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69CompareMay 27, 2026 05:27
mydea
mydea
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts
Outdated

 */
 public recordException(_exception: unknown, _time?: number | undefined): void {
 // noop
 public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {
@mydeamydeaMay 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot
reviewed
May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725dfCompareJune 17, 2026 19:06
andreiborzaand others
added 2 commits
June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others
added 2 commits
June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs
reviewed
Jun 29, 2026
View reviewed changes
@isaacsisaacs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
 * A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
 */
export class SentryTraceProvider implements TracerProvider {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.
Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)
Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
 'http.status_text': statusMessage?.toUpperCase(),
 };

 const rpcMetadata = getRPCMetadata(context.active());
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.
Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
 /** @inheritdoc */
 public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
 const key = JSON.stringify([name, version, options]);
 const cachedTracer = this._tracers.get(key);
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?
Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)
@andreiborza
andreiborza
commented
Jun 30, 2026

Copy link


Copy Markdown

MemberAuthor
This PR is superseded by #21666.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
WIP feat(opentelemetry): Add SentryTraceProvider - #21181
Closed
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Closed
WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Conversation
@andreiborza
@andreiborzaandreiborza
commented
May 27, 2026

Copy link


Copy Markdown

Member
WIP
cursor[bot]
cursorBot
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions
github-actionsBot
commented
May 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺
View base workflow run
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69CompareMay 27, 2026 05:27
mydea
mydea
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts
Outdated

 */
 public recordException(_exception: unknown, _time?: number | undefined): void {
 // noop
 public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {
@mydeamydeaMay 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot
reviewed
May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725dfCompareJune 17, 2026 19:06
andreiborzaand others
added 2 commits
June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others
added 2 commits
June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs
reviewed
Jun 29, 2026
View reviewed changes
@isaacsisaacs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
 * A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
 */
export class SentryTraceProvider implements TracerProvider {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.
Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)
Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
 'http.status_text': statusMessage?.toUpperCase(),
 };

 const rpcMetadata = getRPCMetadata(context.active());
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.
Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
 /** @inheritdoc */
 public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
 const key = JSON.stringify([name, version, options]);
 const cachedTracer = this._tracers.get(key);
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?
Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)
@andreiborza
andreiborza
commented
Jun 30, 2026

Copy link


Copy Markdown

MemberAuthor
This PR is superseded by #21666.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
WIP feat(opentelemetry): Add SentryTraceProvider - #21181
Closed
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Closed
WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Conversation
@andreiborza
@andreiborzaandreiborza
commented
May 27, 2026

Copy link


Copy Markdown

Member
WIP
cursor[bot]
cursorBot
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions
github-actionsBot
commented
May 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺
View base workflow run
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69CompareMay 27, 2026 05:27
mydea
mydea
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts
Outdated

 */
 public recordException(_exception: unknown, _time?: number | undefined): void {
 // noop
 public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {
@mydeamydeaMay 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot
reviewed
May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725dfCompareJune 17, 2026 19:06
andreiborzaand others
added 2 commits
June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others
added 2 commits
June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs
reviewed
Jun 29, 2026
View reviewed changes
@isaacsisaacs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
 * A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
 */
export class SentryTraceProvider implements TracerProvider {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.
Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)
Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
 'http.status_text': statusMessage?.toUpperCase(),
 };

 const rpcMetadata = getRPCMetadata(context.active());
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.
Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
 /** @inheritdoc */
 public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
 const key = JSON.stringify([name, version, options]);
 const cachedTracer = this._tracers.get(key);
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?
Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)
@andreiborza
andreiborza
commented
Jun 30, 2026

Copy link


Copy Markdown

MemberAuthor
This PR is superseded by #21666.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
WIP feat(opentelemetry): Add SentryTraceProvider - #21181
Closed
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Closed
WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Conversation
@andreiborza
@andreiborzaandreiborza
commented
May 27, 2026

Copy link


Copy Markdown

Member
WIP
cursor[bot]
cursorBot
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions
github-actionsBot
commented
May 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺
View base workflow run
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69CompareMay 27, 2026 05:27
mydea
mydea
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts
Outdated

 */
 public recordException(_exception: unknown, _time?: number | undefined): void {
 // noop
 public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {
@mydeamydeaMay 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot
reviewed
May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725dfCompareJune 17, 2026 19:06
andreiborzaand others
added 2 commits
June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others
added 2 commits
June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs
reviewed
Jun 29, 2026
View reviewed changes
@isaacsisaacs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
 * A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
 */
export class SentryTraceProvider implements TracerProvider {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.
Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)
Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
 'http.status_text': statusMessage?.toUpperCase(),
 };

 const rpcMetadata = getRPCMetadata(context.active());
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.
Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
 /** @inheritdoc */
 public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
 const key = JSON.stringify([name, version, options]);
 const cachedTracer = this._tracers.get(key);
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?
Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)
@andreiborza
andreiborza
commented
Jun 30, 2026

Copy link


Copy Markdown

MemberAuthor
This PR is superseded by #21666.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
WIP feat(opentelemetry): Add SentryTraceProvider - #21181
Closed
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Closed
WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Conversation
@andreiborza
@andreiborzaandreiborza
commented
May 27, 2026

Copy link


Copy Markdown

Member
WIP
cursor[bot]
cursorBot
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions
github-actionsBot
commented
May 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺
View base workflow run
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69CompareMay 27, 2026 05:27
mydea
mydea
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts
Outdated

 */
 public recordException(_exception: unknown, _time?: number | undefined): void {
 // noop
 public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {
@mydeamydeaMay 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot
reviewed
May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725dfCompareJune 17, 2026 19:06
andreiborzaand others
added 2 commits
June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others
added 2 commits
June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs
reviewed
Jun 29, 2026
View reviewed changes
@isaacsisaacs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
 * A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
 */
export class SentryTraceProvider implements TracerProvider {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.
Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)
Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
 'http.status_text': statusMessage?.toUpperCase(),
 };

 const rpcMetadata = getRPCMetadata(context.active());
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.
Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
 /** @inheritdoc */
 public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
 const key = JSON.stringify([name, version, options]);
 const cachedTracer = this._tracers.get(key);
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?
Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)
@andreiborza
andreiborza
commented
Jun 30, 2026

Copy link


Copy Markdown

MemberAuthor
This PR is superseded by #21666.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
WIP feat(opentelemetry): Add SentryTraceProvider - #21181
Closed
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Closed
WIP feat(opentelemetry): Add SentryTraceProvider#21181
andreiborza wants to merge 9 commits into
developfrom 
ab/sentry-tracer-provider
Conversation
@andreiborza
@andreiborzaandreiborza
commented
May 27, 2026

Copy link


Copy Markdown

Member
WIP
cursor[bot]
cursorBot
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@github-actions
github-actionsBot
commented
May 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.45 kB--
@sentry/browser - with treeshaking flags25.88 kB--
@sentry/browser (incl. Tracing)45.93 kB-0.03%-10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)47.69 kB-0.02%-8 B 🔽
@sentry/browser (incl. Tracing, Profiling)50.72 kB-0.02%-9 B 🔽
@sentry/browser (incl. Tracing, Replay)85.13 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.72 kB-0.01%-7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.82 kB-0.02%-10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)102.48 kB-0.01%-6 B 🔽
@sentry/browser (incl. Feedback)44.62 kB--
@sentry/browser (incl. sendFeedback)32.25 kB--
@sentry/browser (incl. FeedbackAsync)37.38 kB--
@sentry/browser (incl. Metrics)28.52 kB--
@sentry/browser (incl. Logs)28.76 kB--
@sentry/browser (incl. Metrics & Logs)29.45 kB--
@sentry/react29.25 kB--
@sentry/react (incl. Tracing)48.23 kB-0.02%-8 B 🔽
@sentry/vue32.6 kB-0.03%-7 B 🔽
@sentry/vue (incl. Tracing)47.8 kB-0.02%-8 B 🔽
@sentry/svelte27.48 kB--
CDN Bundle29.84 kB--
CDN Bundle (incl. Tracing)47.85 kB-0.02%-6 B 🔽
CDN Bundle (incl. Logs, Metrics)31.39 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.19 kB-0.02%-6 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)70.7 kB--
CDN Bundle (incl. Tracing, Replay)85.2 kB-0.01%-5 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.47 kB-0.01%-8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB-0.01%-4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.3 kB-0.01%-7 B 🔽
CDN Bundle - uncompressed88.8 kB--
CDN Bundle (incl. Tracing) - uncompressed144.85 kB+0.02%+16 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed93.5 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.83 kB+0.02%+16 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.33 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.72 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.68 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.42 kB+0.01%+16 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.37 kB+0.01%+16 B 🔺
@sentry/nextjs (client)50.62 kB-0.01%-5 B 🔽
@sentry/sveltekit (client)46.33 kB-0.01%-4 B 🔽
@sentry/core/server75.88 kB+0.04%+25 B 🔺
@sentry/core/browser63.02 kB+0.03%+13 B 🔺
@sentry/node-core61.66 kB+0.06%+35 B 🔺
@sentry/node124.86 kB+0.78%+962 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)70.05 kB--
@sentry/node/light50.55 kB-0.01%-2 B 🔽
@sentry/node - without tracing75.01 kB+1.19%+877 B 🔺
@sentry/aws-serverless86.17 kB+1.11%+941 B 🔺
@sentry/cloudflare (withSentry) - minified172.94 kB+0.03%+49 B 🔺
@sentry/cloudflare (withSentry)432.62 kB+0.04%+145 B 🔺
View base workflow run
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69CompareMay 27, 2026 05:27
mydea
mydea
reviewed
May 27, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/sentrySpan.ts
Outdated

 */
 public recordException(_exception: unknown, _time?: number | undefined): void {
 // noop
 public recordException(exception: unknown, time?: SpanTimeInput | undefined): void {
@mydeamydeaMay 27, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215eCompareMay 28, 2026 04:15
cursor[bot]
cursorBot
reviewed
May 28, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7CompareJune 6, 2026 22:56
cursor[bot]
cursorBot
reviewed
Jun 6, 2026
View reviewed changes
Comment threadpackages/node/src/sdk/initOtel.ts
cursor[bot]
cursorBot
reviewed
Jun 7, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730CompareJune 8, 2026 10:54
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/utils/enhanceDscWithOpenTelemetryRootSpanName.ts
cursor[bot]
cursorBot
reviewed
Jun 8, 2026
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
Outdated

@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0CompareJune 8, 2026 14:05
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/trace.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
Comment threadpackages/core/src/tracing/idleSpan.ts
Outdated

cursor[bot]
cursorBot
reviewed
Jun 9, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
Comment threadpackages/node/src/sdk/initOtel.ts
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725dfCompareJune 17, 2026 19:06
andreiborzaand others
added 2 commits
June 19, 2026 14:30
@andreiborza@claude
ref(core): Gate updateName() custom source on an OTel inference brand
0086ecd
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept.
This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@andreiborza@claude
feat(opentelemetry): Add SentryTraceProvider
783da13
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans
instead of bridging through the full OTel SDK. Includes the `SentryTracer`,
`applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via
the span context, and supporting changes to the async context strategy,
setup checks, and DSC/root-span-name enhancement. Exposed for wiring via
`_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no
effect until enabled there.
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborzaand others
added 2 commits
June 19, 2026 14:35
@andreiborza@claude
feat(node): Wire up _experiments.useSentryTraceProvider
d0a0f89
Add the `useSentryTraceProvider` experimental option and the Node setup path
that registers the `SentryTraceProvider` (and its async context strategy)
instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the
`SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards
the HTTP server-spans integration for the missing async-local-storage lookup,
and finalizes span data on `spanEnd`. Defaults to off.
Co-Authored-By: Claude <noreply@anthropic.com>
@andreiborza
Add e2e tests
a6caf6a
@andreiborza
andreiborzaforce-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6aCompareJune 19, 2026 12:48
isaacs
isaacs
reviewed
Jun 29, 2026
View reviewed changes
@isaacsisaacs
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, mostly in the nitpick/bikeshed category, but a few that might be worth at least verifying aren't a concern before landing.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
const LEGACY_HTTP_RESPONSE_STATUS_CODE_ATTRIBUTE = 'http.status_code';
const RPC_GRPC_STATUS_CODE_ATTRIBUTE = 'rpc.grpc.status_code';

const VALID_SPAN_STATUS_MESSAGES = new Set([
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be somewhat minor, but it seems like this is duplicated with the same values in packages/opentelemetry/src/utils/mapStatus.ts. Would be nice to have a single source of truth. (Though, I suppose they're not likely to change, so maybe a non-issue.)
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
/**
 * A minimal OpenTelemetry TracerProvider which creates native Sentry spans.
 */
export class SentryTraceProvider implements TracerProvider {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but SentryTraceProvider vs otel's naming TracerProvider, could cause confusion? Autocomplete mostly protects us, and I imagine it's unlikely that anyone who isn't writing an SDK will be using this, but could be less confusing if named SentryTracerProvider.
Ie, it seems like what it's providing are SentryTracer objects, not "traces", so it's a "tracer provider", not a "trace provider". (This is extremely bikesheddy, I do realize.)
Comment threadpackages/node-core/src/integrations/http/httpServerSpansIntegration.ts
 'http.status_text': statusMessage?.toUpperCase(),
 };

 const rpcMetadata = getRPCMetadata(context.active());
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that if someone changes the RPCMetadata between the request and response, it won't be picked up? I'm imagining if a web framework updates the route at some point, or something like that.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
}

/** Apply OTel semantic inference to a Sentry span. */
export function applyOtelSpanData(span: Span, options: { finalizeStatus?: boolean } = {}): void {
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this method gets called twice per span, once at the span start, and then again on spanEnd. Since it does a full spanToJSON, I worry that the serialization overhead could get expensive.
Is it possible to either defer the whole thing until the span ends, or just do the necessary finalization at the end without computing all the data all over again? Presumably it won't often change, right?
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
 /** @inheritdoc */
 public getTracer(name: string, version?: string, options?: TracerOptions): Tracer {
 const key = JSON.stringify([name, version, options]);
 const cachedTracer = this._tracers.get(key);
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like SentryTracer is a just stateless "bag o' methods" object, so any tracer is equivalent to any other. Are we using them as keys in a map or something, that would require that they be unique per name/version/options? If not, maybe we could skip the cache, and just have a single instance?
Possible this will be needed in the future use case, and I'm just not seeing it because it's not in this PR, if so, disregard. But in that case, we might want to consider making this an LRU or setting some upper bound, just for safety's sake, so it doesn't blow up and become a memory leak.
Comment threadpackages/opentelemetry/src/sentryTraceProvider.ts
@@ -0,0 +1,356 @@
/* eslint-disable max-lines */
@isaacsisaacsJun 29, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, also, if those repeated consts (VALID_SPAN_STATUS_MESSAGES et al) are moved out into a shared location, probably don't need this override ;)
@andreiborza
andreiborza
commented
Jun 30, 2026

Copy link


Copy Markdown

MemberAuthor
This PR is superseded by #21666.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@isaacsisaacsisaacs left review comments
@mydeamydeamydea left review comments
@cursorcursor[bot]cursor[bot] left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@andreiborza@isaacs@mydea