ref(node): Stop custom-handling normalization of Domain/DomainEmitter

[mydea]

We have custom code normalizing Domain and DomainEmitter, which are node-only but deprecated and not widely used anymore. This would have affected this being serialized in a nested object, e.g. extra, where it would be something like:

// The rule is shape-based, not identity-based: any EventEmitter under `domain` matches.constemitter=newEventEmitter();emitter.on('error',()=>undefined);expect(normalize({domain: emitter})).toEqual({domain: '[Domain]'});

or

// The Node `domain` module stamps the originating EventEmitter onto caught errors// under `domainEmitter`. The rule is unconditional on the key match — no shape check —// so even non-emitter values under `domainEmitter` get replaced.constrealEmitter=newEventEmitter();realEmitter.on('data',()=>undefined);expect(normalize({domainEmitter: realEmitter})).toEqual({domainEmitter: '[DomainEmitter]'});

(We don't really have tests for this, I added these to verify how this looks today, they are not in the PR since they would be removed again basically)

With this PR, they will be normalized "normally", meaning they'd look something like this:

{
- "domain": "[Domain]",+ "domain": {+ "_events": {+ "newListener": "[Function: updateExceptionCapture]",+ "removeListener": "[Function: updateExceptionCapture]",+ },+ "_eventsCount": 2,+ "_maxListeners": undefined,+ "members": [],+ },
}

or

{
- "domainEmitter": "[DomainEmitter]",+ "domainEmitter": {+ "_events": {+ "data": "[Function: <anonymous>]",+ },+ "_eventsCount": 1,+ "_maxListeners": undefined,+ },
}

which is of course "worse" but IMHO this deprecated, not widely used feature does not necessarily warranty special handling in core - this code is also shipped to browsers.

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	27.27 kB	-0.17%	-46 B 🔽
@sentry/browser - with treeshaking flags	25.69 kB	-0.2%	-50 B 🔽
@sentry/browser (incl. Tracing)	45.27 kB	-0.1%	-45 B 🔽
@sentry/browser (incl. Tracing + Span Streaming)	47.51 kB	-0.1%	-44 B 🔽
@sentry/browser (incl. Tracing, Profiling)	50.25 kB	-0.1%	-47 B 🔽
@sentry/browser (incl. Tracing, Replay)	84.87 kB	-0.06%	-46 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	74.38 kB	-0.07%	-47 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)	89.59 kB	-0.06%	-47 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)	102.2 kB	-0.05%	-45 B 🔽
@sentry/browser (incl. Feedback)	44.46 kB	-0.11%	-45 B 🔽
@sentry/browser (incl. sendFeedback)	32.09 kB	-0.16%	-49 B 🔽
@sentry/browser (incl. FeedbackAsync)	37.21 kB	-0.12%	-43 B 🔽
@sentry/browser (incl. Metrics)	28.37 kB	-0.15%	-40 B 🔽
@sentry/browser (incl. Logs)	28.59 kB	-0.16%	-44 B 🔽
@sentry/browser (incl. Metrics & Logs)	29.29 kB	-0.16%	-45 B 🔽
@sentry/react	29.01 kB	-0.15%	-42 B 🔽
@sentry/react (incl. Tracing)	47.5 kB	-0.1%	-46 B 🔽
@sentry/vue	32.19 kB	-0.15%	-47 B 🔽
@sentry/vue (incl. Tracing)	47.13 kB	-0.1%	-44 B 🔽
@sentry/svelte	27.3 kB	-0.18%	-47 B 🔽
CDN Bundle	29.68 kB	-0.16%	-46 B 🔽
CDN Bundle (incl. Tracing)	47.8 kB	-0.09%	-39 B 🔽
CDN Bundle (incl. Logs, Metrics)	31.17 kB	-0.15%	-45 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics)	49.05 kB	-0.09%	-44 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)	70.48 kB	-0.08%	-50 B 🔽
CDN Bundle (incl. Tracing, Replay)	85.3 kB	-0.05%	-37 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	86.45 kB	-0.06%	-44 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback)	91.17 kB	-0.04%	-34 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	92.33 kB	-0.05%	-39 B 🔽
CDN Bundle - uncompressed	87.69 kB	-0.13%	-112 B 🔽
CDN Bundle (incl. Tracing) - uncompressed	144.18 kB	-0.08%	-110 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed	92.18 kB	-0.13%	-112 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	147.94 kB	-0.08%	-110 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	216.91 kB	-0.06%	-112 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed	262.96 kB	-0.05%	-110 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	266.7 kB	-0.05%	-110 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	276.66 kB	-0.04%	-110 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	280.39 kB	-0.04%	-110 B 🔽
@sentry/nextjs (client)	49.99 kB	-0.09%	-42 B 🔽
@sentry/sveltekit (client)	45.75 kB	-0.11%	-50 B 🔽
@sentry/core/server	76.44 kB	-0.06%	-39 B 🔽
@sentry/core/browser	63.19 kB	-0.07%	-42 B 🔽
@sentry/node-core	62.54 kB	-0.08%	-47 B 🔽
@sentry/node	131.06 kB	-0.04%	-44 B 🔽
@sentry/node - without tracing	74.98 kB	-0.06%	-45 B 🔽
@sentry/aws-serverless	87.2 kB	-0.06%	-44 B 🔽
@sentry/cloudflare (withSentry) - minified	173.4 kB	-0.07%	-114 B 🔽
@sentry/cloudflare (withSentry)	433.33 kB	-0.05%	-187 B 🔽

View base workflow run

[timfish]

Agreed, no point special casing any more!

[JPeer264]

I'm okay with the change. Also nice to see from time to time that all bundle sizes go down in a PR