Skip to content

chore: Promote lint warnings to errors#21213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 2 commits into from
May 28, 2026
Merged

chore: Promote lint warnings to errors #21213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2c236b
chore: Promote lint warnings to errors and fix unused parameter
mydea May 28, 2026
81cfedb
fix lint
mydea May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .oxlintrc.base.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@
"plugins": ["typescript", "import", "jsdoc", "vitest"],
"rules": {
"no-unused-vars": [
"warn",
"error",
{ "argsIgnorePattern": "^_", "varsIgnorePattern": "^_", "caughtErrorsIgnorePattern": "^_" }
],

Expand DownExpand Up@@ -55,7 +55,7 @@
"typescript/prefer-optional-chain": ["error"],
"typescript/no-redundant-type-constituents": "off",
"typescript/restrict-template-expressions": "off",
"typescript/await-thenable": "warn",
"typescript/await-thenable": "error",
"typescript/no-base-to-string": "off"
}
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/tracing/tracer-start-active-span-error/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { afterAll, describe, expect } from 'vitest';
import { afterAll, describe } from 'vitest';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

describe('tracer.startActiveSpan errors', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/tanstackstart-react/src/vite/routePatterns.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ export function makeRoutePatternPlugin(): Plugin {
resolvedRoot = config.root || process.cwd();
},

transform(code, id) {
transform(code, _id) {
// this is set in the `wrapFetchWithSentry` where the paths are getting replaced by their parametrized counterparts
// so this extraction should only happen once during the build (for the `wrapFetchWithSentry` file)
if (!code.includes('__SENTRY_ROUTE_PATTERNS__')) {
Expand Down
Loading