Uh oh!
There was an error while loading. Please reload this page.
test(node): Migrate node integration tests to dataCollection - #21283
Merged
Conversation
chargome
commented
Jun 2, 2026
MemberAuthor
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8404aeb. Configure here.
chargome
marked this pull request as ready for review
June 2, 2026 09:55
chargome
requested review from
JPeer264, andreiborza and s1gr1d
and removed request for
a teamJune 2, 2026 09:55
chargome
enabled auto-merge (squash)
June 2, 2026 09:56
dataCollectionJPeer264
reviewed
Jun 2, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
Maybe it'd be nice to add a test with inputs: false, outputs: true and/or the other way around.
s1gr1d
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#21279