Skip to content

feat(core): Default dataCollection.httpBodies to all valid body types - #21352

Merged
chargome merged 1 commit into
developfrom
cg/datacollection-body-defaults
Jun 8, 2026
Merged

feat(core): Default dataCollection.httpBodies to all valid body types#21352
chargome merged 1 commit into
developfrom
cg/datacollection-body-defaults

Conversation

@chargome

@chargomechargome commented Jun 5, 2026

Copy link
Copy Markdown
Member

Updates the dataCollection.httpBodies spec default from [] (off) to all four valid body types (incomingRequest, outgoingRequest, incomingResponse, outgoingResponse), per the updated DataCollection spec (getsentry/sentry-docs#18276).

This new default applies only when a user explicitly sets the dataCollection option. The sendDefaultPii bridge is left untouched.

closes#21346

@chargomechargome self-assigned this Jun 5, 2026
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.21 kB+0.02%+5 B 🔺
@sentry/browser - with treeshaking flags25.65 kB--
@sentry/browser (incl. Tracing)45.51 kB+0.01%+2 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)47.73 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Profiling)50.28 kB+0.01%+1 B 🔺
@sentry/browser (incl. Tracing, Replay)84.71 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.33 kB-0.01%-1 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)89.41 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.11 kB+0.01%+2 B 🔺
@sentry/browser (incl. Feedback)44.37 kB+0.02%+5 B 🔺
@sentry/browser (incl. sendFeedback)32.03 kB+0.02%+5 B 🔺
@sentry/browser (incl. FeedbackAsync)37.12 kB+0.02%+4 B 🔺
@sentry/browser (incl. Metrics)28.28 kB+0.01%+2 B 🔺
@sentry/browser (incl. Logs)28.53 kB+0.04%+10 B 🔺
@sentry/browser (incl. Metrics & Logs)29.22 kB+0.02%+3 B 🔺
@sentry/react29.02 kB+0.01%+2 B 🔺
@sentry/react (incl. Tracing)47.77 kB+0.01%+2 B 🔺
@sentry/vue32.22 kB+0.01%+1 B 🔺
@sentry/vue (incl. Tracing)47.4 kB+0.01%+1 B 🔺
@sentry/svelte27.23 kB+0.02%+3 B 🔺
CDN Bundle29.58 kB+0.02%+3 B 🔺
CDN Bundle (incl. Tracing)47.95 kB--
CDN Bundle (incl. Logs, Metrics)31.09 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.2 kB+0.01%+1 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.37 kB+0.01%+1 B 🔺
CDN Bundle (incl. Tracing, Replay)85.34 kB+0.01%+2 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.52 kB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.16 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.34 kB+0.01%+1 B 🔺
CDN Bundle - uncompressed87.77 kB+0.09%+73 B 🔺
CDN Bundle (incl. Tracing) - uncompressed144.97 kB+0.06%+73 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed92.26 kB+0.08%+73 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.73 kB+0.05%+73 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed217.07 kB+0.04%+73 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed263.84 kB+0.03%+73 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.58 kB+0.03%+73 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.54 kB+0.03%+73 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.27 kB+0.03%+73 B 🔺
@sentry/nextjs (client)50.26 kB-0.01%-1 B 🔽
@sentry/sveltekit (client)45.92 kB--
@sentry/core/server75.94 kB+0.01%+2 B 🔺
@sentry/core/browser63.09 kB-0.01%-1 B 🔽
@sentry/node-core61.73 kB+0.05%+25 B 🔺
@sentry/node130.43 kB+0.02%+21 B 🔺
@sentry/node - without tracing74.1 kB+0.03%+20 B 🔺
@sentry/aws-serverless86.29 kB+0.03%+21 B 🔺
@sentry/cloudflare (withSentry) - minified173.66 kB+0.05%+73 B 🔺
@sentry/cloudflare (withSentry)433.81 kB+0.02%+76 B 🔺

View base workflow run

@chargome

Copy link
Copy Markdown
MemberAuthor

bugbot run

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a02e3a5. Configure here.

@chargome
chargome marked this pull request as ready for review June 8, 2026 07:35
@chargome
chargome requested a review from s1gr1dJune 8, 2026 08:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change dataCollection.httpBodies default to all valid body types

2 participants

@chargome@s1gr1d