Skip to content

fix(cloudflare): Don't track negatively sampled spans - #21367

Merged
Lms24 merged 1 commit into
developfrom
lms/fix-cloudflare-dont-add-non-rec-spans
Jun 8, 2026
Merged

fix(cloudflare): Don't track negatively sampled spans#21367
Lms24 merged 1 commit into
developfrom
lms/fix-cloudflare-dont-add-non-rec-spans

Conversation

@Lms24

@Lms24Lms24 commented Jun 8, 2026

Copy link
Copy Markdown
Member

supersedes #21349 for the time being. This does not fix the case where a spanStart event is emitted not a spanEnd event isn't. It only locally fixes an occurance of the symptom. We're gonna merge this first to resolve the cloudflare SDK bug but we'll need a more reliable fix than the one I hacked to gether in #21349.

See #21349 (comment)

@Lms24
Lms24 requested a review from a team as a code ownerJune 8, 2026 15:57
@Lms24
Lms24 requested review from JPeer264 and andreiborza and removed request for a teamJune 8, 2026 15:57

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.21 kB--
@sentry/browser - with treeshaking flags25.65 kB--
@sentry/browser (incl. Tracing)45.51 kB--
@sentry/browser (incl. Tracing + Span Streaming)47.73 kB--
@sentry/browser (incl. Tracing, Profiling)50.29 kB--
@sentry/browser (incl. Tracing, Replay)84.71 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.34 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)89.41 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.11 kB--
@sentry/browser (incl. Feedback)44.37 kB--
@sentry/browser (incl. sendFeedback)32.03 kB--
@sentry/browser (incl. FeedbackAsync)37.12 kB--
@sentry/browser (incl. Metrics)28.28 kB--
@sentry/browser (incl. Logs)28.53 kB--
@sentry/browser (incl. Metrics & Logs)29.22 kB--
@sentry/react29.02 kB--
@sentry/react (incl. Tracing)47.78 kB--
@sentry/vue32.22 kB--
@sentry/vue (incl. Tracing)47.4 kB--
@sentry/svelte27.23 kB--
CDN Bundle29.58 kB--
CDN Bundle (incl. Tracing)47.95 kB--
CDN Bundle (incl. Logs, Metrics)31.09 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.2 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.37 kB--
CDN Bundle (incl. Tracing, Replay)85.34 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.52 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.16 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.34 kB--
CDN Bundle - uncompressed87.78 kB--
CDN Bundle (incl. Tracing) - uncompressed144.98 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed92.27 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.74 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed217.08 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed263.85 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.59 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.55 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.28 kB--
@sentry/nextjs (client)50.26 kB--
@sentry/sveltekit (client)45.92 kB--
@sentry/core/server75.96 kB--
@sentry/core/browser63.1 kB--
@sentry/node-core61.73 kB+0.01%+3 B 🔺
@sentry/node130.42 kB--
@sentry/node - without tracing74.1 kB--
@sentry/aws-serverless86.29 kB--
@sentry/cloudflare (withSentry) - minified173.69 kB+0.01%+8 B 🔺
@sentry/cloudflare (withSentry)433.85 kB+0.02%+58 B 🔺

View base workflow run

@Lms24
Lms24 merged commit 03ffd25 into developJun 8, 2026
135 of 141 checks passed
@Lms24
Lms24 deleted the lms/fix-cloudflare-dont-add-non-rec-spans branch June 8, 2026 16:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@andreiborza