Skip to content

fix(react-router): Mark instrumentation API active on invocation - #21420

Merged
chargome merged 3 commits into
developfrom
cg/native-api-active-on-run
Jun 10, 2026
Merged

fix(react-router): Mark instrumentation API active on invocation#21420
chargome merged 3 commits into
developfrom
cg/native-api-active-on-run

Conversation

@chargome

@chargomechargome commented Jun 10, 2026

Copy link
Copy Markdown
Member

Only marks the instrumentation API active once it actually fires, unsupported versions would not be instrumented at all otherwise.

closes#21392

@chargomechargome self-assigned this Jun 10, 2026
@github-actions

github-actionsBot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.21 kBaddedadded
@sentry/browser - with treeshaking flags25.65 kBaddedadded
@sentry/browser (incl. Tracing)45.51 kBaddedadded
@sentry/browser (incl. Tracing + Span Streaming)47.73 kBaddedadded
@sentry/browser (incl. Tracing, Profiling)50.29 kBaddedadded
@sentry/browser (incl. Tracing, Replay)84.71 kBaddedadded
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.34 kBaddedadded
@sentry/browser (incl. Tracing, Replay with Canvas)89.41 kBaddedadded
@sentry/browser (incl. Tracing, Replay, Feedback)102.11 kBaddedadded
@sentry/browser (incl. Feedback)44.37 kBaddedadded
@sentry/browser (incl. sendFeedback)32.03 kBaddedadded
@sentry/browser (incl. FeedbackAsync)37.12 kBaddedadded
@sentry/browser (incl. Metrics)28.28 kBaddedadded
@sentry/browser (incl. Logs)28.53 kBaddedadded
@sentry/browser (incl. Metrics & Logs)29.22 kBaddedadded
@sentry/react29.02 kBaddedadded
@sentry/react (incl. Tracing)47.78 kBaddedadded
@sentry/vue32.22 kBaddedadded
@sentry/vue (incl. Tracing)47.4 kBaddedadded
@sentry/svelte27.23 kBaddedadded
CDN Bundle29.58 kBaddedadded
CDN Bundle (incl. Tracing)47.95 kBaddedadded
CDN Bundle (incl. Logs, Metrics)31.09 kBaddedadded
CDN Bundle (incl. Tracing, Logs, Metrics)49.2 kBaddedadded
CDN Bundle (incl. Replay, Logs, Metrics)70.37 kBaddedadded
CDN Bundle (incl. Tracing, Replay)85.34 kBaddedadded
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.52 kBaddedadded
CDN Bundle (incl. Tracing, Replay, Feedback)91.16 kBaddedadded
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.34 kBaddedadded
CDN Bundle - uncompressed87.78 kBaddedadded
CDN Bundle (incl. Tracing) - uncompressed144.98 kBaddedadded
CDN Bundle (incl. Logs, Metrics) - uncompressed92.27 kBaddedadded
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed148.74 kBaddedadded
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed217.08 kBaddedadded
CDN Bundle (incl. Tracing, Replay) - uncompressed263.85 kBaddedadded
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed267.59 kBaddedadded
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.55 kBaddedadded
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.28 kBaddedadded
@sentry/nextjs (client)50.26 kBaddedadded
@sentry/sveltekit (client)45.92 kBaddedadded
@sentry/core/server75.96 kBaddedadded
@sentry/core/browser63.1 kBaddedadded
@sentry/node-core61.72 kBaddedadded
@sentry/node130.42 kBaddedadded
@sentry/node - without tracing74.11 kBaddedadded
@sentry/aws-serverless86.29 kBaddedadded
@sentry/cloudflare (withSentry) - minified173.69 kBaddedadded
@sentry/cloudflare (withSentry)433.85 kBaddedadded

Base automatically changed from charlygomez/js-2712-add-redis-backed-db-span-coverage-to-the-react-router-7 to developJune 10, 2026 08:23
@chargome
chargome marked this pull request as ready for review June 10, 2026 08:46
@chargome
chargome requested a review from a team as a code ownerJune 10, 2026 08:46
@chargome
chargome requested review from nicohrubec and s1gr1d and removed request for a teamJune 10, 2026 08:46
@chargome
chargome merged commit e7d83d4 into developJun 10, 2026
54 of 77 checks passed
@chargome
chargome deleted the cg/native-api-active-on-run branch June 10, 2026 09:30
@chargomechargome mentioned this pull request Jun 10, 2026
Merged
chargome added a commit that referenced this pull request Jun 11, 2026
@chargome
feat(react-router): Always build client instrumentation and deprecate…
349a080
… `useInstrumentationAPI` (#21432)
This is basically the first step in making the instrumentation API the
default without breaking unsupported versions.
- always build the client instrumentation for the instrumentation api,
as we changed detection for this in
#21420
- deprecate `useInstrumentationAPI` (becomes a no-op)
closes#21393
@sentry-release-botsentry-release-botBot mentioned this pull request Jun 15, 2026
Closed
48 tasks
@github-actionsgithub-actionsBot mentioned this pull request Jun 15, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicohrubecnicohrubecnicohrubec approved these changes
@s1gr1ds1gr1dAwaiting requested review from s1gr1ds1gr1d is a code owner automatically assigned from getsentry/team-javascript-sdks-framework

Assignees

@chargomechargome

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Only mark the native instrumentation API "active" once it actually runs

2 participants

@chargome@nicohrubec