Skip to content

ref(node): Drop eslint-ignores and oxlint exemption in generic-pool instrumentation - #21435

Merged
nicohrubec merged 2 commits into
developfrom
nh/streamline-generic-pool-lint-cleanup
Jun 10, 2026
Merged

ref(node): Drop eslint-ignores and oxlint exemption in generic-pool instrumentation#21435
nicohrubec merged 2 commits into
developfrom
nh/streamline-generic-pool-lint-cleanup

Conversation

@nicohrubec

@nicohrubecnicohrubec commented Jun 10, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Follow-up to the vendored-instrumentation streamlining removing some eslint ignores and the oxlint exemption.

nicohrubecand others added 2 commits June 10, 2026 12:33
@nicohrubec@claude
ref(node): Drop generic-pool no-explicit-any lint exemption
ad133a1
Type the one remaining `any` (the vendored Pool index signature) as `unknown`
and remove generic-pool from the no-explicit-any override in .oxlintrc.base.json.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nicohrubec@claude
ref(node): Remove generic-pool no-this-alias suppressions
b5d9fa2
Replace the three `const instrumentation = this` aliases with captured
tracer/bound methods/an arrow over the live `_isDisabled` flag, so no
eslint-disable is needed. Only true false-positives keep suppressions.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nicohrubecnicohrubec changed the title ref(node): Drop generic-pool no-explicit-any lint exemptionref(node): Drop eslint-ignores and oxlint exemption in generic-pool instrumentationJun 10, 2026
@nicohrubec
nicohrubec marked this pull request as ready for review June 10, 2026 10:48
@nicohrubec
nicohrubec requested a review from a team as a code ownerJune 10, 2026 10:48
@nicohrubec
nicohrubec requested review from JPeer264 and andreiborza and removed request for a teamJune 10, 2026 10:48
andreiborza
andreiborza approved these changes Jun 10, 2026
View reviewed changes

@andreiborzaandreiborza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

sentry[bot]
sentryBot reviewed Jun 10, 2026
View reviewed changes
Comment threadpackages/node/src/integrations/tracing/genericPool/vendored/instrumentation.ts
@github-actions

github-actionsBot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.39 kB--
@sentry/browser - with treeshaking flags25.82 kB--
@sentry/browser (incl. Tracing)45.68 kB--
@sentry/browser (incl. Tracing + Span Streaming)47.92 kB--
@sentry/browser (incl. Tracing, Profiling)50.48 kB--
@sentry/browser (incl. Tracing, Replay)84.9 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.51 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)89.6 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.28 kB--
@sentry/browser (incl. Feedback)44.55 kB--
@sentry/browser (incl. sendFeedback)32.19 kB--
@sentry/browser (incl. FeedbackAsync)37.3 kB--
@sentry/browser (incl. Metrics)28.46 kB--
@sentry/browser (incl. Logs)28.69 kB--
@sentry/browser (incl. Metrics & Logs)29.39 kB--
@sentry/react29.18 kB--
@sentry/react (incl. Tracing)47.98 kB--
@sentry/vue32.4 kB--
@sentry/vue (incl. Tracing)47.57 kB--
@sentry/svelte27.41 kB--
CDN Bundle29.78 kB--
CDN Bundle (incl. Tracing)48.16 kB--
CDN Bundle (incl. Logs, Metrics)31.32 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.48 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.61 kB--
CDN Bundle (incl. Tracing, Replay)85.51 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.75 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.34 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.6 kB--
CDN Bundle - uncompressed88.46 kB--
CDN Bundle (incl. Tracing) - uncompressed145.67 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed93.17 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.65 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed217.99 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.54 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.24 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.19 kB--
@sentry/nextjs (client)50.43 kB--
@sentry/sveltekit (client)46.1 kB--
@sentry/core/server76.01 kB--
@sentry/core/browser63.14 kB--
@sentry/node-core61.73 kB+0.01%+3 B 🔺
@sentry/node130.44 kB+0.03%+36 B 🔺
@sentry/node - without tracing74.11 kB--
@sentry/aws-serverless86.29 kB--
@sentry/cloudflare (withSentry) - minified173.69 kB--
@sentry/cloudflare (withSentry)433.85 kB--

View base workflow run

@nicohrubec
nicohrubec merged commit 4278bed into developJun 10, 2026
271 of 272 checks passed
@nicohrubec
nicohrubec deleted the nh/streamline-generic-pool-lint-cleanup branch June 10, 2026 11:08
@sentry-release-botsentry-release-botBot mentioned this pull request Jun 15, 2026
Closed
48 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@andreiborzaandreiborzaandreiborza approved these changes
@JPeer264JPeer264Awaiting requested review from JPeer264JPeer264 was automatically assigned from getsentry/team-javascript-sdks-server

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicohrubec@andreiborza