Uh oh!
There was an error while loading. Please reload this page.
fix(browser): Ignore __sentry_wrapped__ inherited from Function.prototype - #21506
Merged
Conversation
…ototype` When `wrap()` is called with `Function.prototype` itself as the callback (e.g. when a library passes `Function.prototype` as a noop handler), the wrapper is attached as an own property of `Function.prototype`. Every function then inherits `__sentry_wrapped__` via the prototype chain, so subsequent `wrap()` calls returned the stale prototype wrapper instead of wrapping the fresh callback — silently breaking every event listener registered afterwards. Check `__sentry_wrapped__` via `hasOwnProperty` in `wrap()` and in the patched `removeEventListener` so inherited wrappers are ignored.
Lms24
reviewed
Jun 12, 2026
Member
There was a problem hiding this comment.
Hey @bkchr thanks for opening this PR! Looks like a good bugfix!
when a library passes Function.prototype as a noop handler
Do you have a concrete example of a library passing in Function.prototype? Just wondering how you ran into this issue.
bkchr
commented
Jun 12, 2026
ContributorAuthor
Lms24
commented
Jun 12, 2026
Member
woah never seen a no-op function like this one. Great catch, thanks for fixing! |
Lms24
approved these changes
Jun 12, 2026
bkchr
commented
Jun 12, 2026
ContributorAuthor
Ty for the swift merge! |
nicohrubec pushed a commit
that referenced
this pull request
Jun 12, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #21506 Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
wrap()is called withFunction.prototypeitself as the callback (e.g. when a library passesFunction.prototypeas a noop handler), the wrapper is attached as an own property ofFunction.prototype. Every function then inherits__sentry_wrapped__via the prototype chain, so subsequentwrap()calls returned the stale prototype wrapper instead of wrapping the fresh callback — silently breaking every event listener registered afterwards.Check
__sentry_wrapped__viahasOwnPropertyinwrap()and in the patchedremoveEventListenerso inherited wrappers are ignored.