ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mydea wants to merge 12 commits into from
Closed

ref(typescript): Default to node16 module/moduleResolution #21520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
92f669c
move to node16 moduleResolution
mydea Jun 15, 2026
e64eea5
fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…
mydea Jun 15, 2026
54b7236
fix(angular): Use esnext/bundler instead of node16 default
mydea Jun 15, 2026
5a5b574
fix nx implicit dependency for typescript
mydea Jun 15, 2026
0e8b80d
fix test-utils module
mydea Jun 15, 2026
1e7b2f2
fix(solid): Use esnext/bundler instead of node16 default
mydea Jun 15, 2026
d7421e2
fix(angular): Inline tsconfig instead of extending the node16 base
mydea Jun 15, 2026
1c87dbe
fix tests
mydea Jun 15, 2026
638c02e
fix browser-integration-tests
mydea Jun 15, 2026
debf405
fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…
mydea Jun 15, 2026
6229192
fix(test): Drop module override for TS 3.8 instead of forcing esnext
mydea Jun 15, 2026
12113fc
ref(typescript): Default to esnext/bundler instead of node16
mydea Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev-packages/browser-integration-tests/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

"compilerOptions": {
"lib": ["dom", "ES2020"],
"moduleResolution": "node",
"noEmit": true,
"strict": true,
"allowSyntheticDefaultImports": true,
Expand Down
7 changes: 7 additions & 0 deletions dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));
7 changes: 7 additions & 0 deletions dev-packages/node-integration-tests/scripts/use-ts-3_8.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));
1 change: 0 additions & 1 deletion dev-packages/test-utils/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
"extends": "../../tsconfig.json",
"compilerOptions": {
"target": "ES2022",
"module": "ES2022",
// package-specific options
"esModuleInterop": true
},
Expand Down
3 changes: 2 additions & 1 deletion nx.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
"{workspaceRoot}/*.js",
"{workspaceRoot}/*.json",
"{workspaceRoot}/yarn.lock",
"{workspaceRoot}/dev-packages/rollup-utils/**"
"{workspaceRoot}/dev-packages/rollup-utils/**",
"{workspaceRoot}/packages/typescript/**"
],
"production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
},
Expand Down
29 changes: 26 additions & 3 deletions packages/angular/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
"extends": "../../tsconfig.json",

// NOTE: Unlike every other package, this config does NOT extend the shared base config
// (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
// TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
// defaults to (and rejects the literal even when overridden). We therefore inline the relevant
// base compiler options here and use `esnext`/`node` instead.
"include": ["**/*.ts", "src/**/*"],

"exclude": ["patch-vitest.ts", "setup-test.ts"],

"compilerOptions": {
// package-specific options
"declaration": false,
"declarationMap": false,
"downlevelIteration": true,
"importHelpers": true,
"inlineSources": true,
"isolatedModules": true,
"lib": ["es2020"],
"module": "esnext",
"moduleResolution": "node",
"noErrorTruncation": true,
"noFallthroughCasesInSwitch": true,
"noImplicitReturns": true,
"noUnusedLocals": false,
"noUnusedParameters": false,
"preserveWatchOutput": true,
"sourceMap": true,
"strict": true,
"strictBindCallApply": false,
"target": "es2020",
"noUncheckedIndexedAccess": true,
"skipLibCheck": true,
"experimentalDecorators": true
}
}
1 change: 0 additions & 1 deletion packages/astro/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"moduleResolution": "bundler"
// package-specific options
}
}
1 change: 0 additions & 1 deletion packages/browser/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
"include": ["src/**/*", "test/loader.js"],

"compilerOptions": {
"moduleResolution": "bundler",
"lib": ["DOM", "es2020", "WebWorker"]
}
}
1 change: 0 additions & 1 deletion packages/cloudflare/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"module": "esnext",
"types": ["node", "@cloudflare/workers-types"]
}
}
2 changes: 0 additions & 2 deletions packages/core/tsconfig.types.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
"extends": "./tsconfig.json",

"compilerOptions": {
"module": "esnext",
"moduleResolution": "bundler",
"declaration": true,
"declarationMap": true,
"emitDeclarationOnly": true,
Expand Down
1 change: 0 additions & 1 deletion packages/deno/tsconfig.build.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
"compilerOptions": {
"outDir": "build",
"lib": ["esnext"],
"module": "esnext",
"target": "esnext",
"declaration": true,
"declarationMap": false
Expand Down
1 change: 0 additions & 1 deletion packages/deno/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
"include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
"compilerOptions": {
"lib": ["esnext"],
"module": "esnext",
"target": "esnext"
}
}
1 change: 0 additions & 1 deletion packages/deno/tsconfig.test.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
"include": ["./lib.deno.d.ts", "test/**/*"],
"compilerOptions": {
"lib": ["esnext"],
"module": "esnext",
"target": "esnext"
}
}
2 changes: 0 additions & 2 deletions packages/effect/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "esnext",
"moduleResolution": "bundler",
"outDir": "build"
},
"include": ["src/**/*"]
Expand Down
2 changes: 0 additions & 2 deletions packages/ember/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
"target": "es2022",
"lib": ["DOM", "ES2022"],
"allowJs": true,
"moduleResolution": "bundler",
"allowSyntheticDefaultImports": true,
"alwaysStrict": true,
"strictNullChecks": true,
"strictPropertyInitialization": true,
"noEmitOnError": false,
"noEmit": true,
"baseUrl": ".",
"module": "esnext",
"experimentalDecorators": true,
"paths": {
"dummy/tests/*": ["tests/*"],
Expand Down
2 changes: 0 additions & 2 deletions packages/feedback/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "esnext",

/* Preact Config */
"jsx": "react-jsx",
"jsxImportSource": "preact",
Expand Down
1 change: 0 additions & 1 deletion packages/hono/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"module": "esnext",
"types": ["node", "@cloudflare/workers-types"]
}
}
1 change: 0 additions & 1 deletion packages/integration-shims/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"moduleResolution": "bundler"
// package-specific options
}
}
2 changes: 0 additions & 2 deletions packages/nextjs/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

"compilerOptions": {
// package-specific options
"module": "esnext",
"moduleResolution": "bundler"
}
}
2 changes: 0 additions & 2 deletions packages/nitro/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

"compilerOptions": {
// package-specific options
"module": "esnext",
"moduleResolution": "bundler"
}
}
4 changes: 1 addition & 3 deletions packages/node-core/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["ES2020", "ES2021.WeakRef"],
"module": "Node16",
"moduleResolution": "Node16"
"lib": ["ES2020", "ES2021.WeakRef"]
}
}
2 changes: 0 additions & 2 deletions packages/node-native/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "esnext",
"lib": ["es2020"],
"outDir": "build",
"types": ["node"]
},
Expand Down
8 changes: 1 addition & 7 deletions packages/node/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
"extends": "../../tsconfig.json",

"include": ["src/**/*"],

"compilerOptions": {
"lib": ["es2020"],
"module": "Node16",
"moduleResolution": "Node16"
}
"include": ["src/**/*"]
}
2 changes: 0 additions & 2 deletions packages/nuxt/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

"compilerOptions": {
// package-specific options
"module": "esnext",
"moduleResolution": "bundler"
}
}
2 changes: 0 additions & 2 deletions packages/profiling-node/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "esnext",
"lib": ["es2020"],
"outDir": "build",
"types": ["node"]
},
Expand Down
1 change: 0 additions & 1 deletion packages/react-router/test/server/wrapServerAction.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
it('should skip span creation and warn when instrumentation API is used', async () => {
// Reset modules to get a fresh copy with unset warning flag
vi.resetModules();
// @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

// Set the global flag indicating instrumentation API is in use
Expand Down
1 change: 0 additions & 1 deletion packages/react-router/test/server/wrapServerLoader.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
it('should skip span creation and warn when instrumentation API is used', async () => {
// Reset modules to get a fresh copy with unset warning flag
vi.resetModules();
// @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

// Set the global flag indicating instrumentation API is in use
Expand Down
1 change: 0 additions & 1 deletion packages/react-router/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"moduleResolution": "bundler",
"jsx": "react"
}
}
2 changes: 0 additions & 2 deletions packages/react/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

"compilerOptions": {
"lib": ["DOM", "es2020"],
"module": "esnext",
"moduleResolution": "bundler",
// package-specific options
"esModuleInterop": true,
"jsx": "react"
Expand Down
4 changes: 1 addition & 3 deletions packages/remix/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"jsx": "react",
"module": "esnext",
"moduleResolution": "bundler"
"jsx": "react"
}
}
3 changes: 1 addition & 2 deletions packages/replay-canvas/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"lib": ["DOM", "es2020"],
"module": "esnext"
"lib": ["DOM", "es2020"]
},
"include": ["src/**/*.ts"]
}
3 changes: 1 addition & 2 deletions packages/replay-internal/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"lib": ["DOM", "es2020"],
"module": "esnext"
"lib": ["DOM", "es2020"]
},
"include": ["src/**/*.ts"]
}
1 change: 0 additions & 1 deletion packages/replay-worker/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
"extends": "../../tsconfig.json",
"compilerOptions": {
"module": "esnext",
"lib": ["webworker", "scripthost"],
"esModuleInterop": true,
"target": "es2020",
Expand Down
6 changes: 1 addition & 5 deletions packages/server-utils/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
"extends": "../../tsconfig.json",

"include": ["src/**/*"],

"compilerOptions": {
"lib": ["ES2020"]
}
"include": ["src/**/*"]
}
3 changes: 3 additions & 0 deletions packages/solid/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

"compilerOptions": {
"lib": ["DOM", "es2020"]
// This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
// can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
// bundler, so use `esnext`/`bundler` here instead of the `node16` default.
}
}
5 changes: 1 addition & 4 deletions packages/solidstart/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

"include": ["src/**/*"],

"compilerOptions": {
"module": "esnext",
"moduleResolution": "bundler"
}
"compilerOptions": {}
}
7 changes: 6 additions & 1 deletion packages/svelte/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
"include": ["src/**/*"],

"compilerOptions": {
"lib": ["DOM", "es2020"]
"lib": ["DOM", "es2020"],
// We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
// that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
// so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
"module": "esnext",
"moduleResolution": "node"
}
}
2 changes: 0 additions & 2 deletions packages/sveltekit/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
"include": ["src/**/*"],

"compilerOptions": {
"module": "esnext",
"moduleResolution": "bundler"
// package-specific options
}
}
5 changes: 1 addition & 4 deletions packages/tanstackstart-react/tsconfig.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
"extends": "../../tsconfig.json",
"include": ["src/**/*"],
"compilerOptions": {
"module": "esnext",
"moduleResolution": "bundler"
}
"compilerOptions": {}
}
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

mydea
wants to merge
12
commits into

from

 Closed


ref(typescript): Default to node16 module/moduleResolution
#21520
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
92f669c

move to node16 moduleResolution


mydea Jun 15, 2026
e64eea5

fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…


mydea Jun 15, 2026
54b7236

fix(angular): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
5a5b574

fix nx implicit dependency for typescript


mydea Jun 15, 2026
0e8b80d

fix test-utils module


mydea Jun 15, 2026
1e7b2f2

fix(solid): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
d7421e2

fix(angular): Inline tsconfig instead of extending the node16 base


mydea Jun 15, 2026
1c87dbe

fix tests


mydea Jun 15, 2026
638c02e

fix browser-integration-tests


mydea Jun 15, 2026
debf405

fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…


mydea Jun 15, 2026
6229192

fix(test): Drop module override for TS 3.8 instead of forcing esnext


mydea Jun 15, 2026
12113fc

ref(typescript): Default to esnext/bundler instead of node16


mydea Jun 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/browser-integration-tests/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

 "compilerOptions": {
 "lib": ["dom", "ES2020"],
 "moduleResolution": "node",
 "noEmit": true,
 "strict": true,
 "allowSyntheticDefaultImports": true,
Expand Down

7 changes: 7 additions & 0 deletions
dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

7 changes: 7 additions & 0 deletions
dev-packages/node-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

1 change: 0 additions & 1 deletion
dev-packages/test-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "target": "ES2022",
 "module": "ES2022",
 // package-specific options
 "esModuleInterop": true
 },
Expand Down

3 changes: 2 additions & 1 deletion
nx.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
 "{workspaceRoot}/*.js",
 "{workspaceRoot}/*.json",
 "{workspaceRoot}/yarn.lock",
 "{workspaceRoot}/dev-packages/rollup-utils/**"
 "{workspaceRoot}/dev-packages/rollup-utils/**",
 "{workspaceRoot}/packages/typescript/**"
 ],
 "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
 },
Expand Down

29 changes: 26 additions & 3 deletions
packages/angular/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
 "extends": "../../tsconfig.json",

 // NOTE: Unlike every other package, this config does NOT extend the shared base config
 // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
 // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
 // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
 // base compiler options here and use `esnext`/`node` instead.
 "include": ["**/*.ts", "src/**/*"],

 "exclude": ["patch-vitest.ts", "setup-test.ts"],

 "compilerOptions": {
 // package-specific options
 "declaration": false,
 "declarationMap": false,
 "downlevelIteration": true,
 "importHelpers": true,
 "inlineSources": true,
 "isolatedModules": true,
 "lib": ["es2020"],
 "module": "esnext",
 "moduleResolution": "node",
 "noErrorTruncation": true,
 "noFallthroughCasesInSwitch": true,
 "noImplicitReturns": true,
 "noUnusedLocals": false,
 "noUnusedParameters": false,
 "preserveWatchOutput": true,
 "sourceMap": true,
 "strict": true,
 "strictBindCallApply": false,
 "target": "es2020",
 "noUncheckedIndexedAccess": true,
 "skipLibCheck": true,
 "experimentalDecorators": true
 }
}

1 change: 0 additions & 1 deletion
packages/astro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

1 change: 0 additions & 1 deletion
packages/browser/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*", "test/loader.js"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "lib": ["DOM", "es2020", "WebWorker"]
 }
}

1 change: 0 additions & 1 deletion
packages/cloudflare/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

2 changes: 0 additions & 2 deletions
packages/core/tsconfig.types.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
 "extends": "./tsconfig.json",

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "declaration": true,
 "declarationMap": true,
 "emitDeclarationOnly": true,
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.build.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "compilerOptions": {
 "outDir": "build",
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext",
 "declaration": true,
 "declarationMap": false
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.test.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "test/**/*"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

2 changes: 0 additions & 2 deletions
packages/effect/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "outDir": "build"
 },
 "include": ["src/**/*"]
Expand Down

2 changes: 0 additions & 2 deletions
packages/ember/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
 "target": "es2022",
 "lib": ["DOM", "ES2022"],
 "allowJs": true,
 "moduleResolution": "bundler",
 "allowSyntheticDefaultImports": true,
 "alwaysStrict": true,
 "strictNullChecks": true,
 "strictPropertyInitialization": true,
 "noEmitOnError": false,
 "noEmit": true,
 "baseUrl": ".",
 "module": "esnext",
 "experimentalDecorators": true,
 "paths": {
 "dummy/tests/*": ["tests/*"],
Expand Down

2 changes: 0 additions & 2 deletions
packages/feedback/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",

 /* Preact Config */
 "jsx": "react-jsx",
 "jsxImportSource": "preact",
Expand Down

1 change: 0 additions & 1 deletion
packages/hono/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

1 change: 0 additions & 1 deletion
packages/integration-shims/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

2 changes: 0 additions & 2 deletions
packages/nextjs/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/nitro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

4 changes: 1 addition & 3 deletions
packages/node-core/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020", "ES2021.WeakRef"],
 "module": "Node16",
 "moduleResolution": "Node16"
 "lib": ["ES2020", "ES2021.WeakRef"]
 }
}

2 changes: 0 additions & 2 deletions
packages/node-native/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

8 changes: 1 addition & 7 deletions
packages/node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["es2020"],
 "module": "Node16",
 "moduleResolution": "Node16"
 }
 "include": ["src/**/*"]
}

2 changes: 0 additions & 2 deletions
packages/nuxt/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/profiling-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerAction.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerLoader.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "jsx": "react"
 }
}

2 changes: 0 additions & 2 deletions
packages/react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext",
 "moduleResolution": "bundler",
 // package-specific options
 "esModuleInterop": true,
 "jsx": "react"
Expand Down

4 changes: 1 addition & 3 deletions
packages/remix/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "jsx": "react",
 "module": "esnext",
 "moduleResolution": "bundler"
 "jsx": "react"
 }
}

3 changes: 1 addition & 2 deletions
packages/replay-canvas/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

3 changes: 1 addition & 2 deletions
packages/replay-internal/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

1 change: 0 additions & 1 deletion
packages/replay-worker/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["webworker", "scripthost"],
 "esModuleInterop": true,
 "target": "es2020",
Expand Down

6 changes: 1 addition & 5 deletions
packages/server-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020"]
 }
 "include": ["src/**/*"]
}

3 changes: 3 additions & 0 deletions
packages/solid/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
 // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
 // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
 }
}

5 changes: 1 addition & 4 deletions
packages/solidstart/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}

7 changes: 6 additions & 1 deletion
packages/svelte/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 "lib": ["DOM", "es2020"],
 // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
 // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
 // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
 "module": "esnext",
 "moduleResolution": "node"
 }
}

2 changes: 0 additions & 2 deletions
packages/sveltekit/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 // package-specific options
 }
}

5 changes: 1 addition & 4 deletions
packages/tanstackstart-react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
 "extends": "../../tsconfig.json",
 "include": ["src/**/*"],
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

mydea
wants to merge
12
commits into

from

 Closed


ref(typescript): Default to node16 module/moduleResolution
#21520
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
92f669c

move to node16 moduleResolution


mydea Jun 15, 2026
e64eea5

fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…


mydea Jun 15, 2026
54b7236

fix(angular): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
5a5b574

fix nx implicit dependency for typescript


mydea Jun 15, 2026
0e8b80d

fix test-utils module


mydea Jun 15, 2026
1e7b2f2

fix(solid): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
d7421e2

fix(angular): Inline tsconfig instead of extending the node16 base


mydea Jun 15, 2026
1c87dbe

fix tests


mydea Jun 15, 2026
638c02e

fix browser-integration-tests


mydea Jun 15, 2026
debf405

fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…


mydea Jun 15, 2026
6229192

fix(test): Drop module override for TS 3.8 instead of forcing esnext


mydea Jun 15, 2026
12113fc

ref(typescript): Default to esnext/bundler instead of node16


mydea Jun 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/browser-integration-tests/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

 "compilerOptions": {
 "lib": ["dom", "ES2020"],
 "moduleResolution": "node",
 "noEmit": true,
 "strict": true,
 "allowSyntheticDefaultImports": true,
Expand Down

7 changes: 7 additions & 0 deletions
dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

7 changes: 7 additions & 0 deletions
dev-packages/node-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

1 change: 0 additions & 1 deletion
dev-packages/test-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "target": "ES2022",
 "module": "ES2022",
 // package-specific options
 "esModuleInterop": true
 },
Expand Down

3 changes: 2 additions & 1 deletion
nx.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
 "{workspaceRoot}/*.js",
 "{workspaceRoot}/*.json",
 "{workspaceRoot}/yarn.lock",
 "{workspaceRoot}/dev-packages/rollup-utils/**"
 "{workspaceRoot}/dev-packages/rollup-utils/**",
 "{workspaceRoot}/packages/typescript/**"
 ],
 "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
 },
Expand Down

29 changes: 26 additions & 3 deletions
packages/angular/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
 "extends": "../../tsconfig.json",

 // NOTE: Unlike every other package, this config does NOT extend the shared base config
 // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
 // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
 // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
 // base compiler options here and use `esnext`/`node` instead.
 "include": ["**/*.ts", "src/**/*"],

 "exclude": ["patch-vitest.ts", "setup-test.ts"],

 "compilerOptions": {
 // package-specific options
 "declaration": false,
 "declarationMap": false,
 "downlevelIteration": true,
 "importHelpers": true,
 "inlineSources": true,
 "isolatedModules": true,
 "lib": ["es2020"],
 "module": "esnext",
 "moduleResolution": "node",
 "noErrorTruncation": true,
 "noFallthroughCasesInSwitch": true,
 "noImplicitReturns": true,
 "noUnusedLocals": false,
 "noUnusedParameters": false,
 "preserveWatchOutput": true,
 "sourceMap": true,
 "strict": true,
 "strictBindCallApply": false,
 "target": "es2020",
 "noUncheckedIndexedAccess": true,
 "skipLibCheck": true,
 "experimentalDecorators": true
 }
}

1 change: 0 additions & 1 deletion
packages/astro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

1 change: 0 additions & 1 deletion
packages/browser/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*", "test/loader.js"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "lib": ["DOM", "es2020", "WebWorker"]
 }
}

1 change: 0 additions & 1 deletion
packages/cloudflare/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

2 changes: 0 additions & 2 deletions
packages/core/tsconfig.types.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
 "extends": "./tsconfig.json",

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "declaration": true,
 "declarationMap": true,
 "emitDeclarationOnly": true,
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.build.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "compilerOptions": {
 "outDir": "build",
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext",
 "declaration": true,
 "declarationMap": false
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.test.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "test/**/*"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

2 changes: 0 additions & 2 deletions
packages/effect/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "outDir": "build"
 },
 "include": ["src/**/*"]
Expand Down

2 changes: 0 additions & 2 deletions
packages/ember/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
 "target": "es2022",
 "lib": ["DOM", "ES2022"],
 "allowJs": true,
 "moduleResolution": "bundler",
 "allowSyntheticDefaultImports": true,
 "alwaysStrict": true,
 "strictNullChecks": true,
 "strictPropertyInitialization": true,
 "noEmitOnError": false,
 "noEmit": true,
 "baseUrl": ".",
 "module": "esnext",
 "experimentalDecorators": true,
 "paths": {
 "dummy/tests/*": ["tests/*"],
Expand Down

2 changes: 0 additions & 2 deletions
packages/feedback/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",

 /* Preact Config */
 "jsx": "react-jsx",
 "jsxImportSource": "preact",
Expand Down

1 change: 0 additions & 1 deletion
packages/hono/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

1 change: 0 additions & 1 deletion
packages/integration-shims/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

2 changes: 0 additions & 2 deletions
packages/nextjs/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/nitro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

4 changes: 1 addition & 3 deletions
packages/node-core/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020", "ES2021.WeakRef"],
 "module": "Node16",
 "moduleResolution": "Node16"
 "lib": ["ES2020", "ES2021.WeakRef"]
 }
}

2 changes: 0 additions & 2 deletions
packages/node-native/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

8 changes: 1 addition & 7 deletions
packages/node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["es2020"],
 "module": "Node16",
 "moduleResolution": "Node16"
 }
 "include": ["src/**/*"]
}

2 changes: 0 additions & 2 deletions
packages/nuxt/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/profiling-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerAction.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerLoader.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "jsx": "react"
 }
}

2 changes: 0 additions & 2 deletions
packages/react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext",
 "moduleResolution": "bundler",
 // package-specific options
 "esModuleInterop": true,
 "jsx": "react"
Expand Down

4 changes: 1 addition & 3 deletions
packages/remix/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "jsx": "react",
 "module": "esnext",
 "moduleResolution": "bundler"
 "jsx": "react"
 }
}

3 changes: 1 addition & 2 deletions
packages/replay-canvas/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

3 changes: 1 addition & 2 deletions
packages/replay-internal/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

1 change: 0 additions & 1 deletion
packages/replay-worker/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["webworker", "scripthost"],
 "esModuleInterop": true,
 "target": "es2020",
Expand Down

6 changes: 1 addition & 5 deletions
packages/server-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020"]
 }
 "include": ["src/**/*"]
}

3 changes: 3 additions & 0 deletions
packages/solid/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
 // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
 // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
 }
}

5 changes: 1 addition & 4 deletions
packages/solidstart/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}

7 changes: 6 additions & 1 deletion
packages/svelte/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 "lib": ["DOM", "es2020"],
 // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
 // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
 // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
 "module": "esnext",
 "moduleResolution": "node"
 }
}

2 changes: 0 additions & 2 deletions
packages/sveltekit/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 // package-specific options
 }
}

5 changes: 1 addition & 4 deletions
packages/tanstackstart-react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
 "extends": "../../tsconfig.json",
 "include": ["src/**/*"],
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

mydea
wants to merge
12
commits into

from

 Closed


ref(typescript): Default to node16 module/moduleResolution
#21520
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
92f669c

move to node16 moduleResolution


mydea Jun 15, 2026
e64eea5

fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…


mydea Jun 15, 2026
54b7236

fix(angular): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
5a5b574

fix nx implicit dependency for typescript


mydea Jun 15, 2026
0e8b80d

fix test-utils module


mydea Jun 15, 2026
1e7b2f2

fix(solid): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
d7421e2

fix(angular): Inline tsconfig instead of extending the node16 base


mydea Jun 15, 2026
1c87dbe

fix tests


mydea Jun 15, 2026
638c02e

fix browser-integration-tests


mydea Jun 15, 2026
debf405

fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…


mydea Jun 15, 2026
6229192

fix(test): Drop module override for TS 3.8 instead of forcing esnext


mydea Jun 15, 2026
12113fc

ref(typescript): Default to esnext/bundler instead of node16


mydea Jun 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/browser-integration-tests/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

 "compilerOptions": {
 "lib": ["dom", "ES2020"],
 "moduleResolution": "node",
 "noEmit": true,
 "strict": true,
 "allowSyntheticDefaultImports": true,
Expand Down

7 changes: 7 additions & 0 deletions
dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

7 changes: 7 additions & 0 deletions
dev-packages/node-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

1 change: 0 additions & 1 deletion
dev-packages/test-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "target": "ES2022",
 "module": "ES2022",
 // package-specific options
 "esModuleInterop": true
 },
Expand Down

3 changes: 2 additions & 1 deletion
nx.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
 "{workspaceRoot}/*.js",
 "{workspaceRoot}/*.json",
 "{workspaceRoot}/yarn.lock",
 "{workspaceRoot}/dev-packages/rollup-utils/**"
 "{workspaceRoot}/dev-packages/rollup-utils/**",
 "{workspaceRoot}/packages/typescript/**"
 ],
 "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
 },
Expand Down

29 changes: 26 additions & 3 deletions
packages/angular/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
 "extends": "../../tsconfig.json",

 // NOTE: Unlike every other package, this config does NOT extend the shared base config
 // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
 // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
 // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
 // base compiler options here and use `esnext`/`node` instead.
 "include": ["**/*.ts", "src/**/*"],

 "exclude": ["patch-vitest.ts", "setup-test.ts"],

 "compilerOptions": {
 // package-specific options
 "declaration": false,
 "declarationMap": false,
 "downlevelIteration": true,
 "importHelpers": true,
 "inlineSources": true,
 "isolatedModules": true,
 "lib": ["es2020"],
 "module": "esnext",
 "moduleResolution": "node",
 "noErrorTruncation": true,
 "noFallthroughCasesInSwitch": true,
 "noImplicitReturns": true,
 "noUnusedLocals": false,
 "noUnusedParameters": false,
 "preserveWatchOutput": true,
 "sourceMap": true,
 "strict": true,
 "strictBindCallApply": false,
 "target": "es2020",
 "noUncheckedIndexedAccess": true,
 "skipLibCheck": true,
 "experimentalDecorators": true
 }
}

1 change: 0 additions & 1 deletion
packages/astro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

1 change: 0 additions & 1 deletion
packages/browser/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*", "test/loader.js"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "lib": ["DOM", "es2020", "WebWorker"]
 }
}

1 change: 0 additions & 1 deletion
packages/cloudflare/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

2 changes: 0 additions & 2 deletions
packages/core/tsconfig.types.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
 "extends": "./tsconfig.json",

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "declaration": true,
 "declarationMap": true,
 "emitDeclarationOnly": true,
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.build.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "compilerOptions": {
 "outDir": "build",
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext",
 "declaration": true,
 "declarationMap": false
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.test.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "test/**/*"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

2 changes: 0 additions & 2 deletions
packages/effect/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "outDir": "build"
 },
 "include": ["src/**/*"]
Expand Down

2 changes: 0 additions & 2 deletions
packages/ember/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
 "target": "es2022",
 "lib": ["DOM", "ES2022"],
 "allowJs": true,
 "moduleResolution": "bundler",
 "allowSyntheticDefaultImports": true,
 "alwaysStrict": true,
 "strictNullChecks": true,
 "strictPropertyInitialization": true,
 "noEmitOnError": false,
 "noEmit": true,
 "baseUrl": ".",
 "module": "esnext",
 "experimentalDecorators": true,
 "paths": {
 "dummy/tests/*": ["tests/*"],
Expand Down

2 changes: 0 additions & 2 deletions
packages/feedback/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",

 /* Preact Config */
 "jsx": "react-jsx",
 "jsxImportSource": "preact",
Expand Down

1 change: 0 additions & 1 deletion
packages/hono/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

1 change: 0 additions & 1 deletion
packages/integration-shims/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

2 changes: 0 additions & 2 deletions
packages/nextjs/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/nitro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

4 changes: 1 addition & 3 deletions
packages/node-core/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020", "ES2021.WeakRef"],
 "module": "Node16",
 "moduleResolution": "Node16"
 "lib": ["ES2020", "ES2021.WeakRef"]
 }
}

2 changes: 0 additions & 2 deletions
packages/node-native/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

8 changes: 1 addition & 7 deletions
packages/node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["es2020"],
 "module": "Node16",
 "moduleResolution": "Node16"
 }
 "include": ["src/**/*"]
}

2 changes: 0 additions & 2 deletions
packages/nuxt/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/profiling-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerAction.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerLoader.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "jsx": "react"
 }
}

2 changes: 0 additions & 2 deletions
packages/react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext",
 "moduleResolution": "bundler",
 // package-specific options
 "esModuleInterop": true,
 "jsx": "react"
Expand Down

4 changes: 1 addition & 3 deletions
packages/remix/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "jsx": "react",
 "module": "esnext",
 "moduleResolution": "bundler"
 "jsx": "react"
 }
}

3 changes: 1 addition & 2 deletions
packages/replay-canvas/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

3 changes: 1 addition & 2 deletions
packages/replay-internal/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

1 change: 0 additions & 1 deletion
packages/replay-worker/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["webworker", "scripthost"],
 "esModuleInterop": true,
 "target": "es2020",
Expand Down

6 changes: 1 addition & 5 deletions
packages/server-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020"]
 }
 "include": ["src/**/*"]
}

3 changes: 3 additions & 0 deletions
packages/solid/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
 // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
 // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
 }
}

5 changes: 1 addition & 4 deletions
packages/solidstart/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}

7 changes: 6 additions & 1 deletion
packages/svelte/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 "lib": ["DOM", "es2020"],
 // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
 // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
 // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
 "module": "esnext",
 "moduleResolution": "node"
 }
}

2 changes: 0 additions & 2 deletions
packages/sveltekit/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 // package-specific options
 }
}

5 changes: 1 addition & 4 deletions
packages/tanstackstart-react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
 "extends": "../../tsconfig.json",
 "include": ["src/**/*"],
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

mydea
wants to merge
12
commits into

from

 Closed


ref(typescript): Default to node16 module/moduleResolution
#21520
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
92f669c

move to node16 moduleResolution


mydea Jun 15, 2026
e64eea5

fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…


mydea Jun 15, 2026
54b7236

fix(angular): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
5a5b574

fix nx implicit dependency for typescript


mydea Jun 15, 2026
0e8b80d

fix test-utils module


mydea Jun 15, 2026
1e7b2f2

fix(solid): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
d7421e2

fix(angular): Inline tsconfig instead of extending the node16 base


mydea Jun 15, 2026
1c87dbe

fix tests


mydea Jun 15, 2026
638c02e

fix browser-integration-tests


mydea Jun 15, 2026
debf405

fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…


mydea Jun 15, 2026
6229192

fix(test): Drop module override for TS 3.8 instead of forcing esnext


mydea Jun 15, 2026
12113fc

ref(typescript): Default to esnext/bundler instead of node16


mydea Jun 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/browser-integration-tests/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

 "compilerOptions": {
 "lib": ["dom", "ES2020"],
 "moduleResolution": "node",
 "noEmit": true,
 "strict": true,
 "allowSyntheticDefaultImports": true,
Expand Down

7 changes: 7 additions & 0 deletions
dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

7 changes: 7 additions & 0 deletions
dev-packages/node-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

1 change: 0 additions & 1 deletion
dev-packages/test-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "target": "ES2022",
 "module": "ES2022",
 // package-specific options
 "esModuleInterop": true
 },
Expand Down

3 changes: 2 additions & 1 deletion
nx.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
 "{workspaceRoot}/*.js",
 "{workspaceRoot}/*.json",
 "{workspaceRoot}/yarn.lock",
 "{workspaceRoot}/dev-packages/rollup-utils/**"
 "{workspaceRoot}/dev-packages/rollup-utils/**",
 "{workspaceRoot}/packages/typescript/**"
 ],
 "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
 },
Expand Down

29 changes: 26 additions & 3 deletions
packages/angular/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
 "extends": "../../tsconfig.json",

 // NOTE: Unlike every other package, this config does NOT extend the shared base config
 // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
 // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
 // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
 // base compiler options here and use `esnext`/`node` instead.
 "include": ["**/*.ts", "src/**/*"],

 "exclude": ["patch-vitest.ts", "setup-test.ts"],

 "compilerOptions": {
 // package-specific options
 "declaration": false,
 "declarationMap": false,
 "downlevelIteration": true,
 "importHelpers": true,
 "inlineSources": true,
 "isolatedModules": true,
 "lib": ["es2020"],
 "module": "esnext",
 "moduleResolution": "node",
 "noErrorTruncation": true,
 "noFallthroughCasesInSwitch": true,
 "noImplicitReturns": true,
 "noUnusedLocals": false,
 "noUnusedParameters": false,
 "preserveWatchOutput": true,
 "sourceMap": true,
 "strict": true,
 "strictBindCallApply": false,
 "target": "es2020",
 "noUncheckedIndexedAccess": true,
 "skipLibCheck": true,
 "experimentalDecorators": true
 }
}

1 change: 0 additions & 1 deletion
packages/astro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

1 change: 0 additions & 1 deletion
packages/browser/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*", "test/loader.js"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "lib": ["DOM", "es2020", "WebWorker"]
 }
}

1 change: 0 additions & 1 deletion
packages/cloudflare/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

2 changes: 0 additions & 2 deletions
packages/core/tsconfig.types.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
 "extends": "./tsconfig.json",

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "declaration": true,
 "declarationMap": true,
 "emitDeclarationOnly": true,
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.build.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "compilerOptions": {
 "outDir": "build",
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext",
 "declaration": true,
 "declarationMap": false
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.test.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "test/**/*"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

2 changes: 0 additions & 2 deletions
packages/effect/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "outDir": "build"
 },
 "include": ["src/**/*"]
Expand Down

2 changes: 0 additions & 2 deletions
packages/ember/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
 "target": "es2022",
 "lib": ["DOM", "ES2022"],
 "allowJs": true,
 "moduleResolution": "bundler",
 "allowSyntheticDefaultImports": true,
 "alwaysStrict": true,
 "strictNullChecks": true,
 "strictPropertyInitialization": true,
 "noEmitOnError": false,
 "noEmit": true,
 "baseUrl": ".",
 "module": "esnext",
 "experimentalDecorators": true,
 "paths": {
 "dummy/tests/*": ["tests/*"],
Expand Down

2 changes: 0 additions & 2 deletions
packages/feedback/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",

 /* Preact Config */
 "jsx": "react-jsx",
 "jsxImportSource": "preact",
Expand Down

1 change: 0 additions & 1 deletion
packages/hono/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

1 change: 0 additions & 1 deletion
packages/integration-shims/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

2 changes: 0 additions & 2 deletions
packages/nextjs/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/nitro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

4 changes: 1 addition & 3 deletions
packages/node-core/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020", "ES2021.WeakRef"],
 "module": "Node16",
 "moduleResolution": "Node16"
 "lib": ["ES2020", "ES2021.WeakRef"]
 }
}

2 changes: 0 additions & 2 deletions
packages/node-native/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

8 changes: 1 addition & 7 deletions
packages/node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["es2020"],
 "module": "Node16",
 "moduleResolution": "Node16"
 }
 "include": ["src/**/*"]
}

2 changes: 0 additions & 2 deletions
packages/nuxt/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/profiling-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerAction.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerLoader.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "jsx": "react"
 }
}

2 changes: 0 additions & 2 deletions
packages/react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext",
 "moduleResolution": "bundler",
 // package-specific options
 "esModuleInterop": true,
 "jsx": "react"
Expand Down

4 changes: 1 addition & 3 deletions
packages/remix/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "jsx": "react",
 "module": "esnext",
 "moduleResolution": "bundler"
 "jsx": "react"
 }
}

3 changes: 1 addition & 2 deletions
packages/replay-canvas/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

3 changes: 1 addition & 2 deletions
packages/replay-internal/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

1 change: 0 additions & 1 deletion
packages/replay-worker/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["webworker", "scripthost"],
 "esModuleInterop": true,
 "target": "es2020",
Expand Down

6 changes: 1 addition & 5 deletions
packages/server-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020"]
 }
 "include": ["src/**/*"]
}

3 changes: 3 additions & 0 deletions
packages/solid/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
 // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
 // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
 }
}

5 changes: 1 addition & 4 deletions
packages/solidstart/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}

7 changes: 6 additions & 1 deletion
packages/svelte/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 "lib": ["DOM", "es2020"],
 // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
 // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
 // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
 "module": "esnext",
 "moduleResolution": "node"
 }
}

2 changes: 0 additions & 2 deletions
packages/sveltekit/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 // package-specific options
 }
}

5 changes: 1 addition & 4 deletions
packages/tanstackstart-react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
 "extends": "../../tsconfig.json",
 "include": ["src/**/*"],
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

mydea
wants to merge
12
commits into

from

 Closed


ref(typescript): Default to node16 module/moduleResolution
#21520
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
92f669c

move to node16 moduleResolution


mydea Jun 15, 2026
e64eea5

fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…


mydea Jun 15, 2026
54b7236

fix(angular): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
5a5b574

fix nx implicit dependency for typescript


mydea Jun 15, 2026
0e8b80d

fix test-utils module


mydea Jun 15, 2026
1e7b2f2

fix(solid): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
d7421e2

fix(angular): Inline tsconfig instead of extending the node16 base


mydea Jun 15, 2026
1c87dbe

fix tests


mydea Jun 15, 2026
638c02e

fix browser-integration-tests


mydea Jun 15, 2026
debf405

fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…


mydea Jun 15, 2026
6229192

fix(test): Drop module override for TS 3.8 instead of forcing esnext


mydea Jun 15, 2026
12113fc

ref(typescript): Default to esnext/bundler instead of node16


mydea Jun 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/browser-integration-tests/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

 "compilerOptions": {
 "lib": ["dom", "ES2020"],
 "moduleResolution": "node",
 "noEmit": true,
 "strict": true,
 "allowSyntheticDefaultImports": true,
Expand Down

7 changes: 7 additions & 0 deletions
dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

7 changes: 7 additions & 0 deletions
dev-packages/node-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

1 change: 0 additions & 1 deletion
dev-packages/test-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "target": "ES2022",
 "module": "ES2022",
 // package-specific options
 "esModuleInterop": true
 },
Expand Down

3 changes: 2 additions & 1 deletion
nx.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
 "{workspaceRoot}/*.js",
 "{workspaceRoot}/*.json",
 "{workspaceRoot}/yarn.lock",
 "{workspaceRoot}/dev-packages/rollup-utils/**"
 "{workspaceRoot}/dev-packages/rollup-utils/**",
 "{workspaceRoot}/packages/typescript/**"
 ],
 "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
 },
Expand Down

29 changes: 26 additions & 3 deletions
packages/angular/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
 "extends": "../../tsconfig.json",

 // NOTE: Unlike every other package, this config does NOT extend the shared base config
 // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
 // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
 // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
 // base compiler options here and use `esnext`/`node` instead.
 "include": ["**/*.ts", "src/**/*"],

 "exclude": ["patch-vitest.ts", "setup-test.ts"],

 "compilerOptions": {
 // package-specific options
 "declaration": false,
 "declarationMap": false,
 "downlevelIteration": true,
 "importHelpers": true,
 "inlineSources": true,
 "isolatedModules": true,
 "lib": ["es2020"],
 "module": "esnext",
 "moduleResolution": "node",
 "noErrorTruncation": true,
 "noFallthroughCasesInSwitch": true,
 "noImplicitReturns": true,
 "noUnusedLocals": false,
 "noUnusedParameters": false,
 "preserveWatchOutput": true,
 "sourceMap": true,
 "strict": true,
 "strictBindCallApply": false,
 "target": "es2020",
 "noUncheckedIndexedAccess": true,
 "skipLibCheck": true,
 "experimentalDecorators": true
 }
}

1 change: 0 additions & 1 deletion
packages/astro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

1 change: 0 additions & 1 deletion
packages/browser/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*", "test/loader.js"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "lib": ["DOM", "es2020", "WebWorker"]
 }
}

1 change: 0 additions & 1 deletion
packages/cloudflare/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

2 changes: 0 additions & 2 deletions
packages/core/tsconfig.types.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
 "extends": "./tsconfig.json",

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "declaration": true,
 "declarationMap": true,
 "emitDeclarationOnly": true,
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.build.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "compilerOptions": {
 "outDir": "build",
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext",
 "declaration": true,
 "declarationMap": false
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.test.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "test/**/*"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

2 changes: 0 additions & 2 deletions
packages/effect/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "outDir": "build"
 },
 "include": ["src/**/*"]
Expand Down

2 changes: 0 additions & 2 deletions
packages/ember/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
 "target": "es2022",
 "lib": ["DOM", "ES2022"],
 "allowJs": true,
 "moduleResolution": "bundler",
 "allowSyntheticDefaultImports": true,
 "alwaysStrict": true,
 "strictNullChecks": true,
 "strictPropertyInitialization": true,
 "noEmitOnError": false,
 "noEmit": true,
 "baseUrl": ".",
 "module": "esnext",
 "experimentalDecorators": true,
 "paths": {
 "dummy/tests/*": ["tests/*"],
Expand Down

2 changes: 0 additions & 2 deletions
packages/feedback/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",

 /* Preact Config */
 "jsx": "react-jsx",
 "jsxImportSource": "preact",
Expand Down

1 change: 0 additions & 1 deletion
packages/hono/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

1 change: 0 additions & 1 deletion
packages/integration-shims/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

2 changes: 0 additions & 2 deletions
packages/nextjs/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/nitro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

4 changes: 1 addition & 3 deletions
packages/node-core/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020", "ES2021.WeakRef"],
 "module": "Node16",
 "moduleResolution": "Node16"
 "lib": ["ES2020", "ES2021.WeakRef"]
 }
}

2 changes: 0 additions & 2 deletions
packages/node-native/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

8 changes: 1 addition & 7 deletions
packages/node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["es2020"],
 "module": "Node16",
 "moduleResolution": "Node16"
 }
 "include": ["src/**/*"]
}

2 changes: 0 additions & 2 deletions
packages/nuxt/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/profiling-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerAction.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerLoader.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "jsx": "react"
 }
}

2 changes: 0 additions & 2 deletions
packages/react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext",
 "moduleResolution": "bundler",
 // package-specific options
 "esModuleInterop": true,
 "jsx": "react"
Expand Down

4 changes: 1 addition & 3 deletions
packages/remix/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "jsx": "react",
 "module": "esnext",
 "moduleResolution": "bundler"
 "jsx": "react"
 }
}

3 changes: 1 addition & 2 deletions
packages/replay-canvas/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

3 changes: 1 addition & 2 deletions
packages/replay-internal/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

1 change: 0 additions & 1 deletion
packages/replay-worker/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["webworker", "scripthost"],
 "esModuleInterop": true,
 "target": "es2020",
Expand Down

6 changes: 1 addition & 5 deletions
packages/server-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020"]
 }
 "include": ["src/**/*"]
}

3 changes: 3 additions & 0 deletions
packages/solid/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
 // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
 // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
 }
}

5 changes: 1 addition & 4 deletions
packages/solidstart/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}

7 changes: 6 additions & 1 deletion
packages/svelte/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 "lib": ["DOM", "es2020"],
 // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
 // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
 // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
 "module": "esnext",
 "moduleResolution": "node"
 }
}

2 changes: 0 additions & 2 deletions
packages/sveltekit/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 // package-specific options
 }
}

5 changes: 1 addition & 4 deletions
packages/tanstackstart-react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
 "extends": "../../tsconfig.json",
 "include": ["src/**/*"],
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

mydea
wants to merge
12
commits into

from

 Closed


ref(typescript): Default to node16 module/moduleResolution
#21520
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
92f669c

move to node16 moduleResolution


mydea Jun 15, 2026
e64eea5

fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…


mydea Jun 15, 2026
54b7236

fix(angular): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
5a5b574

fix nx implicit dependency for typescript


mydea Jun 15, 2026
0e8b80d

fix test-utils module


mydea Jun 15, 2026
1e7b2f2

fix(solid): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
d7421e2

fix(angular): Inline tsconfig instead of extending the node16 base


mydea Jun 15, 2026
1c87dbe

fix tests


mydea Jun 15, 2026
638c02e

fix browser-integration-tests


mydea Jun 15, 2026
debf405

fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…


mydea Jun 15, 2026
6229192

fix(test): Drop module override for TS 3.8 instead of forcing esnext


mydea Jun 15, 2026
12113fc

ref(typescript): Default to esnext/bundler instead of node16


mydea Jun 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/browser-integration-tests/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

 "compilerOptions": {
 "lib": ["dom", "ES2020"],
 "moduleResolution": "node",
 "noEmit": true,
 "strict": true,
 "allowSyntheticDefaultImports": true,
Expand Down

7 changes: 7 additions & 0 deletions
dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

7 changes: 7 additions & 0 deletions
dev-packages/node-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

1 change: 0 additions & 1 deletion
dev-packages/test-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "target": "ES2022",
 "module": "ES2022",
 // package-specific options
 "esModuleInterop": true
 },
Expand Down

3 changes: 2 additions & 1 deletion
nx.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
 "{workspaceRoot}/*.js",
 "{workspaceRoot}/*.json",
 "{workspaceRoot}/yarn.lock",
 "{workspaceRoot}/dev-packages/rollup-utils/**"
 "{workspaceRoot}/dev-packages/rollup-utils/**",
 "{workspaceRoot}/packages/typescript/**"
 ],
 "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
 },
Expand Down

29 changes: 26 additions & 3 deletions
packages/angular/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
 "extends": "../../tsconfig.json",

 // NOTE: Unlike every other package, this config does NOT extend the shared base config
 // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
 // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
 // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
 // base compiler options here and use `esnext`/`node` instead.
 "include": ["**/*.ts", "src/**/*"],

 "exclude": ["patch-vitest.ts", "setup-test.ts"],

 "compilerOptions": {
 // package-specific options
 "declaration": false,
 "declarationMap": false,
 "downlevelIteration": true,
 "importHelpers": true,
 "inlineSources": true,
 "isolatedModules": true,
 "lib": ["es2020"],
 "module": "esnext",
 "moduleResolution": "node",
 "noErrorTruncation": true,
 "noFallthroughCasesInSwitch": true,
 "noImplicitReturns": true,
 "noUnusedLocals": false,
 "noUnusedParameters": false,
 "preserveWatchOutput": true,
 "sourceMap": true,
 "strict": true,
 "strictBindCallApply": false,
 "target": "es2020",
 "noUncheckedIndexedAccess": true,
 "skipLibCheck": true,
 "experimentalDecorators": true
 }
}

1 change: 0 additions & 1 deletion
packages/astro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

1 change: 0 additions & 1 deletion
packages/browser/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*", "test/loader.js"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "lib": ["DOM", "es2020", "WebWorker"]
 }
}

1 change: 0 additions & 1 deletion
packages/cloudflare/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

2 changes: 0 additions & 2 deletions
packages/core/tsconfig.types.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
 "extends": "./tsconfig.json",

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "declaration": true,
 "declarationMap": true,
 "emitDeclarationOnly": true,
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.build.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "compilerOptions": {
 "outDir": "build",
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext",
 "declaration": true,
 "declarationMap": false
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.test.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "test/**/*"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

2 changes: 0 additions & 2 deletions
packages/effect/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "outDir": "build"
 },
 "include": ["src/**/*"]
Expand Down

2 changes: 0 additions & 2 deletions
packages/ember/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
 "target": "es2022",
 "lib": ["DOM", "ES2022"],
 "allowJs": true,
 "moduleResolution": "bundler",
 "allowSyntheticDefaultImports": true,
 "alwaysStrict": true,
 "strictNullChecks": true,
 "strictPropertyInitialization": true,
 "noEmitOnError": false,
 "noEmit": true,
 "baseUrl": ".",
 "module": "esnext",
 "experimentalDecorators": true,
 "paths": {
 "dummy/tests/*": ["tests/*"],
Expand Down

2 changes: 0 additions & 2 deletions
packages/feedback/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",

 /* Preact Config */
 "jsx": "react-jsx",
 "jsxImportSource": "preact",
Expand Down

1 change: 0 additions & 1 deletion
packages/hono/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

1 change: 0 additions & 1 deletion
packages/integration-shims/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

2 changes: 0 additions & 2 deletions
packages/nextjs/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/nitro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

4 changes: 1 addition & 3 deletions
packages/node-core/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020", "ES2021.WeakRef"],
 "module": "Node16",
 "moduleResolution": "Node16"
 "lib": ["ES2020", "ES2021.WeakRef"]
 }
}

2 changes: 0 additions & 2 deletions
packages/node-native/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

8 changes: 1 addition & 7 deletions
packages/node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["es2020"],
 "module": "Node16",
 "moduleResolution": "Node16"
 }
 "include": ["src/**/*"]
}

2 changes: 0 additions & 2 deletions
packages/nuxt/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/profiling-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerAction.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerLoader.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "jsx": "react"
 }
}

2 changes: 0 additions & 2 deletions
packages/react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext",
 "moduleResolution": "bundler",
 // package-specific options
 "esModuleInterop": true,
 "jsx": "react"
Expand Down

4 changes: 1 addition & 3 deletions
packages/remix/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "jsx": "react",
 "module": "esnext",
 "moduleResolution": "bundler"
 "jsx": "react"
 }
}

3 changes: 1 addition & 2 deletions
packages/replay-canvas/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

3 changes: 1 addition & 2 deletions
packages/replay-internal/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

1 change: 0 additions & 1 deletion
packages/replay-worker/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["webworker", "scripthost"],
 "esModuleInterop": true,
 "target": "es2020",
Expand Down

6 changes: 1 addition & 5 deletions
packages/server-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020"]
 }
 "include": ["src/**/*"]
}

3 changes: 3 additions & 0 deletions
packages/solid/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
 // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
 // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
 }
}

5 changes: 1 addition & 4 deletions
packages/solidstart/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}

7 changes: 6 additions & 1 deletion
packages/svelte/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 "lib": ["DOM", "es2020"],
 // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
 // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
 // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
 "module": "esnext",
 "moduleResolution": "node"
 }
}

2 changes: 0 additions & 2 deletions
packages/sveltekit/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 // package-specific options
 }
}

5 changes: 1 addition & 4 deletions
packages/tanstackstart-react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
 "extends": "../../tsconfig.json",
 "include": ["src/**/*"],
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}
Loading
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ref(typescript): Default to node16 module/moduleResolution#21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

mydea
wants to merge
12
commits into

from

 Closed


ref(typescript): Default to node16 module/moduleResolution
#21520
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
92f669c

move to node16 moduleResolution


mydea Jun 15, 2026
e64eea5

fix(svelte): Keep legacy node moduleResolution for Svelte 3 deep type…


mydea Jun 15, 2026
54b7236

fix(angular): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
5a5b574

fix nx implicit dependency for typescript


mydea Jun 15, 2026
0e8b80d

fix test-utils module


mydea Jun 15, 2026
1e7b2f2

fix(solid): Use esnext/bundler instead of node16 default


mydea Jun 15, 2026
d7421e2

fix(angular): Inline tsconfig instead of extending the node16 base


mydea Jun 15, 2026
1c87dbe

fix tests


mydea Jun 15, 2026
638c02e

fix browser-integration-tests


mydea Jun 15, 2026
debf405

fix(test): Downgrade module/moduleResolution for TS 3.8 integration t…


mydea Jun 15, 2026
6229192

fix(test): Drop module override for TS 3.8 instead of forcing esnext


mydea Jun 15, 2026
12113fc

ref(typescript): Default to esnext/bundler instead of node16


mydea Jun 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
dev-packages/browser-integration-tests/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@

 "compilerOptions": {
 "lib": ["dom", "ES2020"],
 "moduleResolution": "node",
 "noEmit": true,
 "strict": true,
 "allowSyntheticDefaultImports": true,
Expand Down

7 changes: 7 additions & 0 deletions
dev-packages/node-core-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

7 changes: 7 additions & 0 deletions
dev-packages/node-integration-tests/scripts/use-ts-3_8.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,4 +36,11 @@ const tsConfig = require(baseTscConfigPath);
// TS 3.8 fails build when it encounters a config option it does not understand, so we remove it :(
delete tsConfig.compilerOptions.noUncheckedIndexedAccess;

// TS 3.8 predates `node16` module/moduleResolution (added in TS 4.7). Restore the pre-`node16`
// base shape: drop `module` (so ts-node, which runs the scenarios, keeps emitting CommonJS) and
// use plain `node` resolution. Setting `module` to an ESM value here breaks the `ts-node/register`
// scenarios, which are loaded as CommonJS.
delete tsConfig.compilerOptions.module;
tsConfig.compilerOptions.moduleResolution = 'node';

writeFileSync(baseTscConfigPath, JSON.stringify(tsConfig, null, 2));

1 change: 0 additions & 1 deletion
dev-packages/test-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "target": "ES2022",
 "module": "ES2022",
 // package-specific options
 "esModuleInterop": true
 },
Expand Down

3 changes: 2 additions & 1 deletion
nx.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,8 @@
 "{workspaceRoot}/*.js",
 "{workspaceRoot}/*.json",
 "{workspaceRoot}/yarn.lock",
 "{workspaceRoot}/dev-packages/rollup-utils/**"
 "{workspaceRoot}/dev-packages/rollup-utils/**",
 "{workspaceRoot}/packages/typescript/**"
 ],
 "production": ["default", "!{projectRoot}/test/**/*", "!{projectRoot}/**/*.md", "!{projectRoot}/*.tgz"]
 },
Expand Down

29 changes: 26 additions & 3 deletions
packages/angular/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,12 +1,35 @@
{
 "extends": "../../tsconfig.json",

 // NOTE: Unlike every other package, this config does NOT extend the shared base config
 // (`../../tsconfig.json`). `@sentry/angular` is built with `ng-packagr`, which pins an older
 // TypeScript (4.6) that doesn't understand the `node16` module/moduleResolution our base config
 // defaults to (and rejects the literal even when overridden). We therefore inline the relevant
 // base compiler options here and use `esnext`/`node` instead.
 "include": ["**/*.ts", "src/**/*"],

 "exclude": ["patch-vitest.ts", "setup-test.ts"],

 "compilerOptions": {
 // package-specific options
 "declaration": false,
 "declarationMap": false,
 "downlevelIteration": true,
 "importHelpers": true,
 "inlineSources": true,
 "isolatedModules": true,
 "lib": ["es2020"],
 "module": "esnext",
 "moduleResolution": "node",
 "noErrorTruncation": true,
 "noFallthroughCasesInSwitch": true,
 "noImplicitReturns": true,
 "noUnusedLocals": false,
 "noUnusedParameters": false,
 "preserveWatchOutput": true,
 "sourceMap": true,
 "strict": true,
 "strictBindCallApply": false,
 "target": "es2020",
 "noUncheckedIndexedAccess": true,
 "skipLibCheck": true,
 "experimentalDecorators": true
 }
}

1 change: 0 additions & 1 deletion
packages/astro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

1 change: 0 additions & 1 deletion
packages/browser/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*", "test/loader.js"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "lib": ["DOM", "es2020", "WebWorker"]
 }
}

1 change: 0 additions & 1 deletion
packages/cloudflare/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

2 changes: 0 additions & 2 deletions
packages/core/tsconfig.types.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2,8 +2,6 @@
 "extends": "./tsconfig.json",

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "declaration": true,
 "declarationMap": true,
 "emitDeclarationOnly": true,
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.build.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "compilerOptions": {
 "outDir": "build",
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext",
 "declaration": true,
 "declarationMap": false
Expand Down

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "src/**/*", "example.ts"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

1 change: 0 additions & 1 deletion
packages/deno/tsconfig.test.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,6 @@
 "include": ["./lib.deno.d.ts", "test/**/*"],
 "compilerOptions": {
 "lib": ["esnext"],
 "module": "esnext",
 "target": "esnext"
 }
}

2 changes: 0 additions & 2 deletions
packages/effect/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler",
 "outDir": "build"
 },
 "include": ["src/**/*"]
Expand Down

2 changes: 0 additions & 2 deletions
packages/ember/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,15 +4,13 @@
 "target": "es2022",
 "lib": ["DOM", "ES2022"],
 "allowJs": true,
 "moduleResolution": "bundler",
 "allowSyntheticDefaultImports": true,
 "alwaysStrict": true,
 "strictNullChecks": true,
 "strictPropertyInitialization": true,
 "noEmitOnError": false,
 "noEmit": true,
 "baseUrl": ".",
 "module": "esnext",
 "experimentalDecorators": true,
 "paths": {
 "dummy/tests/*": ["tests/*"],
Expand Down

2 changes: 0 additions & 2 deletions
packages/feedback/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",

 /* Preact Config */
 "jsx": "react-jsx",
 "jsxImportSource": "preact",
Expand Down

1 change: 0 additions & 1 deletion
packages/hono/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "types": ["node", "@cloudflare/workers-types"]
 }
}

1 change: 0 additions & 1 deletion
packages/integration-shims/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler"
 // package-specific options
 }
}

2 changes: 0 additions & 2 deletions
packages/nextjs/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/nitro/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

4 changes: 1 addition & 3 deletions
packages/node-core/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020", "ES2021.WeakRef"],
 "module": "Node16",
 "moduleResolution": "Node16"
 "lib": ["ES2020", "ES2021.WeakRef"]
 }
}

2 changes: 0 additions & 2 deletions
packages/node-native/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

8 changes: 1 addition & 7 deletions
packages/node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["es2020"],
 "module": "Node16",
 "moduleResolution": "Node16"
 }
 "include": ["src/**/*"]
}

2 changes: 0 additions & 2 deletions
packages/nuxt/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,7 +5,5 @@

 "compilerOptions": {
 // package-specific options
 "module": "esnext",
 "moduleResolution": "bundler"
 }
}

2 changes: 0 additions & 2 deletions
packages/profiling-node/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["es2020"],
 "outDir": "build",
 "types": ["node"]
 },
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerAction.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerAction', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerAction: freshWrapServerAction } = await import('../../src/server/wrapServerAction');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/test/server/wrapServerLoader.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,7 +120,6 @@ describe('wrapServerLoader', () => {
 it('should skip span creation and warn when instrumentation API is used', async () => {
 // Reset modules to get a fresh copy with unset warning flag
 vi.resetModules();
 // @ts-expect-error - Dynamic import for module reset works at runtime but vitest's typecheck doesn't fully support it
 const { wrapServerLoader: freshWrapServerLoader } = await import('../../src/server/wrapServerLoader');

 // Set the global flag indicating instrumentation API is in use
Expand Down

1 change: 0 additions & 1 deletion
packages/react-router/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "moduleResolution": "bundler",
 "jsx": "react"
 }
}

2 changes: 0 additions & 2 deletions
packages/react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext",
 "moduleResolution": "bundler",
 // package-specific options
 "esModuleInterop": true,
 "jsx": "react"
Expand Down

4 changes: 1 addition & 3 deletions
packages/remix/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "jsx": "react",
 "module": "esnext",
 "moduleResolution": "bundler"
 "jsx": "react"
 }
}

3 changes: 1 addition & 2 deletions
packages/replay-canvas/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

3 changes: 1 addition & 2 deletions
packages/replay-internal/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "lib": ["DOM", "es2020"],
 "module": "esnext"
 "lib": ["DOM", "es2020"]
 },
 "include": ["src/**/*.ts"]
}

1 change: 0 additions & 1 deletion
packages/replay-worker/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
{
 "extends": "../../tsconfig.json",
 "compilerOptions": {
 "module": "esnext",
 "lib": ["webworker", "scripthost"],
 "esModuleInterop": true,
 "target": "es2020",
Expand Down

6 changes: 1 addition & 5 deletions
packages/server-utils/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
{
 "extends": "../../tsconfig.json",

 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["ES2020"]
 }
 "include": ["src/**/*"]
}

3 changes: 3 additions & 0 deletions
packages/solid/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,5 +5,8 @@

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 // This package imports ESM-only deps (`solid-js`); under `node16` resolution a CommonJS file
 // can't `require` those (TS1479/TS1541). Like our other framework packages it's compiled via a
 // bundler, so use `esnext`/`bundler` here instead of the `node16` default.
 }
}

5 changes: 1 addition & 4 deletions
packages/solidstart/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,5 @@

 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}

7 changes: 6 additions & 1 deletion
packages/svelte/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,11 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "lib": ["DOM", "es2020"]
 "lib": ["DOM", "es2020"],
 // We still support Svelte 3, which imports types from deep paths (e.g. `svelte/types/compiler/preprocess`)
 // that aren't declared in Svelte's `exports` map. `node16` resolution honors that map and rejects them,
 // so we keep the legacy `node` resolver here, which resolves them via filesystem lookup.
 "module": "esnext",
 "moduleResolution": "node"
 }
}

2 changes: 0 additions & 2 deletions
packages/sveltekit/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,6 @@
 "include": ["src/**/*"],

 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 // package-specific options
 }
}

5 changes: 1 addition & 4 deletions
packages/tanstackstart-react/tsconfig.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
{
 "extends": "../../tsconfig.json",
 "include": ["src/**/*"],
 "compilerOptions": {
 "module": "esnext",
 "moduleResolution": "bundler"
 }
 "compilerOptions": {}
}
Loading
Loading