Uh oh!
There was an error while loading. Please reload this page.
ref(node): Streamline ioredis instrumentation - #21560
Merged
logaretm merged 1 commit intoJun 15, 2026
Merged
Conversation
Streamlines the vendored `ioredis` instrumentation to use Sentry's span APIs instead of the OpenTelemetry tracing API, and removes the code paths that are dead in Sentry's context. Mirrors the approach in #21481 (mongoose) and #21509 (mysql2). ### Notes #### Blockers for `startSpan*` ioredis ends its span manually since completion fires via the patched `cmd.resolve`/`cmd.reject` (and the `connect` promise) after the sync wrapper returns, which `startSpan`'s auto-end misses. `startInactiveSpan` leaves the return value untouched (no thenable probing). #### Semantic Conventions Attributes Dropping the `OTEL_SEMCONV_STABILITY_OPT_IN` path means ioredis spans now **always** emit the legacy semantic-convention attributes (`db.system`, `db.statement`, `db.connection_string`, `net.peer.*`). Modernizing the semconv is deferred as a separate, breaking change.
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
June 15, 2026 20:07
logaretm
requested review from
JPeer264, andreiborza, mydea and nicohrubec
and removed request for
a teamJune 15, 2026 20:07
Uh oh!
There was an error while loading. Please reload this page.
andreiborza
approved these changes
Jun 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
logaretm
deleted the
awad/js-2383-streamline-opentelemetryinstrumentation-ioredis
branch
June 15, 2026 20:42
logaretm added a commit
that referenced
this pull request
Jun 17, 2026
Streamlines the vendored `redis` (node-redis) instrumentation to use Sentry's span APIs instead of the OpenTelemetry tracing APIs, following the ioredis precedent (#21560). - Replace `tracer.startSpan`/`context.with(trace.setSpan(...))` with `startInactiveSpan`/`withActiveSpan`, `SpanStatusCode.ERROR` with `SPAN_STATUS_ERROR`, and drop `recordException` (a no-op in Sentry's pipeline) across all three classes. - Drop the `SemconvStability` dual-emission and keep the OLD semconv attributes only (the STABLE path was env-gated behind `OTEL_SEMCONV_STABILITY_OPT_IN` and never enabled by the SDK). - Remove dead config the SDK never passes (`dbStatementSerializer`, `requireParentSpan`, `semconvStability`) and the now-dead `isPipeline` plumbing; bake the origin into the attributes. - Drop the blanket eslint-disable and rely on the consolidated path entry. Also splits the node-redis test version aliases so every code path is covered: `redis-5` now pins 5.11.0 (vendored monkey-patch, >=5.0.0 <5.12.0) and the new `redis-5-tracing` pins >=5.12.0 (diagnostics_channel). Adds a node-redis error-path assertion and a redis-5 cache suite.
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored
ioredisinstrumentation to use Sentry's span APIs instead of the OpenTelemetry tracing APIs.I removed the fake tests, added test cases to the integration tests, and dropped any unreachable code.