Uh oh!
There was an error while loading. Please reload this page.
ref(node): Streamline tedious instrumentation - #21598
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
nicohrubecforce-pushed
the
nh/streamline-tedious
branch
from
June 17, 2026 10:24
dbb4939 to
281c54eComparenicohrubec
commented
Jun 17, 2026
| import { afterAll, describe, expect } from 'vitest'; | ||
| import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner'; | ||
| describe.skip('tedious auto instrumentation', { timeout: 75_000 }, () => { |
MemberAuthor
There was a problem hiding this comment.
this was a leftover skip from last year because this test used to be flaky
nicohrubecforce-pushed
the
nh/streamline-tedious
branch
from
June 17, 2026 10:33
281c54e to
fb7616aCompareMove vendored tedious span creation onto Sentry's span APIs (startInactiveSpan/withActiveSpan), fold the origin into creation, drop the spanStart hook + semconv-stability branching, and expand+un-skip the integration suite to cover all patched methods + the error path. Adds a getSpanName unit test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubecforce-pushed
the
nh/streamline-tedious
branch
from
June 17, 2026 10:46
fb7616a to
331bc72CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 331bc72. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
nicohrubec
marked this pull request as ready for review
June 17, 2026 11:20
nicohrubec
requested review from
JPeer264, andreiborza, logaretm and mydea
and removed request for
a teamJune 17, 2026 11:20
andreiborza
approved these changes
Jun 17, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 17, 2026
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored
tediousinstrumentation to use Sentry's span APIs instead of the OpenTelemetry tracing APIs, and removes the code paths that are dead in Sentry's context. Integration tests are expanded to cover all instrumented APIs.Uses
startInactiveSpansince the span ends manually via request/connection events after the sync wrapper returns, andwithActiveSpanto run the original method within the span's context. Theauto.db.otel.tediousorigin is folded into span creation, dropping thespanStart.Closes#20742