Uh oh!
There was an error while loading. Please reload this page.
feat: Adopt bindTracingChannelToSpan across runtimes - #21642
Merged
logaretm merged 6 commits intoJun 24, 2026
Conversation
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 18, 2026 17:56
e189fda to
3f71785CompareContributor
size-limit report 📦
|
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
2 times, most recently
from
June 19, 2026 01:18
8ec64f0 to
7a09a2eComparemydea
reviewed
Jun 19, 2026
| expect.objectContaining({ | ||
| handled: false, | ||
| type: 'auto.http.nitro.onTraceError', | ||
| type: 'auto.diagnostic_channels.bind_span', |
Member
There was a problem hiding this comment.
this is no good, this should be somewhat similar to what it was before 😬
MemberAuthor
There was a problem hiding this comment.
okay I can add an option for error mechanism to preserve this
logaretm
marked this pull request as ready for review
June 19, 2026 13:24
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 19, 2026 13:31
7a09a2e to
a11202fCompareUh oh!
There was an error while loading. Please reload this page.
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 19, 2026 13:57
d452bdb to
2d8060eCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 19, 2026 15:07
766b254 to
05cfa5bComparelogaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 22, 2026 17:08
05cfa5b to
5208656CompareJPeer264
approved these changes
Jun 23, 2026
Uh oh!
There was an error while loading. Please reload this page.
s1gr1d
reviewed
Jun 23, 2026
Uh oh!
There was an error while loading. Please reload this page.
s1gr1d
approved these changes
Jun 23, 2026
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
2 times, most recently
from
June 23, 2026 19:24
68ab8c1 to
b9a3ae4CompareUh oh!
There was an error while loading. Please reload this page.
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 23, 2026 20:11
b9a3ae4 to
757e9d1Comparelogaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 24, 2026 12:09
757e9d1 to
103ebc0CompareMigrate the Nitro HTTP/storage channels and the node/deno redis diagnostics_channel subscribers off the `@sentry/opentelemetry` `tracingChannel` helper onto `bindTracingChannelToSpan` from `@sentry/server-utils`, using the `auto` lifecycle. - Add `beforeSpanEnd(span, data)` to enrich the span on the canonical terminal event (sync `end` / async `asyncEnd`) right before it ends. - Add `captureError` (default `true`) to gate exception capture; the span error status is always set. Redis opts out (`captureError: false`) since command failures are captured at the boundary that owns them. - Unify the error mechanism to `auto.diagnostic_channels.bind_span`. - Create channel spans with `startInactiveSpan`; the binding activates the span as the async context, so parenting is preserved. - node and deno redis now pass the native `node:diagnostics_channel` `tracingChannel` directly; deno's bespoke factory is removed. BREAKING: remove the `@sentry/opentelemetry/tracing-channel` subpath export (shipped in 10.58.0); use `bindTracingChannelToSpan` instead.
Addresses review nit: tighten the bare toHaveBeenCalledWith assertions to also verify the hook isn't invoked more than once. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Follows the base-branch collapse of the binding API to a single bindTracingChannelToSpan. Updates the redis and Nitro consumers to the new name. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment on lines
71
to
+80
| 'db.collection.name': mountBase(data), | ||
| 'db.system.name': data.driver?.name ?? 'unknown', | ||
| }, | ||
| }, | ||
| span => span, | ||
| ); | ||
| }); | ||
| channel.subscribe({ | ||
| asyncEnd(data: TracingChannelContextWithSpan<TraceContext & { result?: unknown }>) { | ||
| if (data._sentrySpan && CACHE_HIT_OPERATIONS.has(operation)) { | ||
| const hit = operation === 'hasItem' ? Boolean(data.result) : isCacheHit(data.keys?.[0], data.result); | ||
| data._sentrySpan.setAttribute(SEMANTIC_ATTRIBUTE_CACHE_HIT, hit); | ||
| } | ||
| data._sentrySpan?.setStatus({ code: SPAN_STATUS_OK }); | ||
| data._sentrySpan?.end(); | ||
| void flushIfServerless(); | ||
| }, | ||
| error(data: TracingChannelContextWithSpan<TraceContext & { error?: unknown }>) { | ||
| captureException(data.error, { | ||
| mechanism: { handled: false, type: ORIGIN }, | ||
| }); | ||
| data._sentrySpan?.setStatus({ code: SPAN_STATUS_ERROR, message: 'internal_error' }); | ||
| data._sentrySpan?.end(); | ||
| void flushIfServerless(); | ||
| }, | ||
| }); | ||
| { | ||
| beforeSpanEnd(span, data) { | ||
| // Auto-capture + error status is handled by the binding; only enrich the success path. | ||
| if (!('error' in data)) { | ||
| const result = (data as { result?: unknown }).result; |
Contributor
There was a problem hiding this comment.
Bug: The refactoring to bindTracingChannelToSpan for storage events unintentionally changes the error mechanism type, losing the specific 'auto.cache.nitro' context.
Severity: LOW
Suggested Fix
Preserve the original error mechanism type for storage events by providing a custom captureError function when calling bindTracingChannelToSpan, similar to how HTTP events are handled. This function should return a mechanism object with the type set to 'auto.cache.nitro'. For example: captureError: () => ({ mechanism: { handled: false, type: 'auto.cache.nitro' } }).
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/nitro/src/runtime/hooks/captureStorageEvents.ts#L71-L80
Potential issue: During the migration to `bindTracingChannelToSpan`, the error capturing
for storage events was changed to use the default mechanism. This results in errors
being reported with a generic mechanism type of `'auto.diagnostic_channels.bind_span'`
instead of the previous, more specific `'auto.cache.nitro'`. This is inconsistent with
the handling of HTTP events in the same file, which explicitly preserve their custom
mechanism type. This change can negatively affect error grouping and filtering in
Sentry, making it harder to track and analyze storage-related failures.
Did we get this right? 👍 / 👎 to inform future reviews.
An unset span status already serializes to 'ok' for streamed spans, so setting it explicitly on the cache success path was redundant. Also correct the stale comment: with captureError defaulting to false, the binding only sets error status; the error is captured at the request boundary, not on cache ops.
logaretmforce-pushed
the
awad/adopt-bind-tracing-channel
branch
from
June 24, 2026 12:23
103ebc0 to
bee3c83CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bee3c83. Configure here.
| error: onTraceError, | ||
| }); | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Srvx trace errors not captured
Medium Severity
The srvx.request and srvx.middleware bindings no longer pass captureError to bindTracingChannelToSpan, so tracing-channel failures only update span status. Previously both channels used onTraceError, which called captureException with mechanism auto.http.nitro.onTraceError. The h3 channel still uses that pattern after review feedback; srvx does not, so srvx trace failures may no longer produce Sentry error events with the same mechanism as before.
Reviewed by Cursor Bugbot for commit bee3c83. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adopts
bindTracingChannelToSpanutility across our packages, and drops thetracingChannelhelper we had.The
tracingChanneldrop isn't a breaking change imo, its an internal export used by us exclusively.