ref(node): Remove unusued sql-common helper and `@opentelemetry/core` dep by andreiborza · Pull Request #21688 · getsentry/sentry-javascript

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza · 2026-06-22T12:01:34Z

The vendored addSqlCommenterComment helper (from @opentelemetry/sql-common) was never wired into any instrumentation. The pg integration explicitly dropped the addSqlCommenterCommentToQueries option in #21583, leaving it dead code whose only consumer is its own unit test.

It was also the sole user of W3CTraceContextPropagator, so we can drop the direct @opentelemetry/core dependency.

… dep The vendored `addSqlCommenterComment` helper (from `@opentelemetry/sql-common`) was never wired into any instrumentation. The `pg` integration explicitly dropped the `addSqlCommenterCommentToQueries` option in #21583, leaving it dead code whose only consumer is its own unit test. It was also the sole user of `W3CTraceContextPropagator`, so we can drop the direct `@opentelemetry/core` dependency.

andreiborza changed the title ~~ref(node): Remove unusued sql-common helper and @opentelemetry/coredep~~ref(node): Remove unusued sql-common helper and @opentelemetry/core depJun 22, 2026

andreiborza marked this pull request as ready for review June 22, 2026 12:45

andreiborza requested a review from a team as a code owner June 22, 2026 12:45

andreiborza requested review from JPeer264, mydea and nicohrubec and removed request for a teamJune 22, 2026 12:45

nicohrubec approved these changes Jun 22, 2026
View reviewed changes

andreiborza merged commit c5e245f into developJun 22, 2026
352 of 355 checks passed

andreiborza deleted the ab/remove-dead-sql-common branch June 22, 2026 12:50

sentry-release-botBot mentioned this pull request Jun 23, 2026
publish: getsentry/sentry-javascript@10.60.0 getsentry/publish#8652
Closed
49 tasks

nicohrubec mentioned this pull request Jul 15, 2026
Remove @opentelemetry/core dependency #21674
Closed
3 tasks