Uh oh!
There was an error while loading. Please reload this page.
ref(aws-serverless): Streamline AwsLambda instrumentation - #21758
Merged
Conversation
… e2e coverage Adds e2e cases for callback-style handlers (success + error) and trace continuation from incoming headers, covering paths the existing async-only suite missed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Create the Lambda span via the `@sentry/core` `startInactiveSpan` API (within the extracted parent context) instead of the OTel tracer, and fold the integration's `requestHook` (origin/op) and `responseHook` (captureException) directly into the instrumentation. `otel.kind: SERVER` is preserved via the `kind` option. Ref JS-2849 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
…gging Remove the vendored internal-types.ts (inline the one-line LambdaModule type) and replace OTel `diag` logging with Sentry's `debug` (gated on DEBUG_BUILD), dropping the `diag` import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…cate disableAwsContextPropagation The eventContextExtractor option was hardcoded and never user-overridable, so inline Sentry's extractor directly and remove the unreachable default extractor (and the now-unused headerGetter/propagation plumbing). Deprecate the disableAwsContextPropagation option, which has been a no-op, and drop its dead default in the instrument factory. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… v11 removal Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ation Replace the OTel propagation plumbing (propagation.extract + otelContext.with + trace.getSpan/ROOT_CONTEXT and the internal eventContextExtractor) with @sentry/core `continueTrace`, fed by `getAwsTraceData`. The Lambda span is now created inside `continueTrace`, continuing the incoming trace natively, and `_determineParent` is removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
commented
Jun 25, 2026
| * Sentry trace propagation to take precedence, but can | ||
| * be disabled if you want AWS propagation to take take | ||
| * precedence. | ||
| * @deprecated This option no longer does anything and will be removed in a future major version. |
MemberAuthor
There was a problem hiding this comment.
If I am not missing anything this option was already dead?
nicohrubec
marked this pull request as ready for review
June 25, 2026 08:07
nicohrubec
requested review from
JPeer264, andreiborza and mydea
and removed request for
a teamJune 25, 2026 08:07
Replace the magic kind number with the `SPAN_KIND` const from `@sentry/core`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
andreiborza
approved these changes
Jun 25, 2026
Uh oh!
There was an error while loading. Please reload this page.
…instrumentation Sentry does not use OTel metrics and the meter-provider force-flush was never documented, so remove the setMeterProvider override, _metricForceFlush, and the metrics flush in _endSpan. Trace force-flush is kept. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
andreiborza
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the AWS Lambda instrumentation:
requestHook(origin/op) andresponseHook(error capture) into the instrumentation, removing the hook config.startInactiveSpan/withActiveSpanfrom@sentry/coreinstead of the OTel tracer (span kind preserved via thekindoption).continueTracefrom@sentry/corefor incoming trace propagation instead of the OTel propagation primitives (propagation.extract/context.with).eventContextExtractorconfig and default extractor,internal-types.ts(inlinesLambdaModule), and the deaddisableAwsContextPropagationdefault (option deprecated for v11 removal).diaglogging to Sentry'sdebug.Closes#21746