Uh oh!
There was an error while loading. Please reload this page.
fix(core): Serialize streamed span status message to sentry.status.message attribute - #21811
Conversation
sentry.status.message attributesentry.status.message attributefbab8c3 to
c18bd3eComparesize-limit report 📦
|
sentry.status.message attributesentry.status.message attributeUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 33fa6af. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
33fa6af to
360ab29Compare| * message as an attribute instead of dropping it. This mirrors the attribute | ||
| * Sentry's OTLP ingestion uses for the same purpose. | ||
| */ | ||
| export const SEMANTIC_ATTRIBUTE_SENTRY_STATUS_MESSAGE = 'sentry.status.message'; |
There was a problem hiding this comment.
q: I know core doesn't have @sentry/conventions dependency yet, but just for the future we should probably import them from there.
There was a problem hiding this comment.
yup, we need to add conventions to core.
360ab29 to
118c27dCompareUh oh!
There was an error while loading. Please reload this page.

Fixes a semi-deliberate oversight (lol) from my end that caused span status messages to be discarded when creating a
StreamedSpanJSONfrom aSpaninstance. The deliberate part was to get rid of complicated statuses overall. The oversight was that there's a good use case to augment anerrorstatus span with a message: We sometimes want to record that an operation tracked by a span errored but explicitly not capture an error for it (since users likely try/catch said operation). Classic example isConnection Refusedfor databases.closes#21800