Skip to content

ref(core): Move spanStreamingIntegration setup into ServerRuntimeClient - #21814

Merged
Lms24 merged 1 commit into
developfrom
lms/ref-core-server-client-streaming-integration
Jun 29, 2026
Merged

ref(core): Move spanStreamingIntegration setup into ServerRuntimeClient#21814
Lms24 merged 1 commit into
developfrom
lms/ref-core-server-client-streaming-integration

Conversation

@Lms24

@Lms24Lms24 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Now that all our server runtime SDKs support span streaming (they didn't initially), we can move the per-SDK-init-based logic to add spanStreamingIntegration if traceLifecycle: 'stream' was set, to the ServerRuntimeClient.

This makes span streaming enabling more consistent for setups that only use a client. Also for SDKs like electron that init themselves with e.g. a NodeClient and therefore had to manually add the integration. h/t @timfish for raising this

@Lms24Lms24 self-assigned this Jun 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.47 kB--
@sentry/browser - with treeshaking flags25.91 kB--
@sentry/browser (incl. Tracing)45.97 kB--
@sentry/browser (incl. Tracing + Span Streaming)47.72 kB--
@sentry/browser (incl. Tracing, Profiling)50.76 kB--
@sentry/browser (incl. Tracing, Replay)85.22 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.81 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)89.91 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.57 kB--
@sentry/browser (incl. Feedback)44.66 kB--
@sentry/browser (incl. sendFeedback)32.26 kB--
@sentry/browser (incl. FeedbackAsync)37.4 kB--
@sentry/browser (incl. Metrics)28.54 kB--
@sentry/browser (incl. Logs)28.78 kB--
@sentry/browser (incl. Metrics & Logs)29.47 kB--
@sentry/react29.27 kB--
@sentry/react (incl. Tracing)48.28 kB--
@sentry/vue32.63 kB--
@sentry/vue (incl. Tracing)47.84 kB--
@sentry/svelte27.5 kB--
CDN Bundle29.89 kB--
CDN Bundle (incl. Tracing)47.89 kB--
CDN Bundle (incl. Logs, Metrics)31.44 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.24 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.78 kB--
CDN Bundle (incl. Tracing, Replay)85.4 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.68 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.19 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.45 kB--
CDN Bundle - uncompressed88.94 kB--
CDN Bundle (incl. Tracing) - uncompressed145.03 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed93.65 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.62 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.05 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed277.75 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed281.69 kB--
@sentry/nextjs (client)50.67 kB--
@sentry/sveltekit (client)46.37 kB--
@sentry/core/server77.58 kB+0.05%+35 B 🔺
@sentry/core/browser63.88 kB--
@sentry/node-core61.44 kB-0.12%-72 B 🔽
@sentry/node123.4 kB-0.07%-83 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.36 kB-0.08%-38 B 🔽
@sentry/node - without tracing73.47 kB-0.19%-136 B 🔽
@sentry/aws-serverless84.36 kB-0.05%-38 B 🔽
@sentry/cloudflare (withSentry) - minified180.33 kB+0.01%+18 B 🔺
@sentry/cloudflare (withSentry)446.19 kB-0.02%-47 B 🔽

View base workflow run

@Lms24
Lms24 marked this pull request as ready for review June 26, 2026 14:33
@Lms24
Lms24 requested a review from a team as a code ownerJune 26, 2026 14:33
@Lms24
Lms24 requested review from JPeer264, andreiborza, mydea and timfish and removed request for a teamJune 26, 2026 14:33
@Lms24
Lms24 merged commit 9730e11 into developJun 29, 2026
284 of 285 checks passed
@Lms24
Lms24 deleted the lms/ref-core-server-client-streaming-integration branch June 29, 2026 11:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@timfish