Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
services:
db:
image: mysql:8
restart: always
container_name: integration-tests-mysql2-dc
ports:
- '3308:3306'
environment:
MYSQL_ROOT_PASSWORD: password
healthcheck:
# `mysqladmin ping` reports "alive" even during MySQL's init bootstrap (it treats
# access-denied as alive), so `--wait` can return before the real server and root
# password are ready, and early connections get dropped ("server closed the
# connection"). Run an authenticated query instead so readiness gates on the real server.
test: ['CMD-SHELL', 'mysql -h 127.0.0.1 -uroot -ppassword -e "SELECT 1"']
interval: 2s
timeout: 3s
retries: 30
start_period: 10s
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
import * as Sentry from '@sentry/node';
import { loggingTransport } from '@sentry-internal/node-integration-tests';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
transport: loggingTransport,
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
import * as Sentry from '@sentry/node';
import mysql from 'mysql2/promise';

const CONNECT_CONFIG = {
user: 'root',
password: 'password',
host: 'localhost',
port: 3308,
};

// `docker compose up --wait` gates on the healthcheck, but MySQL keeps finalizing
// for a short window afterwards and drops early handshakes ("server closed the
// connection"). Retry the initial connect so the suite doesn't flake on that window.
// The connect happens outside an active span, so the subscriber leaves it
// uninstrumented and no connect transaction is emitted.
async function connectWithRetry(attempts = 15, delayMs = 500) {
let lastError;
for (let attempt = 0; attempt < attempts; attempt++) {
try {
return await mysql.createConnection(CONNECT_CONFIG);
} catch (error) {
lastError = error;
await new Promise(resolve => setTimeout(resolve, delayMs));
}
}

throw lastError;
}

async function run() {
// Yield a microtick so the DC subscriber (deferred via Promise.resolve().then)
// is registered before mysql2 publishes on its native TracingChannels.
await Promise.resolve();

const connection = await connectWithRetry();

await Sentry.startSpan(
{
op: 'transaction',
name: 'Test Transaction',
},
async () => {
await connection.query('SELECT 1 + 1 AS solution');
// A literal value, to assert it is redacted out of `db.query.text`.
await connection.query("SELECT 'super-secret' AS leaked");
Comment thread
isaacs marked this conversation as resolved.
// `execute` keeps `?` placeholders (prepared statements).
await connection.execute('SELECT ? AS answer', [42]);
// A failing query should produce a span with an error status.
await connection.query('SELECT * FROM does_not_exist').catch(() => {});
},
);

await connection.end();
}

run();
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
import { afterAll, expect } from 'vitest';
import { conditionalTest } from '../../../utils';
import { cleanupChildProcesses, createEsmAndCjsTests } from '../../../utils/runner';

// mysql2 >= 3.20.0 publishes its operations via `node:diagnostics_channel`, so the SDK subscribes
// to those channels (`subscribeMysql2DiagnosticChannels`) instead of monkey-patching. This suite
// pins `^3.20.0` and asserts the diagnostics-channel path: stable OTel DB semconv attributes,
// redacted query text, and that the legacy IITM patcher (gated to `< 3.20.0`) does NOT also fire.
// `TracingChannel` is only reliable on Node >= 20, so this suite is skipped on older Node.
conditionalTest({ min: 20 })('mysql2 tracing channel Test', () => {
afterAll(() => {
cleanupChildProcesses();
});

const expectedQuerySpan = (queryText: string) =>
expect.objectContaining({
description: queryText,
op: 'db',
origin: 'auto.db.mysql2.diagnostic_channel',
data: expect.objectContaining({
'sentry.origin': 'auto.db.mysql2.diagnostic_channel',
'db.system.name': 'mysql',
'db.operation.name': 'SELECT',
'db.query.text': queryText,
'server.address': 'localhost',
'server.port': 3308,
}),
});

const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: expect.arrayContaining([
expectedQuerySpan('SELECT ? + ? AS solution'),
// the inlined literal is redacted out of `db.query.text`
expectedQuerySpan('SELECT ? AS leaked'),
// `execute` keeps the `?` placeholder
expectedQuerySpan('SELECT ? AS answer'),
// a failing query produces a span with an error status
expect.objectContaining({
description: 'SELECT * FROM does_not_exist',
op: 'db',
status: 'internal_error',
origin: 'auto.db.mysql2.diagnostic_channel',
}),
Comment thread
cursor[bot] marked this conversation as resolved.
]),
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('subscribes to mysql2 >= 3.20.0 diagnostics channels with stable semconv attributes', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({ transaction: EXPECTED_TRANSACTION })
.start()
.completed();
Comment thread
cursor[bot] marked this conversation as resolved.
}, 30_000);

test('does not double-instrument: the legacy IITM mysql2 patcher does not fire on 3.20.0+', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
// The monkey-patch path (origin `auto.db.otel.mysql2`) must be inactive on 3.20.0+.
expect(spans.find(span => span.origin === 'auto.db.otel.mysql2')).toBeUndefined();
// ...while the diagnostics-channel path is active.
expect(spans.find(span => span.origin === 'auto.db.mysql2.diagnostic_channel')).toBeDefined();
},
})
.start()
.completed();
}, 30_000);

test('never leaks raw values into db.query.text', async () => {
await createTestRunner()
.withDockerCompose({ workingDirectory: [__dirname] })
.expect({
transaction: event => {
expect(event.transaction).toBe('Test Transaction');
const spans = event.spans || [];
for (const span of spans) {
const queryText = span.data?.['db.query.text'];
if (typeof queryText === 'string') {
expect(queryText).not.toContain('super-secret');
}
}
},
})
.start()
.completed();
}, 30_000);
},
{ additionalDependencies: { mysql2: '^3.20.0' } },
Comment thread
isaacs marked this conversation as resolved.
);
});
9 changes: 6 additions & 3 deletions packages/node/src/integrations/tracing/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
import { MySQL2Instrumentation } from './vendored/instrumentation';
import type { IntegrationFn } from '@sentry/core';
import { defineIntegration } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';
import { generateInstrumentOnce } from '@sentry/node-core';
import { mysql2Integration as mysql2ChannelIntegration } from '@sentry/server-utils';

const INTEGRATION_NAME = 'Mysql2' as const;

export const instrumentMysql2 = generateInstrumentOnce(INTEGRATION_NAME, () => new MySQL2Instrumentation());

const _mysql2Integration = (() => {
return {
// The diagnostics_channel subscription (mysql2 >= 3.20.0) lives in server-utils so it is shared
// across server runtimes; we extend it here to also run the vendored OTel patcher for mysql2 < 3.20.0.
return extendIntegration(mysql2ChannelIntegration(), {
name: INTEGRATION_NAME,
setupOnce() {
instrumentMysql2();
},
};
});
}) satisfies IntegrationFn;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,10 @@ import { getConnectionAttributes, getConnectionPrototypeToInstrument, getQueryTe
const PACKAGE_NAME = '@sentry/instrumentation-mysql2';
const ORIGIN = 'auto.db.otel.mysql2';

const supportedVersions = ['>=1.4.2 <4'];
// mysql2 >= 3.20.0 publishes via diagnostics_channel and is instrumented by
// `subscribeMysql2DiagnosticChannels` instead, so this IITM patcher must not
// overlap it — otherwise every query would emit two mysql2 spans.
const supportedVersions = ['>=1.4.2 <3.20.0'];
Comment thread
logaretm marked this conversation as resolved.

// The raw imported `mysql2` module exposes the `format` helper used to render
// parameterized queries. Typed shallowly since it is only read internally.
Expand Down
1 change: 1 addition & 0 deletions packages/server-utils/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@
*/

export { mongooseIntegration } from './mongoose';
export { mysql2Integration } from './mysql2';
Comment thread
sentry-warden[bot] marked this conversation as resolved.
export { redisIntegration, type RedisDiagnosticChannelsOptions } from './redis';
export type { RedisDiagnosticChannelResponseHook } from './redis/redis-dc-subscriber';
export { defaultDbStatementSerializer } from './redis/redis-statement-serializer';
Expand Down
30 changes: 30 additions & 0 deletions packages/server-utils/src/mysql2/index.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
import { defineIntegration, type IntegrationFn, waitForTracingChannelBinding } from '@sentry/core';
import * as dc from 'node:diagnostics_channel';
import { subscribeMysql2DiagnosticChannels } from './mysql2-dc-subscriber';

const _mysql2Integration = (() => {
return {
name: 'Mysql2',
setupOnce() {
// Bail on Node <= 18.18.0, where `tracingChannel` does not exist.
if (!dc.tracingChannel) {
return;
}

// Subscribe to mysql2's native tracing channels (mysql2 >= 3.20.0).
// This is a no-op on versions that don't publish to the channels, so it is always safe to call.
waitForTracingChannelBinding(() => {
subscribeMysql2DiagnosticChannels(dc.tracingChannel);
});
},
};
}) satisfies IntegrationFn;

/**
* Auto-instrument the [mysql2](https://www.npmjs.com/package/mysql2) library via its native
* `node:diagnostics_channel` tracing channels (mysql2 >= 3.20.0).
*
* On older mysql2 versions the channels are never published to, so this integration is inert and
* the vendored OTel instrumentation (gated to `< 3.20.0`) handles instrumentation instead.
*/
export const mysql2Integration = defineIntegration(_mysql2Integration);
Loading
Loading