Uh oh!
There was an error while loading. Please reload this page.
feat(bun): enable new mysql, pg integrations in 'bun build' - #21828
Conversation
e3cde9d to
f53b1bcComparesize-limit report 📦
|
JPeer264
left a comment
There was a problem hiding this comment.
nice changes. Could also be useful for Cloudflare I think
Uh oh!
There was an error while loading. Please reload this page.
f53b1bc to
17bb086Compare17bb086 to
caead8aCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aac5ba0 to
913c558CompareUh oh!
There was an error while loading. Please reload this page.
913c558 to
fe1c7bcCompareCheckpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fe1c7bc to
b6b244cCompareThe bun *plugin* was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected. Add a full end-to-end test verifying that a `bun build`-compiled application will instrument a mysql connection and emit spans for the queries being executed. When the orchestrion bundler marker is *not* present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway. Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with `bun build`, using the `@sentry/bun/plugin` plugin.
b6b244c to
d10e2fbCompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6300d38. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse CHANNEL_INTEGRATION_FACTORIES. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.
Add a full end-to-end test verifying that a
bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with
bun build, using the@sentry/bun/pluginplugin.