feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(bun): enable new mysql, pg integrations in 'bun build' - #21828

Merged
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument
Jul 2, 2026
Merged

feat(bun): enable new mysql, pg integrations in 'bun build'#21828
isaacs merged 4 commits into
developfrom
isaacs/fix-bun-orchestrion-actually-instrument

Conversation

@isaacs

Copy link
Copy Markdown
Member

The bun plugin was injecting the channels, and we had an integration test verifying that. However, it was not actually swapping out the (nonfunctional) OTel-based integrations with the orchestrion diagnostics-channel versions, meaning that the spans would not be emitted as expected.

Add a full end-to-end test verifying that a bun build-compiled application will instrument a mysql connection and emit spans for the queries being executed.

When the orchestrion bundler marker is not present, do not add the diagnostics-channel listeners, since they will not have anything to trigger them anyway.

Also, this means that as new diagnostics-channel-injection integrations are added, Bun will benefit from automatically loading those instrumentations, as long as the application is compiled with bun build, using the @sentry/bun/plugin plugin.

@isaacs
isaacs requested a review from a team as a code ownerJune 29, 2026 01:35
@isaacs
isaacs requested review from JPeer264, andreiborza and mydea and removed request for a teamJune 29, 2026 01:35
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from e3cde9d to f53b1bcCompareJune 29, 2026 01:36
@github-actions

github-actionsBot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.24 kB--
@sentry/browser (incl. Tracing + Span Streaming)48 kB--
@sentry/browser (incl. Tracing, Profiling)51.01 kB--
@sentry/browser (incl. Tracing, Replay)85.49 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.1 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.19 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.84 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.51 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.11 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.22 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.53 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.77 kB--
CDN Bundle (incl. Tracing, Replay)85.68 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.5 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.77 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed145.92 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed149.89 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.59 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed264.93 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed268.89 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.63 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.58 kB--
@sentry/nextjs (client)50.95 kB--
@sentry/sveltekit (client)46.65 kB--
@sentry/core/server78.28 kB--
@sentry/core/browser64.62 kB--
@sentry/node-core63.17 kB-0.01%-1 B 🔽
@sentry/node123.16 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.7 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.22 kB--
@sentry/aws-serverless85.01 kB--
@sentry/cloudflare (withSentry) - minified181.52 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. Could also be useful for Cloudflare I think

Comment threadpackages/server-utils/src/orchestrion/index.ts Outdated
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from f53b1bc to 17bb086CompareJuly 1, 2026 04:42
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 17bb086 to caead8aCompareJuly 2, 2026 03:38
@isaacs
isaacs requested a review from a team as a code ownerJuly 2, 2026 03:38
@isaacs
isaacs requested review from Lms24 and logaretm and removed request for a teamJuly 2, 2026 03:38
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch 3 times, most recently from aac5ba0 to 913c558CompareJuly 2, 2026 03:57
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from 913c558 to fe1c7bcCompareJuly 2, 2026 04:04
JPeer264 added a commit that referenced this pull request Jul 2, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Base automatically changed from isaacs/pg-orchestrion to developJuly 2, 2026 15:02
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from fe1c7bc to b6b244cCompareJuly 2, 2026 15:03
The bun *plugin* was injecting the channels, and we had an integration
test verifying that. However, it was not actually swapping out the
(nonfunctional) OTel-based integrations with the orchestrion
diagnostics-channel versions, meaning that the spans would not be
emitted as expected.
Add a full end-to-end test verifying that a `bun build`-compiled
application will instrument a mysql connection and emit spans for the
queries being executed.
When the orchestrion bundler marker is *not* present, do not add the
diagnostics-channel listeners, since they will not have anything to
trigger them anyway.
Also, this means that as new diagnostics-channel-injection integrations
are added, Bun will benefit from automatically loading those
instrumentations, as long as the application is compiled with `bun
build`, using the `@sentry/bun/plugin` plugin.
@isaacs
isaacsforce-pushed the isaacs/fix-bun-orchestrion-actually-instrument branch from b6b244c to d10e2fbCompareJuly 2, 2026 16:02

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6300d38. Configure here.

@isaacs
isaacs merged commit 15d656f into developJul 2, 2026
1973 of 1988 checks passed
@isaacs
isaacs deleted the isaacs/fix-bun-orchestrion-actually-instrument branch July 2, 2026 19:03
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 3, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 13, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JPeer264 added a commit that referenced this pull request Jul 14, 2026
Checkpoint before merging the bun/pg orchestrion work (#21828) to reuse
CHANNEL_INTEGRATION_FACTORIES.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@isaacs@JPeer264