Uh oh!
There was an error while loading. Please reload this page.
fix(opentelemetry): Strip leading ? and # from inferred http.query and http.fragment - #21848
Merged
Merged
Conversation
…d http.fragment The inferred `http.query` and `http.fragment` span attributes kept the leading `?`/`#` from `URL.search`/`URL.hash`, unlike the values the OTel SDK span exporter emits (`getData` in `spanExporter.ts` slices these off). Strip them so both code paths produce the same canonical attribute format. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
requested review from
JPeer264 and mydea
and removed request for
a teamJune 29, 2026 14:23
Lms24
approved these changes
Jun 29, 2026
Contributor
size-limit report 📦
|
JPeer264
approved these changes
Jun 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
Member
@andreiborza@Lms24 Just an FYI here that our conventions specify that this property contains a leading That said the ideal option is probably to deprecate |
MemberAuthor
@mjq thanks for raising this! I aligned this with our current span exporter, we can go for url.query in v11 but I'd rather not break existing users now. |
andreiborza added a commit
that referenced
this pull request
Jun 30, 2026
…ation (#21852) Adds `TODO(v11)` markers at the two spots that strip the leading `?`/`#` from `http.query`/`http.fragment` — the span exporter's `getData` and `parseSpanDescription`'s `descriptionForHttpMethod`. Per the [discussion on #21848](#21848 (comment)), `http.query` is specced to *keep* the leading `?`, so the stripping diverges from our own conventions. The v11 direction is to emit the OTel-standard `url.query`/`url.fragment` (no leading char, already in `@sentry/conventions`) and drop `http.query`/`http.fragment`. Comment-only, no behavior change. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strip the leading
?/#from the inferredhttp.queryandhttp.fragmentspan attributes indescriptionForHttpMethod.Why
The inferred values were taken straight from
URL.search/URL.hash, which include the leading?/#. The OTel SDK span exporter (getDatainspanExporter.ts) slices these off, so the same logical attribute ended up in two different formats depending on the code path. Stripping the prefix here makes both paths emit the same canonical format.