Uh oh!
There was an error while loading. Please reload this page.
ref(core): Add @sentry/conventions to @sentry/core and align versions - #21855
Merged
Conversation
Lms24
requested review from
JPeer264, andreiborza, chargome, mydea and nicohrubec
and removed request for
a teamJune 30, 2026 08:38
| @@ -138,7 +139,7 @@ export function getDynamicSamplingContextFromSpan(span: Span): Readonly<Partial< | |||
| // We don't want to have a transaction name in the DSC if the source is "url" because URLs might contain PII | |||
| // TODO(v11): Only read `SEMANTIC_ATTRIBUTE_SENTRY_SOURCE` again, once we renamed it to `sentry.span.source` | |||
MemberAuthor
There was a problem hiding this comment.
This sounded really confusing, thanks for calling it out! I reworded it. We'll need to remove SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, so the comment should reflect it
Contributor
size-limit report 📦
|
nicohrubec
approved these changes
Jun 30, 2026
andreiborza
approved these changes
Jun 30, 2026
chargome
approved these changes
Jun 30, 2026
| preset: 'es2015', | ||
| }, | ||
| hoistTransitiveImports: false, |
MemberAuthor
There was a problem hiding this comment.
argh no, this shouldn't be part of the PR. My mistake. Thanks for flagging!
Member
There was a problem hiding this comment.
But this comment is still valid. I'll add a comment here
Lms24force-pushed
the
lms/ref-deps-sentry-conventions-in-core
branch
from
June 30, 2026 14:07
3f1b5ba to
b6640bcCompareLms24
commented
Jul 1, 2026
MemberAuthor
Before we can merge this, we need to merge getsentry/sentry-conventions#459 and release conventions again, then bump to that version in the SDK. |
JPeer264
approved these changes
Jul 1, 2026
JPeer264 added a commit
that referenced
this pull request
Jul 1, 2026
Lms24force-pushed
the
lms/ref-deps-sentry-conventions-in-core
branch
3 times, most recently
from
July 1, 2026 15:26
3fb0522 to
cee1162CompareLms24force-pushed
the
lms/ref-deps-sentry-conventions-in-core
branch
from
July 1, 2026 17:14
cee1162 to
af6a221CompareUh oh!
There was an error while loading. Please reload this page.
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
@sentry/conventionspackage to core and bumps it everywhere to the latest 0.15.1 version. To make use of the new dependency, this also replaces thesentry.span.sourceconstant with the new convention-based export.We should replace our usage of our own
semanticAttributes.tsexport over time but I'd prefer doing this in follow-up PRs, case-by-case since this will change a lot of files for each attribute.ref #18895